From: Will Deacon <will@kernel.org>
To: Ard Biesheuvel <ardb@kernel.org>, linux-arm-kernel@lists.infradead.org
Cc: catalin.marinas@arm.com, kernel-team@android.com,
Will Deacon <will@kernel.org>, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] arm64: lds: use PROVIDE instead of conditional definitions
Date: Wed, 29 Jun 2022 10:33:50 +0100 [thread overview]
Message-ID: <165649448483.3057465.18219848797375063552.b4-ty@kernel.org> (raw)
In-Reply-To: <20220629083246.3729177-1-ardb@kernel.org>
On Wed, 29 Jun 2022 10:32:46 +0200, Ard Biesheuvel wrote:
> Currently, a build with CONFIG_EFI=n and CONFIG_KASAN=y will not
> complete successfully because of missing symbols. This is due to the
> fact that the __pi_ prefixed aliases for __memcpy/__memmove were put
> inside a #ifdef CONFIG_EFI block inadvertently, and are therefore
> missing from the build in question.
>
> These definitions should only be provided when needed, as they will
> otherwise clutter up the symbol table, kallsyms etc for no reason.
> Fortunately, instead of using CPP conditionals, we can achieve the same
> result by using the linker's PROVIDE() directive, which only defines a
> symbol if it is required to complete the link. So let's use that for all
> symbols alias definitions.
>
> [...]
Applied to arm64 (for-next/boot), thanks!
[1/1] arm64: lds: use PROVIDE instead of conditional definitions
https://git.kernel.org/arm64/c/fbf6ad5efe95
Cheers,
--
Will
https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2022-06-29 9:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-29 8:32 [PATCH] arm64: lds: use PROVIDE instead of conditional definitions Ard Biesheuvel
2022-06-29 9:33 ` Will Deacon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=165649448483.3057465.18219848797375063552.b4-ty@kernel.org \
--to=will@kernel.org \
--cc=ardb@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=kernel-team@android.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.