From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52AE4C433EF for ; Thu, 30 Jun 2022 11:46:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235120AbiF3Lq1 (ORCPT ); Thu, 30 Jun 2022 07:46:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60692 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235134AbiF3LqR (ORCPT ); Thu, 30 Jun 2022 07:46:17 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D8445A46C for ; Thu, 30 Jun 2022 04:46:14 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EE8A061674 for ; Thu, 30 Jun 2022 11:46:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9DB84C3411E; Thu, 30 Jun 2022 11:46:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1656589573; bh=0ym2LTs77ZRWFWozd0cF2LZIZ6ITiiE1pQFIzfSs02Y=; h=From:To:Cc:In-Reply-To:References:Subject:Date:From; b=uO1few8ys8A95Q356DB5H9/5+9MUnUUEB4C5mzkDqZq3BaGmy6409Ed8daWH20QiP KO6lzVtXL5Ex4z7t8xxUTysvnaC0cJfMODkciv1P9vwmkeURdHGrVsWpYeUJybhK3o mcvs0dhfPdc4VEiygsYmqBkWIe5vLCM9D5teMkYUcy5ssjyyPWuCLKGxD+UqTklAg8 etToLp0rrE2+v+hPitJyHC1XRexOQ491WoCiORxUdDCxlSTAEJ9XMBf3RktHbOrLhq 7Si87jrs8Tpu/k/AYqE+YZY5HCS4Xbqilkg524vjcmlQq8ZL644u1os5teZHuusgWf YWqtb6H0B7MNA== From: Mark Brown To: s.nawrocki@samsung.com, lgirdwood@gmail.com, Arnd Bergmann , perex@perex.cz, trix@redhat.com, tiwai@suse.com, krzysztof.kozlowski@linaro.org Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org In-Reply-To: <20220629185345.910406-1-trix@redhat.com> References: <20220629185345.910406-1-trix@redhat.com> Subject: Re: [PATCH] ASoC: samsung: change gpiod_speaker_power and rx1950_audio from global to static variables Message-Id: <165658957136.346792.13129934394557088460.b4-ty@kernel.org> Date: Thu, 30 Jun 2022 12:46:11 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 29 Jun 2022 14:53:45 -0400, Tom Rix wrote: > sparse reports > sound/soc/samsung/rx1950_uda1380.c:131:18: warning: symbol 'gpiod_speaker_power' was not declared. Should it be static? > sound/soc/samsung/rx1950_uda1380.c:231:24: warning: symbol 'rx1950_audio' was not declared. Should it be static? > > Both gpiod_speaker_power and rx1950_audio are only used in rx1950_uda1380.c, > so their storage class specifiers should be static. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: samsung: change gpiod_speaker_power and rx1950_audio from global to static variables commit: d2294461b90e0c5b3bbfaaf2c8baff4fd3e2bb13 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6AC4FC433EF for ; Thu, 30 Jun 2022 11:48:00 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 73BCE16CB; Thu, 30 Jun 2022 13:47:08 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 73BCE16CB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1656589678; bh=0ym2LTs77ZRWFWozd0cF2LZIZ6ITiiE1pQFIzfSs02Y=; h=From:To:In-Reply-To:References:Subject:Date:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Q23fz7uu5lj+QfBpoZmNLd/fhfhL4UAaEYQn21uRc7tYlkpn8S72p67rvP2MSNkC+ 9gQZjj4Z4/be8jyk5o9eyw7yIATJT1JKZstknBOYSCfr+mtp0ZBFUw/V1/UE1ByxkX AFzpHeZebL/66isH3wRz+uGGarQyBB0g4QRUUPhs= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id A997BF8052E; Thu, 30 Jun 2022 13:46:22 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 6F325F804EB; Thu, 30 Jun 2022 13:46:19 +0200 (CEST) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id D3E66F804E5 for ; Thu, 30 Jun 2022 13:46:15 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz D3E66F804E5 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="uO1few8y" Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id F2B16616B2; Thu, 30 Jun 2022 11:46:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9DB84C3411E; Thu, 30 Jun 2022 11:46:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1656589573; bh=0ym2LTs77ZRWFWozd0cF2LZIZ6ITiiE1pQFIzfSs02Y=; h=From:To:Cc:In-Reply-To:References:Subject:Date:From; b=uO1few8ys8A95Q356DB5H9/5+9MUnUUEB4C5mzkDqZq3BaGmy6409Ed8daWH20QiP KO6lzVtXL5Ex4z7t8xxUTysvnaC0cJfMODkciv1P9vwmkeURdHGrVsWpYeUJybhK3o mcvs0dhfPdc4VEiygsYmqBkWIe5vLCM9D5teMkYUcy5ssjyyPWuCLKGxD+UqTklAg8 etToLp0rrE2+v+hPitJyHC1XRexOQ491WoCiORxUdDCxlSTAEJ9XMBf3RktHbOrLhq 7Si87jrs8Tpu/k/AYqE+YZY5HCS4Xbqilkg524vjcmlQq8ZL644u1os5teZHuusgWf YWqtb6H0B7MNA== From: Mark Brown To: s.nawrocki@samsung.com, lgirdwood@gmail.com, Arnd Bergmann , perex@perex.cz, trix@redhat.com, tiwai@suse.com, krzysztof.kozlowski@linaro.org In-Reply-To: <20220629185345.910406-1-trix@redhat.com> References: <20220629185345.910406-1-trix@redhat.com> Subject: Re: [PATCH] ASoC: samsung: change gpiod_speaker_power and rx1950_audio from global to static variables Message-Id: <165658957136.346792.13129934394557088460.b4-ty@kernel.org> Date: Thu, 30 Jun 2022 12:46:11 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Wed, 29 Jun 2022 14:53:45 -0400, Tom Rix wrote: > sparse reports > sound/soc/samsung/rx1950_uda1380.c:131:18: warning: symbol 'gpiod_speaker_power' was not declared. Should it be static? > sound/soc/samsung/rx1950_uda1380.c:231:24: warning: symbol 'rx1950_audio' was not declared. Should it be static? > > Both gpiod_speaker_power and rx1950_audio are only used in rx1950_uda1380.c, > so their storage class specifiers should be static. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: samsung: change gpiod_speaker_power and rx1950_audio from global to static variables commit: d2294461b90e0c5b3bbfaaf2c8baff4fd3e2bb13 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark