* [PATCH] arm64: dta: qcom: sc7180: delete vdda-1p2 and vdda-0p9 from mdss_dp
@ 2022-07-01 15:47 Kuogee Hsieh
2022-07-01 16:06 ` Doug Anderson
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Kuogee Hsieh @ 2022-07-01 15:47 UTC (permalink / raw)
To: robdclark, sean, swboyd, dianders, vkoul, agross,
bjorn.andersson, robh+dt, devicetree
Cc: quic_abhinavk, quic_aravindh, quic_khsieh, quic_sbillaka,
quic_mkrishn, quic_kalyant, freedreno, linux-arm-msm,
linux-kernel
Both vdda-1p2-supply and vdda-0p9-supply regulators are controlled
by dp combo phy. Therefore remove them from dp controller.
Signed-off-by: Kuogee Hsieh <quic_khsieh@quicinc.com>
---
arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
index 732e118..824a98c 100644
--- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
@@ -813,8 +813,6 @@ hp_i2c: &i2c9 {
pinctrl-names = "default";
pinctrl-0 = <&dp_hot_plug_det>;
data-lanes = <0 1>;
- vdda-1p2-supply = <&vdda_usb_ss_dp_1p2>;
- vdda-0p9-supply = <&vdda_usb_ss_dp_core>;
};
&pm6150_adc {
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dta: qcom: sc7180: delete vdda-1p2 and vdda-0p9 from mdss_dp
2022-07-01 15:47 [PATCH] arm64: dta: qcom: sc7180: delete vdda-1p2 and vdda-0p9 from mdss_dp Kuogee Hsieh
@ 2022-07-01 16:06 ` Doug Anderson
2022-07-06 23:31 ` Stephen Boyd
2022-07-07 2:31 ` (subset) " Bjorn Andersson
2 siblings, 0 replies; 4+ messages in thread
From: Doug Anderson @ 2022-07-01 16:06 UTC (permalink / raw)
To: Kuogee Hsieh
Cc: Rob Clark, Sean Paul, Stephen Boyd, Vinod Koul, Andy Gross,
Bjorn Andersson, Rob Herring,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Abhinav Kumar (QUIC), Aravind Venkateswaran (QUIC),
Sankeerth Billakanti, quic_mkrishn, quic_kalyant, freedreno,
linux-arm-msm, LKML
Hi,
On Fri, Jul 1, 2022 at 8:47 AM Kuogee Hsieh <quic_khsieh@quicinc.com> wrote:
>
> Both vdda-1p2-supply and vdda-0p9-supply regulators are controlled
> by dp combo phy. Therefore remove them from dp controller.
>
> Signed-off-by: Kuogee Hsieh <quic_khsieh@quicinc.com>
> ---
> arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> index 732e118..824a98c 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> @@ -813,8 +813,6 @@ hp_i2c: &i2c9 {
> pinctrl-names = "default";
> pinctrl-0 = <&dp_hot_plug_det>;
> data-lanes = <0 1>;
> - vdda-1p2-supply = <&vdda_usb_ss_dp_1p2>;
> - vdda-0p9-supply = <&vdda_usb_ss_dp_core>;
> };
Reviewed-by: Douglas Anderson <dianders@chromium.org>
NOTE: this is somewhat related to Kuogee's series [1] but it's OK to
take even though his series hasn't landed. On trogdor we always keep
these regulators in HPM mode so we're not truly dependent on the
addition of regulator_set_load in the DP PHY.
[1] https://lore.kernel.org/lkml/8b751eb3-2e19-0e03-4c94-b26b3badd397@linaro.org/
-Doug
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dta: qcom: sc7180: delete vdda-1p2 and vdda-0p9 from mdss_dp
2022-07-01 15:47 [PATCH] arm64: dta: qcom: sc7180: delete vdda-1p2 and vdda-0p9 from mdss_dp Kuogee Hsieh
2022-07-01 16:06 ` Doug Anderson
@ 2022-07-06 23:31 ` Stephen Boyd
2022-07-07 2:31 ` (subset) " Bjorn Andersson
2 siblings, 0 replies; 4+ messages in thread
From: Stephen Boyd @ 2022-07-06 23:31 UTC (permalink / raw)
To: Kuogee Hsieh, agross, bjorn.andersson, devicetree, dianders,
robdclark, robh+dt, sean, vkoul
Cc: quic_abhinavk, quic_aravindh, quic_sbillaka, quic_mkrishn,
quic_kalyant, freedreno, linux-arm-msm, linux-kernel
Subject should have 'dts', not 'dta'.
Quoting Kuogee Hsieh (2022-07-01 08:47:16)
> Both vdda-1p2-supply and vdda-0p9-supply regulators are controlled
> by dp combo phy. Therefore remove them from dp controller.
>
> Signed-off-by: Kuogee Hsieh <quic_khsieh@quicinc.com>
> ---
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: (subset) [PATCH] arm64: dta: qcom: sc7180: delete vdda-1p2 and vdda-0p9 from mdss_dp
2022-07-01 15:47 [PATCH] arm64: dta: qcom: sc7180: delete vdda-1p2 and vdda-0p9 from mdss_dp Kuogee Hsieh
2022-07-01 16:06 ` Doug Anderson
2022-07-06 23:31 ` Stephen Boyd
@ 2022-07-07 2:31 ` Bjorn Andersson
2 siblings, 0 replies; 4+ messages in thread
From: Bjorn Andersson @ 2022-07-07 2:31 UTC (permalink / raw)
To: vkoul, robh+dt, sean, agross, dianders, devicetree, Kuogee Hsieh,
robdclark, swboyd
Cc: linux-arm-msm, quic_aravindh, freedreno, quic_mkrishn,
quic_abhinavk, quic_kalyant, quic_sbillaka, linux-kernel
On Fri, 1 Jul 2022 08:47:16 -0700, Kuogee Hsieh wrote:
> Both vdda-1p2-supply and vdda-0p9-supply regulators are controlled
> by dp combo phy. Therefore remove them from dp controller.
>
>
Applied, thanks!
[1/1] arm64: dta: qcom: sc7180: delete vdda-1p2 and vdda-0p9 from mdss_dp
commit: 154fd146a446c0fffa81d72c78611b0ce26b2718
Best regards,
--
Bjorn Andersson <bjorn.andersson@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-07-07 2:32 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-01 15:47 [PATCH] arm64: dta: qcom: sc7180: delete vdda-1p2 and vdda-0p9 from mdss_dp Kuogee Hsieh
2022-07-01 16:06 ` Doug Anderson
2022-07-06 23:31 ` Stephen Boyd
2022-07-07 2:31 ` (subset) " Bjorn Andersson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.