All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patchwork <patchwork@emeril.freedesktop.org>
To: "Matt Roper" <matthew.d.roper@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gt: Add general DSS steering iterator to intel_gt_mcr
Date: Sat, 02 Jul 2022 02:25:21 -0000	[thread overview]
Message-ID: <165672872134.30215.5348209113759250338@emeril.freedesktop.org> (raw)
In-Reply-To: <20220701232006.1016135-1-matthew.d.roper@intel.com>

== Series Details ==

Series: drm/i915/gt: Add general DSS steering iterator to intel_gt_mcr
URL   : https://patchwork.freedesktop.org/series/105883/
State : warning

== Summary ==

Error: dim checkpatch failed
044b58d3ed70 drm/i915/gt: Add general DSS steering iterator to intel_gt_mcr
-:135: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#135: FILE: drivers/gpu/drm/i915/gt/intel_gt_mcr.c:509:
+void intel_gt_mcr_get_ss_steering(struct intel_gt *gt, unsigned int dss,
+				   unsigned int *group, unsigned int *instance)

-:166: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'gt_' - possible side-effects?
#166: FILE: drivers/gpu/drm/i915/gt/intel_gt_mcr.h:43:
+#define _HAS_SS(ss_, gt_, group_, instance_) ( \
+	GRAPHICS_VER_FULL(gt_->i915) >= IP_VER(12, 50) ? \
+		intel_sseu_has_subslice(&(gt_)->info.sseu, 0, ss_) : \
+		intel_sseu_has_subslice(&(gt_)->info.sseu, group_, instance_))

-:166: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'gt_' may be better as '(gt_)' to avoid precedence issues
#166: FILE: drivers/gpu/drm/i915/gt/intel_gt_mcr.h:43:
+#define _HAS_SS(ss_, gt_, group_, instance_) ( \
+	GRAPHICS_VER_FULL(gt_->i915) >= IP_VER(12, 50) ? \
+		intel_sseu_has_subslice(&(gt_)->info.sseu, 0, ss_) : \
+		intel_sseu_has_subslice(&(gt_)->info.sseu, group_, instance_))

-:175: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'ss_' - possible side-effects?
#175: FILE: drivers/gpu/drm/i915/gt/intel_gt_mcr.h:52:
+#define for_each_ss_steering(ss_, gt_, group_, instance_) \
+	for (ss_ = 0, intel_gt_mcr_get_ss_steering(gt_, 0, &group_, &instance_); \
+	     ss_ < I915_MAX_SS_FUSE_BITS; \
+	     ss_++, intel_gt_mcr_get_ss_steering(gt_, ss_, &group_, &instance_)) \
+		for_each_if(_HAS_SS(ss_, gt_, group_, instance_))

-:175: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'gt_' - possible side-effects?
#175: FILE: drivers/gpu/drm/i915/gt/intel_gt_mcr.h:52:
+#define for_each_ss_steering(ss_, gt_, group_, instance_) \
+	for (ss_ = 0, intel_gt_mcr_get_ss_steering(gt_, 0, &group_, &instance_); \
+	     ss_ < I915_MAX_SS_FUSE_BITS; \
+	     ss_++, intel_gt_mcr_get_ss_steering(gt_, ss_, &group_, &instance_)) \
+		for_each_if(_HAS_SS(ss_, gt_, group_, instance_))

-:175: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'group_' - possible side-effects?
#175: FILE: drivers/gpu/drm/i915/gt/intel_gt_mcr.h:52:
+#define for_each_ss_steering(ss_, gt_, group_, instance_) \
+	for (ss_ = 0, intel_gt_mcr_get_ss_steering(gt_, 0, &group_, &instance_); \
+	     ss_ < I915_MAX_SS_FUSE_BITS; \
+	     ss_++, intel_gt_mcr_get_ss_steering(gt_, ss_, &group_, &instance_)) \
+		for_each_if(_HAS_SS(ss_, gt_, group_, instance_))

-:175: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'group_' may be better as '(group_)' to avoid precedence issues
#175: FILE: drivers/gpu/drm/i915/gt/intel_gt_mcr.h:52:
+#define for_each_ss_steering(ss_, gt_, group_, instance_) \
+	for (ss_ = 0, intel_gt_mcr_get_ss_steering(gt_, 0, &group_, &instance_); \
+	     ss_ < I915_MAX_SS_FUSE_BITS; \
+	     ss_++, intel_gt_mcr_get_ss_steering(gt_, ss_, &group_, &instance_)) \
+		for_each_if(_HAS_SS(ss_, gt_, group_, instance_))

-:175: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'instance_' - possible side-effects?
#175: FILE: drivers/gpu/drm/i915/gt/intel_gt_mcr.h:52:
+#define for_each_ss_steering(ss_, gt_, group_, instance_) \
+	for (ss_ = 0, intel_gt_mcr_get_ss_steering(gt_, 0, &group_, &instance_); \
+	     ss_ < I915_MAX_SS_FUSE_BITS; \
+	     ss_++, intel_gt_mcr_get_ss_steering(gt_, ss_, &group_, &instance_)) \
+		for_each_if(_HAS_SS(ss_, gt_, group_, instance_))

-:175: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'instance_' may be better as '(instance_)' to avoid precedence issues
#175: FILE: drivers/gpu/drm/i915/gt/intel_gt_mcr.h:52:
+#define for_each_ss_steering(ss_, gt_, group_, instance_) \
+	for (ss_ = 0, intel_gt_mcr_get_ss_steering(gt_, 0, &group_, &instance_); \
+	     ss_ < I915_MAX_SS_FUSE_BITS; \
+	     ss_++, intel_gt_mcr_get_ss_steering(gt_, ss_, &group_, &instance_)) \
+		for_each_if(_HAS_SS(ss_, gt_, group_, instance_))

total: 0 errors, 0 warnings, 9 checks, 237 lines checked



  reply	other threads:[~2022-07-02  2:25 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-01 23:20 [Intel-gfx] [PATCH] drm/i915/gt: Add general DSS steering iterator to intel_gt_mcr Matt Roper
2022-07-01 23:20 ` Matt Roper
2022-07-02  2:25 ` Patchwork [this message]
2022-07-02  2:47 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
2022-07-02 16:43 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gt: Add general DSS steering iterator to intel_gt_mcr (rev2) Patchwork
2022-07-02 16:43 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2022-07-02 17:04 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-07-02 18:25 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2022-07-08 16:35   ` Matt Roper
2022-07-08 16:45     ` Vudum, Lakshminarayana
2022-07-08 16:23 ` [Intel-gfx] [PATCH] drm/i915/gt: Add general DSS steering iterator to intel_gt_mcr Matt Atwood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=165672872134.30215.5348209113759250338@emeril.freedesktop.org \
    --to=patchwork@emeril.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=matthew.d.roper@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.