From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7DEECCA473 for ; Sun, 3 Jul 2022 03:59:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231874AbiGCD71 (ORCPT ); Sat, 2 Jul 2022 23:59:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57168 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232530AbiGCD6e (ORCPT ); Sat, 2 Jul 2022 23:58:34 -0400 Received: from mail-oa1-x34.google.com (mail-oa1-x34.google.com [IPv6:2001:4860:4864:20::34]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 16EDDBF69 for ; Sat, 2 Jul 2022 20:57:41 -0700 (PDT) Received: by mail-oa1-x34.google.com with SMTP id 586e51a60fabf-101b4f9e825so8839372fac.5 for ; Sat, 02 Jul 2022 20:57:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=Emxj6B8RLEpOF17lOK+icGSrGoqTCUV5gDGYAaGKNYU=; b=JIkCOxkvuDKif/JKQTFwmxzbCUkVlKSdTPVkMrcAKG+/yf21o0uLqYOrlf4Rbu738k TD23urciM/hGhP7KujJU8N6khIzr0037iDAOTzV8I4GOwACeSHmtjmRC/cL5Auaa1PUR Yrf4hCN3yd894HFTz9HFnkbXrpxgu6KRIgYt8bwVW+2S9cVi++rnRBfXFDywLYVyuoyU vcyCeVjSW2b7fE6jJuRYVuLIW/FwcxNNoWFvjTBidjq1trPxsMGxFmaisIQALHHrkYOz uMiSbw11tmgGIf0FgiJLf6gw9aOrztJz+VJr5EuEXzwxQPfBGz0bxbsDIImy9BykiYwB oo9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Emxj6B8RLEpOF17lOK+icGSrGoqTCUV5gDGYAaGKNYU=; b=5S3DbI2faOV+isyGLPG6mTn9jcdD6Yo1800g5aD3+rSK1y+l7vP+KTWSdq0dZVGJyb SVDJptWWFU/r9suLjA1asfHqmcC926dP5C4cXoe/WVWRwM4eA0GP5JfzRXrHqaflD02d mnzrf4BX8kP5sb8yL6Y/g9IYFTV6dLnQBrGeauCsXOK03ftpNDK7dHVD4yZmLvQXsyFK Z8VGNjQMM7QVGfWigassiTNGh3gOJYo9ictCMZAs94NnSGpR6HSqSb8aLhpEUmXBp6MG kABhyp9EnkOfiE7rO+Xi9H4Ren2Zoo/chAl2COEAFvcMwm+WGubtb/EhEmVf0w2YFHEP 5hFw== X-Gm-Message-State: AJIora9CCbpVOjISSeZNQpdN8jjrYQLYUkiE+884maQbdl5pEd8vgScF gF/6sawwR9vLu4lOu9ivWlVXDQ== X-Google-Smtp-Source: AGRyM1tCe8G0a4qQnf6SnaDROK2to8wo42AWtTmOaI55tWwortvw3/EP7wjiWIjRuBBFhYnRkyGarQ== X-Received: by 2002:a05:6870:2e05:b0:106:7fdc:de95 with SMTP id oi5-20020a0568702e0500b001067fdcde95mr13253919oab.123.1656820660785; Sat, 02 Jul 2022 20:57:40 -0700 (PDT) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id 25-20020aca0f19000000b0032e5d0b5d5fsm12965910oip.58.2022.07.02.20.57.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 02 Jul 2022 20:57:40 -0700 (PDT) From: Bjorn Andersson To: Brian Masney , Andy Gross , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Miaoqian Lin , Rob Clark Subject: Re: (subset) [PATCH] soc: qcom: ocmem: Fix refcount leak in of_get_ocmem Date: Sat, 2 Jul 2022 22:56:34 -0500 Message-Id: <165682055970.445910.4147931159861380417.b4-ty@linaro.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220602042430.1114-1-linmq006@gmail.com> References: <20220602042430.1114-1-linmq006@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Thu, 2 Jun 2022 08:24:30 +0400, Miaoqian Lin wrote: > of_parse_phandle() returns a node pointer with refcount > incremented, we should use of_node_put() on it when not need anymore. > Add missing of_node_put() to avoid refcount leak. > of_node_put() will check NULL pointer. > > Applied, thanks! [1/1] soc: qcom: ocmem: Fix refcount leak in of_get_ocmem commit: 92a563fcf14b3093226fb36f12e9b5cf630c5a5d Best regards, -- Bjorn Andersson