From: Grzegorz Siwik <grzegorz.siwik@intel.com>
To: intel-wired-lan@lists.osuosl.org
Cc: Grzegorz Siwik <grzegorz.siwik@intel.com>
Subject: [Intel-wired-lan] [PATCH net v1 2/3] ice: Ignore ERR_ALREADY_EXISTS when setting promisc mode
Date: Thu, 7 Jul 2022 15:15:50 +0200 [thread overview]
Message-ID: <1657199751-256188-3-git-send-email-grzegorz.siwik@intel.com> (raw)
In-Reply-To: <1657199751-256188-1-git-send-email-grzegorz.siwik@intel.com>
Ignore ERR_ALREADY_EXISTS error when setting promiscuous mode.
This fix is needed because the driver could set promiscuous mode
when it still has not cleared properly.
Promiscuous mode could be set only once, so setting it second
time will be rejected.
Fixes: 5eda8afd6bcc ("ice: Add support for PF/VF promiscuous mode")
Signed-off-by: Grzegorz Siwik <grzegorz.siwik@intel.com>
Tested-by: Jaroslav Pulchart <jaroslav.pulchart@gooddata.com>
Tested-by: Igor Raits <igor@gooddata.com>
Link:
https://lore.kernel.org/all/CAK8fFZ7m-KR57M_rYX6xZN39K89O=LGooYkKsu6HKt0Bs+x6xQ@mail.gmail.com/
---
drivers/net/ethernet/intel/ice/ice_switch.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/ice/ice_switch.c b/drivers/net/ethernet/intel/ice/ice_switch.c
index 8a60052..0aa4871 100644
--- a/drivers/net/ethernet/intel/ice/ice_switch.c
+++ b/drivers/net/ethernet/intel/ice/ice_switch.c
@@ -4428,7 +4428,7 @@ static u8 ice_determine_promisc_mask(struct ice_fltr_info *fi)
else
status = ice_set_vsi_promisc(hw, vsi_handle,
promisc_mask, vlan_id);
- if (status)
+ if (status && status != -EEXIST)
break;
}
--
1.8.3.1
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
next prev parent reply other threads:[~2022-07-07 13:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-07 13:15 [Intel-wired-lan] [PATCH net v1 0/3] ice: Fixes for double vlan promiscuous mode Grzegorz Siwik
2022-07-07 13:15 ` [Intel-wired-lan] [PATCH net v1 1/3] ice: Fix double VLAN error when entering promisc mode Grzegorz Siwik
2022-07-26 5:33 ` G, GurucharanX
2022-07-27 9:53 ` Petr Oros
2022-07-27 12:51 ` Siwik, Grzegorz
2022-07-29 13:06 ` Siwik, Grzegorz
2022-07-07 13:15 ` Grzegorz Siwik [this message]
2022-07-18 13:56 ` [Intel-wired-lan] [PATCH net v1 2/3] ice: Ignore ERR_ALREADY_EXISTS when setting " G, GurucharanX
2022-07-07 13:15 ` [Intel-wired-lan] [PATCH net v1 3/3] ice: Fix clearing of promisc mode with bridge over bond Grzegorz Siwik
2022-07-18 12:17 ` G, GurucharanX
2022-07-11 13:38 ` [Intel-wired-lan] [PATCH net v1 0/3] ice: Fixes for double vlan promiscuous mode Petr Oros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1657199751-256188-3-git-send-email-grzegorz.siwik@intel.com \
--to=grzegorz.siwik@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.