From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC0EDCCA47F for ; Mon, 18 Jul 2022 22:59:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236179AbiGRW70 (ORCPT ); Mon, 18 Jul 2022 18:59:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55212 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236256AbiGRW7X (ORCPT ); Mon, 18 Jul 2022 18:59:23 -0400 Received: from mail-ot1-x331.google.com (mail-ot1-x331.google.com [IPv6:2607:f8b0:4864:20::331]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 04B6A286C5 for ; Mon, 18 Jul 2022 15:59:22 -0700 (PDT) Received: by mail-ot1-x331.google.com with SMTP id by10-20020a056830608a00b0061c1ac80e1dso10445567otb.13 for ; Mon, 18 Jul 2022 15:59:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=62y54wQxB5Ga3NFTlaQlQOLlwSf/Xs6fX8rzpQ+b4NE=; b=xeNVIxJIQGfmaCIF0FuGOVeMGZsPxdGgO4m0U7Etg9XEKTyE2fZQWlB5awqxEfHrzR ru+gQpjkDGRUEPS/+SHyHTah/uirFcFjYUa1s8EGKFcZD7gjoriEmukvNwZVxKcG7nrU VnwDgyhJuy7qRQ0v9i9fjr0BqlLyEokCE4KPJrCmIJTegyAPrc+evYpIMr9sWkUbs/2V 79m3pEBPRvH99k6xzR7P7C3WGKfoIx1Y7SMjp+onMeFLRY0fH+4OKZtfLFGGfNCLu4IS 51OrGwI+EGlUIoYPi3HEJ3BNbOH/Cl+e5B3pJLO10Io5jyqnyaYqGLL8jkN8QY/0Yd+T p2nQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=62y54wQxB5Ga3NFTlaQlQOLlwSf/Xs6fX8rzpQ+b4NE=; b=sXV6nY01b4Rcykko0LI5pgyZJesnBG7YILjcZjqUtOVHcjvLKEXram8z/0IDBjBfqf ctgd230QfLAI/tB+5m/8c3Z6RD4Nd3G2kMzWryhxnOhJSXvpabDgh9Nk6YYtss+oEoIK DPe6TVUqzgcyIWIJE8o9aSF/eZw0SPAc9fTYIdqC8DT8bPt2RmM8miBsDRovm5lMobpq Tr//bfTizq6RKDmX1A88VUWfXDMEFBlAxzY0zCvzQnNVf62tO/MzF0EsOEHAOuoTG0VG BuNvLfszTZkqKcFgmarHouZYLbslgEjYHhGeoCfnLFiZcX2oShs8nEufv4M0jzvn2BXd 85Og== X-Gm-Message-State: AJIora9/DAE8Jez3ZisFuXlgvXMCbdzD5RnjwOEaArxzCerLPj1Tdt7r tTmOjJZfpFJe7ygRz18jXXltUQ== X-Google-Smtp-Source: AGRyM1u4xgWpcB3MTEEaiDUTpGZZrIEArX+mVcAS0lu3qMxLRot0DnvnH9s/exLkIl9stcVu5tO0sA== X-Received: by 2002:a05:6830:3706:b0:61c:5d4c:7a26 with SMTP id bl6-20020a056830370600b0061c5d4c7a26mr11459899otb.250.1658185161387; Mon, 18 Jul 2022 15:59:21 -0700 (PDT) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id j10-20020a4a908a000000b0041ba304546csm5330931oog.1.2022.07.18.15.59.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Jul 2022 15:59:20 -0700 (PDT) From: Bjorn Andersson To: linux-kernel@vger.kernel.org, krzysztof.kozlowski@linaro.org, agross@kernel.org, sboyd@kernel.org, mturquette@baylibre.com, linux-clk@vger.kernel.org, mathieu.poirier@linaro.org, linux-remoteproc@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: (subset) [PATCH 4/8] rpmsg: qcom: glink: replace strncpy() with strscpy_pad() Date: Mon, 18 Jul 2022 17:59:06 -0500 Message-Id: <165817634384.1905814.11996354687051888253.b4-ty@linaro.org> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20220501103520.111561-4-krzysztof.kozlowski@linaro.org> References: <20220501103520.111561-1-krzysztof.kozlowski@linaro.org> <20220501103520.111561-4-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org On Sun, 1 May 2022 12:35:16 +0200, Krzysztof Kozlowski wrote: > The use of strncpy() is considered deprecated for NUL-terminated > strings[1]. Replace strncpy() with strscpy_pad(), to keep existing > pad-behavior of strncpy, similarly to commit 08de420a8014 ("rpmsg: > glink: Replace strncpy() with strscpy_pad()"). This fixes W=1 warning: > > In function ‘qcom_glink_rx_close’, > inlined from ‘qcom_glink_work’ at ../drivers/rpmsg/qcom_glink_native.c:1638:4: > drivers/rpmsg/qcom_glink_native.c:1549:17: warning: ‘strncpy’ specified bound 32 equals destination size [-Wstringop-truncation] > 1549 | strncpy(chinfo.name, channel->name, sizeof(chinfo.name)); > > [...] Applied, thanks! [4/8] rpmsg: qcom: glink: replace strncpy() with strscpy_pad() commit: 766279a8f85df32345dbda03b102ca1ee3d5ddea Best regards, -- Bjorn Andersson