All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: linux-kernel@vger.kernel.org, krzysztof.kozlowski@linaro.org,
	agross@kernel.org, mathieu.poirier@linaro.org,
	linux-remoteproc@vger.kernel.org, linux-arm-msm@vger.kernel.org
Cc: sboyd@kernel.org
Subject: Re: [PATCH v2 1/3] rpmsg: qcom: glink: replace strncpy() with strscpy_pad()
Date: Mon, 18 Jul 2022 17:59:07 -0500	[thread overview]
Message-ID: <165817634384.1905814.9434531838630907611.b4-ty@linaro.org> (raw)
In-Reply-To: <20220519073330.7187-1-krzysztof.kozlowski@linaro.org>

On Thu, 19 May 2022 09:33:28 +0200, Krzysztof Kozlowski wrote:
> The use of strncpy() is considered deprecated for NUL-terminated
> strings[1]. Replace strncpy() with strscpy_pad(), to keep existing
> pad-behavior of strncpy, similarly to commit 08de420a8014 ("rpmsg:
> glink: Replace strncpy() with strscpy_pad()").  This fixes W=1 warning:
> 
>   In function ‘qcom_glink_rx_close’,
>     inlined from ‘qcom_glink_work’ at ../drivers/rpmsg/qcom_glink_native.c:1638:4:
>   drivers/rpmsg/qcom_glink_native.c:1549:17: warning: ‘strncpy’ specified bound 32 equals destination size [-Wstringop-truncation]
>    1549 |                 strncpy(chinfo.name, channel->name, sizeof(chinfo.name));
> 
> [...]

Applied, thanks!

[1/3] rpmsg: qcom: glink: replace strncpy() with strscpy_pad()
      commit: 766279a8f85df32345dbda03b102ca1ee3d5ddea
[2/3] rpmsg: qcom: glink: remove unused name
      commit: 6c3ebc96ffefbc48297d7c2fd266e9cb78e6941e
[3/3] rpmsg: qcom: correct kerneldoc
      commit: 101042f4c0eb2daa331b4f7ce32c6d547114830a

Best regards,
-- 
Bjorn Andersson <bjorn.andersson@linaro.org>

      parent reply	other threads:[~2022-07-18 22:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-19  7:33 Krzysztof Kozlowski
2022-05-19  7:33 ` [PATCH v2 2/3] rpmsg: qcom: glink: remove unused name Krzysztof Kozlowski
2022-05-19  7:33 ` [PATCH v2 3/3] rpmsg: qcom: correct kerneldoc Krzysztof Kozlowski
2022-05-19 22:13 ` [PATCH v2 1/3] rpmsg: qcom: glink: replace strncpy() with strscpy_pad() Stephen Boyd
2022-06-09  8:56 ` Krzysztof Kozlowski
2022-06-20 18:37   ` Krzysztof Kozlowski
2022-07-05 12:14     ` Krzysztof Kozlowski
2022-07-05 15:06       ` Mathieu Poirier
2022-07-18 22:59 ` Bjorn Andersson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=165817634384.1905814.9434531838630907611.b4-ty@linaro.org \
    --to=bjorn.andersson@linaro.org \
    --cc=agross@kernel.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=sboyd@kernel.org \
    --subject='Re: [PATCH v2 1/3] rpmsg: qcom: glink: replace strncpy() with strscpy_pad()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.