All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patchwork <patchwork@emeril.freedesktop.org>
To: "Mauro Carvalho Chehab" <mchehab@kernel.org>
Cc: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: reduce TLB performance regressions
Date: Wed, 27 Jul 2022 13:12:27 -0000	[thread overview]
Message-ID: <165892754751.21595.5590651050138716126@emeril.freedesktop.org> (raw)
In-Reply-To: <cover.1658924372.git.mchehab@kernel.org>

== Series Details ==

Series: drm/i915: reduce TLB performance regressions
URL   : https://patchwork.freedesktop.org/series/106758/
State : warning

== Summary ==

Error: dim checkpatch failed
735755e9d5d5 drm/i915/gt: Ignore TLB invalidations on idle engines
-:138: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'gt' - possible side-effects?
#138: FILE: drivers/gpu/drm/i915/gt/intel_gt_pm.h:58:
+#define with_intel_gt_pm_if_awake(gt, wf) \
+	for (wf = intel_gt_pm_get_if_awake(gt); wf; intel_gt_pm_put_async(gt), wf = 0)

-:138: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'wf' - possible side-effects?
#138: FILE: drivers/gpu/drm/i915/gt/intel_gt_pm.h:58:
+#define with_intel_gt_pm_if_awake(gt, wf) \
+	for (wf = intel_gt_pm_get_if_awake(gt); wf; intel_gt_pm_put_async(gt), wf = 0)

total: 0 errors, 0 warnings, 2 checks, 99 lines checked
225d8336f971 drm/i915/gt: document with_intel_gt_pm_if_awake()
14c4636e0625 drm/i915/gt: Invalidate TLB of the OA unit at TLB invalidations
2bbb43b7f32b drm/i915/gt: Skip TLB invalidations once wedged
0cb17ababb41 drm/i915/gt: Batch TLB invalidations
051e0bf95aa1 drm/i915/gt: describe the new tlb parameter at i915_vma_resource



  parent reply	other threads:[~2022-07-27 13:12 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-27 12:29 [PATCH v3 0/6] drm/i915: reduce TLB performance regressions Mauro Carvalho Chehab
2022-07-27 12:29 ` [Intel-gfx] " Mauro Carvalho Chehab
2022-07-27 12:29 ` Mauro Carvalho Chehab
2022-07-27 12:29 ` [PATCH v3 1/6] drm/i915/gt: Ignore TLB invalidations on idle engines Mauro Carvalho Chehab
2022-07-27 12:29   ` [Intel-gfx] " Mauro Carvalho Chehab
2022-07-27 12:29   ` Mauro Carvalho Chehab
2022-07-27 12:29 ` [PATCH v3 2/6] drm/i915/gt: document with_intel_gt_pm_if_awake() Mauro Carvalho Chehab
2022-07-27 12:29   ` [Intel-gfx] " Mauro Carvalho Chehab
2022-07-27 12:29   ` Mauro Carvalho Chehab
2022-07-27 14:18   ` [Intel-gfx] " Andi Shyti
2022-07-27 14:18     ` Andi Shyti
2022-07-27 12:29 ` [PATCH v3 3/6] drm/i915/gt: Invalidate TLB of the OA unit at TLB invalidations Mauro Carvalho Chehab
2022-07-27 12:29   ` [Intel-gfx] " Mauro Carvalho Chehab
2022-07-27 12:29   ` Mauro Carvalho Chehab
2022-07-27 12:29 ` [PATCH v3 4/6] drm/i915/gt: Skip TLB invalidations once wedged Mauro Carvalho Chehab
2022-07-27 12:29   ` [Intel-gfx] " Mauro Carvalho Chehab
2022-07-27 12:29   ` Mauro Carvalho Chehab
2022-07-27 12:29 ` [PATCH v3 5/6] drm/i915/gt: Batch TLB invalidations Mauro Carvalho Chehab
2022-07-27 12:29   ` [Intel-gfx] " Mauro Carvalho Chehab
2022-07-27 12:29   ` Mauro Carvalho Chehab
2022-07-27 14:25   ` Andi Shyti
2022-07-27 14:25     ` [Intel-gfx] " Andi Shyti
2022-07-27 14:25     ` Andi Shyti
2022-07-27 12:29 ` [PATCH v3 6/6] drm/i915/gt: describe the new tlb parameter at i915_vma_resource Mauro Carvalho Chehab
2022-07-27 12:29   ` [Intel-gfx] " Mauro Carvalho Chehab
2022-07-27 12:29   ` Mauro Carvalho Chehab
2022-07-27 14:20   ` [Intel-gfx] " Andi Shyti
2022-07-27 13:12 ` Patchwork [this message]
2022-07-27 13:37 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: reduce TLB performance regressions Patchwork
2022-07-27 15:52 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2022-07-28 12:08 ` [Intel-gfx] [PATCH v3 0/6] " Andi Shyti
2022-07-28 12:08   ` Andi Shyti
2022-07-28 12:08   ` Andi Shyti
2022-07-28 12:34   ` Mauro Carvalho Chehab
2022-07-28 12:34     ` Mauro Carvalho Chehab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=165892754751.21595.5590651050138716126@emeril.freedesktop.org \
    --to=patchwork@emeril.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=mchehab@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.