From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A7FAC3F6B0 for ; Thu, 18 Aug 2022 01:57:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242633AbiHRB5q (ORCPT ); Wed, 17 Aug 2022 21:57:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36956 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241809AbiHRB5o (ORCPT ); Wed, 17 Aug 2022 21:57:44 -0400 Received: from out199-7.us.a.mail.aliyun.com (out199-7.us.a.mail.aliyun.com [47.90.199.7]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C4F82A4B3C; Wed, 17 Aug 2022 18:57:42 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R141e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046056;MF=xuanzhuo@linux.alibaba.com;NM=1;PH=DS;RN=19;SR=0;TI=SMTPD_---0VMYQwYj_1660787855; Received: from localhost(mailfrom:xuanzhuo@linux.alibaba.com fp:SMTPD_---0VMYQwYj_1660787855) by smtp.aliyun-inc.com; Thu, 18 Aug 2022 09:57:36 +0800 Message-ID: <1660787737.7869372-1-xuanzhuo@linux.alibaba.com> Subject: Re: upstream kernel crashes Date: Thu, 18 Aug 2022 09:55:37 +0800 From: Xuan Zhuo To: Linus Torvalds Cc: Dmitry Vyukov , James.Bottomley@hansenpartnership.com, andres@anarazel.de, axboe@kernel.dk, c@redhat.com, davem@davemloft.net, edumazet@google.com, gregkh@linuxfoundation.org, jasowang@redhat.com, kuba@kernel.org, linux-kernel@vger.kernel.org, linux@roeck-us.net, martin.petersen@oracle.com, netdev@vger.kernel.org, pabeni@redhat.com, virtualization@lists.linux-foundation.org, kasan-dev@googlegroups.com, mst@redhat.com References: <20220815113729-mutt-send-email-mst@kernel.org> <20220815164503.jsoezxcm6q4u2b6j@awork3.anarazel.de> <20220815124748-mutt-send-email-mst@kernel.org> <20220815174617.z4chnftzcbv6frqr@awork3.anarazel.de> <20220815161423-mutt-send-email-mst@kernel.org> <20220815205330.m54g7vcs77r6owd6@awork3.anarazel.de> <20220815170444-mutt-send-email-mst@kernel.org> <20220817061359.200970-1-dvyukov@google.com> <1660718191.3631961-1-xuanzhuo@linux.alibaba.com> In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 17 Aug 2022 08:58:20 -0700, Linus Torvalds wrote: > On Tue, Aug 16, 2022 at 11:47 PM Xuan Zhuo wrote: > > > > + BUG_ON(num != virtqueue_get_vring_size(vq)); > > + > > Please, no more BUG_ON. > > Add a WARN_ON_ONCE() and return an error. OK, I will post v2 with WARN_ON_ONCE(). Thanks. > > Linus From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 64DF4C32771 for ; Thu, 18 Aug 2022 01:57:48 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id BF697405DF; Thu, 18 Aug 2022 01:57:47 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org BF697405DF X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wXbgqbw3yfFT; Thu, 18 Aug 2022 01:57:47 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp2.osuosl.org (Postfix) with ESMTPS id 5868340272; Thu, 18 Aug 2022 01:57:46 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 5868340272 Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 25306C0033; Thu, 18 Aug 2022 01:57:46 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137]) by lists.linuxfoundation.org (Postfix) with ESMTP id 048DAC002D for ; Thu, 18 Aug 2022 01:57:45 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id C27D44194D for ; Thu, 18 Aug 2022 01:57:44 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org C27D44194D X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BB3AHpAD226Z for ; Thu, 18 Aug 2022 01:57:43 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 2621C418D8 Received: from out30-43.freemail.mail.aliyun.com (out30-43.freemail.mail.aliyun.com [115.124.30.43]) by smtp4.osuosl.org (Postfix) with ESMTPS id 2621C418D8 for ; Thu, 18 Aug 2022 01:57:42 +0000 (UTC) X-Alimail-AntiSpam: AC=PASS; BC=-1|-1; BR=01201311R141e4; CH=green; DM=||false|; DS=||; FP=0|-1|-1|-1|0|-1|-1|-1; HT=ay29a033018046056; MF=xuanzhuo@linux.alibaba.com; NM=1; PH=DS; RN=19; SR=0; TI=SMTPD_---0VMYQwYj_1660787855; Received: from localhost(mailfrom:xuanzhuo@linux.alibaba.com fp:SMTPD_---0VMYQwYj_1660787855) by smtp.aliyun-inc.com; Thu, 18 Aug 2022 09:57:36 +0800 Message-ID: <1660787737.7869372-1-xuanzhuo@linux.alibaba.com> Subject: Re: upstream kernel crashes Date: Thu, 18 Aug 2022 09:55:37 +0800 From: Xuan Zhuo To: Linus Torvalds References: <20220815113729-mutt-send-email-mst@kernel.org> <20220815164503.jsoezxcm6q4u2b6j@awork3.anarazel.de> <20220815124748-mutt-send-email-mst@kernel.org> <20220815174617.z4chnftzcbv6frqr@awork3.anarazel.de> <20220815161423-mutt-send-email-mst@kernel.org> <20220815205330.m54g7vcs77r6owd6@awork3.anarazel.de> <20220815170444-mutt-send-email-mst@kernel.org> <20220817061359.200970-1-dvyukov@google.com> <1660718191.3631961-1-xuanzhuo@linux.alibaba.com> In-Reply-To: Cc: axboe@kernel.dk, martin.petersen@oracle.com, mst@redhat.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, virtualization@lists.linux-foundation.org, James.Bottomley@hansenpartnership.com, edumazet@google.com, linux@roeck-us.net, netdev@vger.kernel.org, c@redhat.com, kuba@kernel.org, pabeni@redhat.com, andres@anarazel.de, davem@davemloft.net, Dmitry Vyukov X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" On Wed, 17 Aug 2022 08:58:20 -0700, Linus Torvalds wrote: > On Tue, Aug 16, 2022 at 11:47 PM Xuan Zhuo wrote: > > > > + BUG_ON(num != virtqueue_get_vring_size(vq)); > > + > > Please, no more BUG_ON. > > Add a WARN_ON_ONCE() and return an error. OK, I will post v2 with WARN_ON_ONCE(). Thanks. > > Linus _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization