All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patchwork <patchwork@emeril.freedesktop.org>
To: "Hans de Goede" <hdegoede@redhat.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/kms: Stop registering multiple /sys/class/backlight devs for a single display
Date: Wed, 24 Aug 2022 19:33:27 -0000	[thread overview]
Message-ID: <166136960748.9870.8510428714292093940@emeril.freedesktop.org> (raw)
In-Reply-To: <20220818184302.10051-1-hdegoede@redhat.com>

== Series Details ==

Series: drm/kms: Stop registering multiple /sys/class/backlight devs for a single display
URL   : https://patchwork.freedesktop.org/series/107458/
State : warning

== Summary ==

Error: dim checkpatch failed
cb80f3f59bd6 ACPI: video: Add acpi_video_backlight_use_native() helper
-:112: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#112: FILE: include/acpi/video.h:59:
+extern bool acpi_video_backlight_use_native(void);

-:120: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#120: FILE: include/acpi/video.h:81:
 }
+static inline bool acpi_video_backlight_use_native(void)

total: 0 errors, 0 warnings, 2 checks, 73 lines checked
ada7f6aa183e drm/i915: Don't register backlight when another backlight should be used
d2076d7fa7ea drm/amdgpu: Don't register backlight when another backlight should be used (v3)
6f1c805b0235 drm/radeon: Don't register backlight when another backlight should be used (v3)
02d2d61143b8 drm/nouveau: Don't register backlight when another backlight should be used
8bb870ec22b8 ACPI: video: Drop backlight_device_get_by_type() call from acpi_video_get_backlight_type()
154c7e4c73b9 ACPI: video: Remove acpi_video_bus from list before tearing it down
af8465ff79bc ACPI: video: Simplify acpi_video_unregister_backlight()
354bb16670b3 ACPI: video: Make backlight class device registration a separate step (v2)
-:52: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#52: FILE: drivers/acpi/acpi_video.c:83:
+MODULE_PARM_DESC(register_backlight_delay,
+	"Delay in seconds before doing fallback (non GPU driver triggered) "

-:155: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#155: FILE: include/acpi/video.h:56:
+extern void acpi_video_register_backlight(void);

total: 0 errors, 0 warnings, 2 checks, 112 lines checked
e43d16d513b4 ACPI: video: Remove code to unregister acpi_video backlight when a native backlight registers
09766e6ec1a6 drm/i915: Call acpi_video_register_backlight() (v2)
2fa045cec44c drm/nouveau: Register ACPI video backlight when nv_backlight registration fails
ef75037ccf8f drm/amdgpu: Register ACPI video backlight when skipping amdgpu backlight registration
05643ebf860e drm/radeon: Register ACPI video backlight when skipping radeon backlight registration
dd0ba69514f3 platform/x86: nvidia-wmi-ec-backlight: Move fw interface definitions to a header
Traceback (most recent call last):
  File "scripts/spdxcheck.py", line 11, in <module>
    import git
ModuleNotFoundError: No module named 'git'
-:106: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#106: 
new file mode 100644

total: 0 errors, 1 warnings, 0 checks, 152 lines checked
e217beaed186 ACPI: video: Refactor acpi_video_get_backlight_type() a bit
b366d8080f7a ACPI: video: Add Nvidia WMI EC brightness control detection (v2)
3f9ceeb94d38 ACPI: video: Add Apple GMUX brightness control detection
db1305751296 platform/x86: nvidia-wmi-ec-backlight: Use acpi_video_get_backlight_type()
cf2e63785682 platform/x86: apple-gmux: Stop calling acpi/video.h functions
09b9c7436a7b platform/x86: toshiba_acpi: Stop using acpi_video_set_dmi_backlight_type()
8d44d8e0a9d7 platform/x86: acer-wmi: Move backlight DMI quirks to acpi/video_detect.c
6f9016e9f108 platform/x86: asus-wmi: Drop DMI chassis-type check from backlight handling
bd892357ead7 platform/x86: asus-wmi: Move acpi_backlight=vendor quirks to ACPI video_detect.c
cf8713ce7d3e platform/x86: asus-wmi: Move acpi_backlight=native quirks to ACPI video_detect.c
d6fae5b86e0b platform/x86: samsung-laptop: Move acpi_backlight=[vendor|native] quirks to ACPI video_detect.c
1b8ecc40baf3 ACPI: video: Remove acpi_video_set_dmi_backlight_type()
a532f7c59582 ACPI: video: Drop "Samsung X360" acpi_backlight=native quirk
aef8dc824671 ACPI: video: Drop NL5x?U, PF4NU1F and PF5?U?? acpi_backlight=native quirks
6af6d3d9f883 ACPI: video: Fix indentation of video_detect_dmi_table[] entries
17b93bb50c5c drm/todo: Add entry about dealing with brightness control on devices with > 1 panel
-:11: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#11: 
https://lore.kernel.org/dri-devel/20220517152331.16217-1-hdegoede@redhat.com/

total: 0 errors, 1 warnings, 0 checks, 74 lines checked



  parent reply	other threads:[~2022-08-24 19:34 UTC|newest]

Thread overview: 195+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-18 18:42 [PATCH v3 00/31] drm/kms: Stop registering multiple /sys/class/backlight devs for a single display Hans de Goede
2022-08-18 18:42 ` Hans de Goede
2022-08-18 18:42 ` [Intel-gfx] " Hans de Goede
2022-08-18 18:42 ` Hans de Goede
2022-08-18 18:42 ` [Nouveau] " Hans de Goede
2022-08-18 18:42 ` [PATCH v3 01/31] ACPI: video: Add acpi_video_backlight_use_native() helper Hans de Goede
2022-08-18 18:42   ` Hans de Goede
2022-08-18 18:42   ` [Intel-gfx] " Hans de Goede
2022-08-18 18:42   ` Hans de Goede
2022-08-18 18:42   ` [Nouveau] " Hans de Goede
2022-08-18 18:42 ` [PATCH v3 02/31] drm/i915: Don't register backlight when another backlight should be used Hans de Goede
2022-08-18 18:42   ` Hans de Goede
2022-08-18 18:42   ` Hans de Goede
2022-08-18 18:42   ` [Intel-gfx] " Hans de Goede
2022-08-18 18:42   ` [Nouveau] " Hans de Goede
2022-08-18 18:42 ` [PATCH v3 03/31] drm/amdgpu: Don't register backlight when another backlight should be used (v3) Hans de Goede
2022-08-18 18:42   ` Hans de Goede
2022-08-18 18:42   ` [Intel-gfx] " Hans de Goede
2022-08-18 18:42   ` Hans de Goede
2022-08-18 18:42   ` [Nouveau] " Hans de Goede
2022-08-18 18:42 ` [PATCH v3 04/31] drm/radeon: " Hans de Goede
2022-08-18 18:42   ` Hans de Goede
2022-08-18 18:42   ` Hans de Goede
2022-08-18 18:42   ` [Intel-gfx] " Hans de Goede
2022-08-18 18:42   ` [Nouveau] " Hans de Goede
2022-08-18 18:42 ` [PATCH v3 05/31] drm/nouveau: Don't register backlight when another backlight should be used Hans de Goede
2022-08-18 18:42   ` Hans de Goede
2022-08-18 18:42   ` [Intel-gfx] " Hans de Goede
2022-08-18 18:42   ` Hans de Goede
2022-08-18 18:42   ` [Nouveau] " Hans de Goede
2022-08-18 18:42 ` [PATCH v3 06/31] ACPI: video: Drop backlight_device_get_by_type() call from acpi_video_get_backlight_type() Hans de Goede
2022-08-18 18:42   ` Hans de Goede
2022-08-18 18:42   ` [Intel-gfx] " Hans de Goede
2022-08-18 18:42   ` Hans de Goede
2022-08-18 18:42   ` [Nouveau] " Hans de Goede
2022-08-18 18:42 ` [PATCH v3 07/31] ACPI: video: Remove acpi_video_bus from list before tearing it down Hans de Goede
2022-08-18 18:42   ` Hans de Goede
2022-08-18 18:42   ` [Intel-gfx] " Hans de Goede
2022-08-18 18:42   ` Hans de Goede
2022-08-18 18:42   ` [Nouveau] " Hans de Goede
2022-08-18 18:42 ` [PATCH v3 08/31] ACPI: video: Simplify acpi_video_unregister_backlight() Hans de Goede
2022-08-18 18:42   ` Hans de Goede
2022-08-18 18:42   ` [Intel-gfx] " Hans de Goede
2022-08-18 18:42   ` [Nouveau] " Hans de Goede
2022-08-18 18:42   ` Hans de Goede
2022-08-18 18:42 ` [PATCH v3 09/31] ACPI: video: Make backlight class device registration a separate step (v2) Hans de Goede
2022-08-18 18:42   ` Hans de Goede
2022-08-18 18:42   ` Hans de Goede
2022-08-18 18:42   ` [Nouveau] " Hans de Goede
2022-08-18 18:42   ` [Intel-gfx] " Hans de Goede
2022-08-18 20:07   ` [Nouveau] " Daniel Dadap
2022-08-18 20:07     ` [Intel-gfx] " Daniel Dadap
2022-08-18 20:07     ` Daniel Dadap
2022-08-18 20:07     ` Daniel Dadap
2022-08-18 20:07     ` Daniel Dadap
2022-08-19  8:50     ` Hans de Goede
2022-08-19  8:50       ` Hans de Goede
2022-08-19  8:50       ` [Intel-gfx] " Hans de Goede
2022-08-19  8:50       ` Hans de Goede
2022-08-19  8:50       ` [Nouveau] " Hans de Goede
2022-08-18 18:42 ` [PATCH v3 10/31] ACPI: video: Remove code to unregister acpi_video backlight when a native backlight registers Hans de Goede
2022-08-18 18:42   ` Hans de Goede
2022-08-18 18:42   ` [Intel-gfx] " Hans de Goede
2022-08-18 18:42   ` Hans de Goede
2022-08-18 18:42   ` [Nouveau] " Hans de Goede
2022-08-18 18:42 ` [PATCH v3 11/31] drm/i915: Call acpi_video_register_backlight() (v2) Hans de Goede
2022-08-18 18:42   ` Hans de Goede
2022-08-18 18:42   ` [Intel-gfx] " Hans de Goede
2022-08-18 18:42   ` Hans de Goede
2022-08-18 18:42   ` [Nouveau] " Hans de Goede
2022-08-18 18:42 ` [PATCH v3 12/31] drm/nouveau: Register ACPI video backlight when nv_backlight registration fails Hans de Goede
2022-08-18 18:42   ` [Intel-gfx] " Hans de Goede
2022-08-18 18:42   ` Hans de Goede
2022-08-18 18:42   ` Hans de Goede
2022-08-18 18:42   ` [Nouveau] " Hans de Goede
2022-08-18 18:42 ` [PATCH v3 13/31] drm/amdgpu: Register ACPI video backlight when skipping amdgpu backlight registration Hans de Goede
2022-08-18 18:42   ` Hans de Goede
2022-08-18 18:42   ` Hans de Goede
2022-08-18 18:42   ` [Intel-gfx] " Hans de Goede
2022-08-18 18:42   ` [Nouveau] " Hans de Goede
2022-08-18 18:42 ` [PATCH v3 14/31] drm/radeon: Register ACPI video backlight when skipping radeon " Hans de Goede
2022-08-18 18:42   ` Hans de Goede
2022-08-18 18:42   ` [Intel-gfx] " Hans de Goede
2022-08-18 18:42   ` Hans de Goede
2022-08-18 18:42   ` [Nouveau] " Hans de Goede
2022-08-18 18:42 ` [PATCH v3 15/31] platform/x86: nvidia-wmi-ec-backlight: Move fw interface definitions to a header Hans de Goede
2022-08-18 18:42   ` Hans de Goede
2022-08-18 18:42   ` Hans de Goede
2022-08-18 18:42   ` [Intel-gfx] " Hans de Goede
2022-08-18 18:42   ` [Nouveau] " Hans de Goede
2022-08-18 19:38   ` Daniel Dadap
2022-08-18 19:38     ` [Intel-gfx] " Daniel Dadap
2022-08-18 19:38     ` Daniel Dadap
2022-08-18 19:38     ` Daniel Dadap
2022-08-18 19:38     ` [Nouveau] " Daniel Dadap
2022-08-19 10:05     ` Hans de Goede
2022-08-19 10:05       ` Hans de Goede
2022-08-19 10:05       ` [Intel-gfx] " Hans de Goede
2022-08-19 10:05       ` Hans de Goede
2022-08-19 10:05       ` [Nouveau] " Hans de Goede
2022-08-18 18:42 ` [PATCH v3 16/31] ACPI: video: Refactor acpi_video_get_backlight_type() a bit Hans de Goede
2022-08-18 18:42   ` Hans de Goede
2022-08-18 18:42   ` [Intel-gfx] " Hans de Goede
2022-08-18 18:42   ` Hans de Goede
2022-08-18 18:42   ` [Nouveau] " Hans de Goede
2022-08-18 18:42 ` [PATCH v3 17/31] ACPI: video: Add Nvidia WMI EC brightness control detection (v2) Hans de Goede
2022-08-18 18:42   ` Hans de Goede
2022-08-18 18:42   ` [Intel-gfx] " Hans de Goede
2022-08-18 18:42   ` Hans de Goede
2022-08-18 18:42   ` [Nouveau] " Hans de Goede
2022-08-18 19:44   ` Daniel Dadap
2022-08-18 19:44     ` [Intel-gfx] " Daniel Dadap
2022-08-18 19:44     ` Daniel Dadap
2022-08-18 19:44     ` Daniel Dadap
2022-08-18 19:44     ` [Nouveau] " Daniel Dadap
2022-08-18 18:42 ` [PATCH v3 18/31] ACPI: video: Add Apple GMUX brightness control detection Hans de Goede
2022-08-18 18:42   ` Hans de Goede
2022-08-18 18:42   ` [Intel-gfx] " Hans de Goede
2022-08-18 18:42   ` Hans de Goede
2022-08-18 18:42   ` [Nouveau] " Hans de Goede
2022-08-18 18:42 ` [PATCH v3 19/31] platform/x86: nvidia-wmi-ec-backlight: Use acpi_video_get_backlight_type() Hans de Goede
2022-08-18 18:42   ` Hans de Goede
2022-08-18 18:42   ` [Intel-gfx] " Hans de Goede
2022-08-18 18:42   ` Hans de Goede
2022-08-18 18:42   ` [Nouveau] " Hans de Goede
2022-08-18 19:46   ` Daniel Dadap
2022-08-18 19:46     ` [Intel-gfx] " Daniel Dadap
2022-08-18 19:46     ` Daniel Dadap
2022-08-18 19:46     ` Daniel Dadap
2022-08-18 19:46     ` [Nouveau] " Daniel Dadap
2022-08-18 18:42 ` [PATCH v3 20/31] platform/x86: apple-gmux: Stop calling acpi/video.h functions Hans de Goede
2022-08-18 18:42   ` Hans de Goede
2022-08-18 18:42   ` Hans de Goede
2022-08-18 18:42   ` [Intel-gfx] " Hans de Goede
2022-08-18 18:42   ` [Nouveau] " Hans de Goede
2022-08-18 18:42 ` [PATCH v3 21/31] platform/x86: toshiba_acpi: Stop using acpi_video_set_dmi_backlight_type() Hans de Goede
2022-08-18 18:42   ` Hans de Goede
2022-08-18 18:42   ` Hans de Goede
2022-08-18 18:42   ` [Intel-gfx] " Hans de Goede
2022-08-18 18:42   ` [Nouveau] " Hans de Goede
2022-08-18 18:42 ` [PATCH v3 22/31] platform/x86: acer-wmi: Move backlight DMI quirks to acpi/video_detect.c Hans de Goede
2022-08-18 18:42   ` [Nouveau] " Hans de Goede
2022-08-18 18:42   ` Hans de Goede
2022-08-18 18:42   ` [Intel-gfx] " Hans de Goede
2022-08-18 18:42   ` Hans de Goede
2022-08-18 18:42 ` [PATCH v3 23/31] platform/x86: asus-wmi: Drop DMI chassis-type check from backlight handling Hans de Goede
2022-08-18 18:42   ` Hans de Goede
2022-08-18 18:42   ` Hans de Goede
2022-08-18 18:42   ` [Nouveau] " Hans de Goede
2022-08-18 18:42   ` [Intel-gfx] " Hans de Goede
2022-08-18 18:42 ` [PATCH v3 24/31] platform/x86: asus-wmi: Move acpi_backlight=vendor quirks to ACPI video_detect.c Hans de Goede
2022-08-18 18:42   ` Hans de Goede
2022-08-18 18:42   ` [Intel-gfx] " Hans de Goede
2022-08-18 18:42   ` Hans de Goede
2022-08-18 18:42   ` [Nouveau] " Hans de Goede
2022-08-18 18:42 ` [PATCH v3 25/31] platform/x86: asus-wmi: Move acpi_backlight=native " Hans de Goede
2022-08-18 18:42   ` Hans de Goede
2022-08-18 18:42   ` [Intel-gfx] " Hans de Goede
2022-08-18 18:42   ` Hans de Goede
2022-08-18 18:42   ` [Nouveau] " Hans de Goede
2022-08-18 18:42 ` [PATCH v3 26/31] platform/x86: samsung-laptop: Move acpi_backlight=[vendor|native] " Hans de Goede
2022-08-18 18:42   ` Hans de Goede
2022-08-18 18:42   ` [Nouveau] " Hans de Goede
2022-08-18 18:42   ` [Intel-gfx] " Hans de Goede
2022-08-18 18:42   ` Hans de Goede
2022-08-18 18:42 ` [PATCH v3 27/31] ACPI: video: Remove acpi_video_set_dmi_backlight_type() Hans de Goede
2022-08-18 18:42   ` Hans de Goede
2022-08-18 18:42   ` Hans de Goede
2022-08-18 18:42   ` [Intel-gfx] " Hans de Goede
2022-08-18 18:42   ` [Nouveau] " Hans de Goede
2022-08-18 18:42 ` [PATCH v3 28/31] ACPI: video: Drop "Samsung X360" acpi_backlight=native quirk Hans de Goede
2022-08-18 18:42   ` Hans de Goede
2022-08-18 18:42   ` Hans de Goede
2022-08-18 18:42   ` [Intel-gfx] " Hans de Goede
2022-08-18 18:42   ` [Nouveau] " Hans de Goede
2022-08-18 18:43 ` [PATCH v3 29/31] ACPI: video: Drop NL5x?U, PF4NU1F and PF5?U?? acpi_backlight=native quirks Hans de Goede
2022-08-18 18:43   ` Hans de Goede
2022-08-18 18:43   ` [Intel-gfx] " Hans de Goede
2022-08-18 18:43   ` Hans de Goede
2022-08-18 18:43   ` [Nouveau] " Hans de Goede
2022-08-18 18:43 ` [PATCH v3 30/31] ACPI: video: Fix indentation of video_detect_dmi_table[] entries Hans de Goede
2022-08-18 18:43   ` [Nouveau] " Hans de Goede
2022-08-18 18:43   ` Hans de Goede
2022-08-18 18:43   ` Hans de Goede
2022-08-18 18:43   ` [Intel-gfx] " Hans de Goede
2022-08-18 18:43 ` [PATCH v3 31/31] drm/todo: Add entry about dealing with brightness control on devices with > 1 panel Hans de Goede
2022-08-18 18:43   ` Hans de Goede
2022-08-18 18:43   ` Hans de Goede
2022-08-18 18:43   ` [Nouveau] " Hans de Goede
2022-08-18 18:43   ` [Intel-gfx] " Hans de Goede
2022-08-24 19:33 ` Patchwork [this message]
2022-08-24 19:33 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/kms: Stop registering multiple /sys/class/backlight devs for a single display Patchwork
2022-08-24 20:03 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2022-08-24 12:14 [PATCH v4 00/31] " Hans de Goede
2022-08-24 22:39 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2022-08-25 14:36 [Nouveau] [PATCH v5 00/31] " Hans de Goede
2022-08-25 16:09 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=166136960748.9870.8510428714292093940@emeril.freedesktop.org \
    --to=patchwork@emeril.freedesktop.org \
    --cc=hdegoede@redhat.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.