From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3920DC48BE4 for ; Wed, 24 Aug 2022 22:39:14 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 53EBF11327D; Wed, 24 Aug 2022 22:39:12 +0000 (UTC) Received: from emeril.freedesktop.org (emeril.freedesktop.org [131.252.210.167]) by gabe.freedesktop.org (Postfix) with ESMTP id 7D74311327D; Wed, 24 Aug 2022 22:39:06 +0000 (UTC) Received: from emeril.freedesktop.org (localhost [127.0.0.1]) by emeril.freedesktop.org (Postfix) with ESMTP id 72689A00CC; Wed, 24 Aug 2022 22:39:06 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Patchwork To: "Hans de Goede" Date: Wed, 24 Aug 2022 22:39:06 -0000 Message-ID: <166138074644.9871.190472164685870349@emeril.freedesktop.org> X-Patchwork-Hint: ignore References: <20220824121523.1291269-1-hdegoede@redhat.com> In-Reply-To: <20220824121523.1291269-1-hdegoede@redhat.com> Subject: [Intel-gfx] =?utf-8?b?4pyXIEZpLkNJLkNIRUNLUEFUQ0g6IHdhcm5pbmcg?= =?utf-8?q?for_drm/kms=3A_Stop_registering_multiple_/sys/class/backlight_d?= =?utf-8?q?evs_for_a_single_display?= X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: intel-gfx@lists.freedesktop.org Cc: intel-gfx@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" == Series Details == Series: drm/kms: Stop registering multiple /sys/class/backlight devs for a single display URL : https://patchwork.freedesktop.org/series/107674/ State : warning == Summary == Error: dim checkpatch failed ce615e6eacec ACPI: video: Add acpi_video_backlight_use_native() helper -:112: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files #112: FILE: include/acpi/video.h:59: +extern bool acpi_video_backlight_use_native(void); -:120: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations #120: FILE: include/acpi/video.h:81: } +static inline bool acpi_video_backlight_use_native(void) total: 0 errors, 0 warnings, 2 checks, 73 lines checked ffed9d27f636 drm/i915: Don't register backlight when another backlight should be used 3aa84d18ba99 drm/amdgpu: Don't register backlight when another backlight should be used (v3) 2278ca8ec027 drm/radeon: Don't register backlight when another backlight should be used (v3) e25ad3cdb207 drm/nouveau: Don't register backlight when another backlight should be used (v2) 8d7ad66ebdbb ACPI: video: Drop backlight_device_get_by_type() call from acpi_video_get_backlight_type() c2bbe7ee63a5 ACPI: video: Remove acpi_video_bus from list before tearing it down 775eaeb06986 ACPI: video: Simplify acpi_video_unregister_backlight() e89c85db9273 ACPI: video: Make backlight class device registration a separate step (v2) -:52: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #52: FILE: drivers/acpi/acpi_video.c:83: +MODULE_PARM_DESC(register_backlight_delay, + "Delay in seconds before doing fallback (non GPU driver triggered) " -:155: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files #155: FILE: include/acpi/video.h:56: +extern void acpi_video_register_backlight(void); total: 0 errors, 0 warnings, 2 checks, 112 lines checked c960810e498a ACPI: video: Remove code to unregister acpi_video backlight when a native backlight registers e2884327df97 drm/i915: Call acpi_video_register_backlight() (v2) a81b436830ad drm/nouveau: Register ACPI video backlight when nv_backlight registration fails (v2) 2d7a10857c1f drm/amdgpu: Register ACPI video backlight when skipping amdgpu backlight registration f2029e5472ab drm/radeon: Register ACPI video backlight when skipping radeon backlight registration a9f7e6508f32 platform/x86: nvidia-wmi-ec-backlight: Move fw interface definitions to a header (v2) Traceback (most recent call last): File "scripts/spdxcheck.py", line 6, in from ply import lex, yacc ModuleNotFoundError: No module named 'ply' -:119: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #119: new file mode 100644 total: 0 errors, 1 warnings, 0 checks, 166 lines checked aad1fbd9183c ACPI: video: Refactor acpi_video_get_backlight_type() a bit 8706b5420145 ACPI: video: Add Nvidia WMI EC brightness control detection (v3) 3bf23698fd25 ACPI: video: Add Apple GMUX brightness control detection 4f6d0cee0c7d platform/x86: nvidia-wmi-ec-backlight: Use acpi_video_get_backlight_type() 5658b0c7c1ad platform/x86: apple-gmux: Stop calling acpi/video.h functions cb40d8a60c01 platform/x86: toshiba_acpi: Stop using acpi_video_set_dmi_backlight_type() c6991a72234d platform/x86: acer-wmi: Move backlight DMI quirks to acpi/video_detect.c 2b7d1508eead platform/x86: asus-wmi: Drop DMI chassis-type check from backlight handling 2dbea215edc9 platform/x86: asus-wmi: Move acpi_backlight=vendor quirks to ACPI video_detect.c b416bb9cec80 platform/x86: asus-wmi: Move acpi_backlight=native quirks to ACPI video_detect.c a3cbb9b255dd platform/x86: samsung-laptop: Move acpi_backlight=[vendor|native] quirks to ACPI video_detect.c ecddbc9604aa ACPI: video: Remove acpi_video_set_dmi_backlight_type() 0b352f79ed22 ACPI: video: Drop "Samsung X360" acpi_backlight=native quirk a0618094884b ACPI: video: Drop NL5x?U, PF4NU1F and PF5?U?? acpi_backlight=native quirks 8f6f62285273 ACPI: video: Fix indentation of video_detect_dmi_table[] entries c38929892adb drm/todo: Add entry about dealing with brightness control on devices with > 1 panel -:11: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #11: https://lore.kernel.org/dri-devel/20220517152331.16217-1-hdegoede@redhat.com/ total: 0 errors, 1 warnings, 0 checks, 74 lines checked