From: David Howells <dhowells@redhat.com>
To: Tadeusz Struk <tadeusz.struk@intel.com>
Cc: dhowells@redhat.com, herbert@gondor.apana.org.au,
linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org,
linux-crypto@vger.kernel.org, zohar@linux.vnet.ibm.com
Subject: Re: [PATCH v5 1/3] crypto: KEYS: convert public key and digsig asym to the akcipher api
Date: Thu, 11 Feb 2016 09:51:26 +0000 [thread overview]
Message-ID: <16626.1455184286@warthog.procyon.org.uk> (raw)
In-Reply-To: <56BBC321.1000503@intel.com>
Tadeusz Struk <tadeusz.struk@intel.com> wrote:
> > Why didn't you put the RSA signature parsing - ie. where the OID and the other
> > bits are checked - into crypto/rsa.c?
> >
>
> Do you want to get rid of the crypto/asymmetric_keys/rsa.c completely?
> I wanted to make the conversion churn as small as possible.
> I can move it in a subsequent patch if you want.
I was thinking of getting rid of it completely, yes.
But I was wondering if you had some other motivation, such as keeping the
crypto layer purely the mathematical operation.
It's an interesting question where to draw the line, actually. The answer may
hinge on what things like the TPM do. I should ask the TPM folks.
David
next prev parent reply other threads:[~2016-02-11 9:51 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-02 18:08 [PATCH v5 0/3] crypto: KEYS: convert public key to akcipher api Tadeusz Struk
2016-02-02 18:08 ` [PATCH v5 1/3] crypto: KEYS: convert public key and digsig asym to the " Tadeusz Struk
2016-02-02 18:08 ` [PATCH v5 2/3] integrity: convert digsig to " Tadeusz Struk
2016-02-02 18:09 ` [PATCH v5 3/3] crypto: public_key: remove MPIs from public_key_signature struct Tadeusz Struk
2016-02-06 7:47 ` [PATCH v5 0/3] crypto: KEYS: convert public key to akcipher api Herbert Xu
2016-02-06 10:00 ` David Howells
2016-02-06 14:27 ` Herbert Xu
2016-02-07 0:43 ` David Howells
2016-02-07 1:22 ` Herbert Xu
2016-02-07 1:22 ` Herbert Xu
2016-02-08 13:58 ` Transferring applied X.509 patches from crypto/next to security/next David Howells
2016-02-08 21:25 ` Mimi Zohar
2016-02-09 1:01 ` James Morris
2016-02-09 8:40 ` Herbert Xu
2016-02-09 15:43 ` David Howells
2016-02-09 17:46 ` Herbert Xu
2016-02-09 16:49 ` [PATCH v5 0/3] crypto: KEYS: convert public key to akcipher api David Howells
2016-02-09 17:10 ` Tadeusz Struk
2016-02-10 14:17 ` [PATCH v5 1/3] crypto: KEYS: convert public key and digsig asym to the " David Howells
2016-02-10 23:09 ` Tadeusz Struk
2016-02-11 9:51 ` David Howells [this message]
2016-02-11 10:08 ` David Howells
2016-02-16 20:37 ` Tadeusz Struk
-- strict thread matches above, loose matches on Subject: below --
2015-12-24 3:13 [PATCH v5 0/3] crypto: KEYS: convert public key to " Tadeusz Struk
2015-12-24 3:13 ` [PATCH v5 1/3] crypto: KEYS: convert public key and digsig asym to the " Tadeusz Struk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16626.1455184286@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=tadeusz.struk@intel.com \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.