From: Thomas Monjalon <thomas@monjalon.net>
To: Yangchao Zhou <zhouyates@gmail.com>
Cc: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>,
stephen@networkplumber.org, sodey@rbbn.com,
Junxiao Shi <sunnylandh@gmail.com>
Subject: Re: [dpdk-dev] [PATCH v3] kni: fix possible kernel crash with va2pa
Date: Mon, 15 Jul 2019 22:50:21 +0200 [thread overview]
Message-ID: <1662932.6VjZo4KV3e@xps> (raw)
In-Reply-To: <c2f7ac07-920e-d04b-b367-657546ff53cb@intel.com>
11/07/2019 09:46, Ferruh Yigit:
> On 7/10/2019 9:09 PM, Ferruh Yigit wrote:
> > On 6/25/2019 4:04 PM, Yangchao Zhou wrote:
> >> va2pa depends on the physical address and virtual address offset of
> >> current mbuf. It may get the wrong physical address of next mbuf which
> >> allocated in another hugepage segment.
> >>
> >> In rte_mempool_populate_default(), trying to allocate whole block of
> >> contiguous memory could be failed. Then, it would reserve memory in
> >> several memzones that have different physical address and virtual address
> >> offsets. The rte_mempool_populate_default() is used by
> >> rte_pktmbuf_pool_create().
> >>
> >> Fixes: 8451269e6d7b ("kni: remove continuous memory restriction")
> >>
> >> Signed-off-by: Yangchao Zhou <zhouyates@gmail.com>
> >
> > Overall looks good to me, not from this patch but can you please check below
> > comment too.
> > Also there is a comment from Junxiao, lets clear it before the ack.
> >
>
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
The commit log does not really explained neither the use case
nor the solution. But as you acked it...
Applied, thanks
prev parent reply other threads:[~2019-07-15 20:50 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-28 7:30 [PATCH] kni: fix possible kernel crash with va2pa Yangchao Zhou
2019-03-06 17:31 ` Ferruh Yigit
2019-06-14 18:41 ` [dpdk-dev] " Dey, Souvik
2019-03-12 9:22 ` [PATCH v2] " Yangchao Zhou
2019-03-19 18:35 ` Ferruh Yigit
2019-03-22 20:49 ` Ferruh Yigit
2019-06-18 4:06 ` [dpdk-dev] " Dey, Souvik
2019-06-18 15:48 ` Stephen Hemminger
2019-06-25 15:04 ` [dpdk-dev] [PATCH v3] " Yangchao Zhou
2019-07-02 20:07 ` [dpdk-dev] [v3] " Junxiao Shi
2019-07-10 20:11 ` Ferruh Yigit
2019-07-10 20:40 ` yoursunny
2019-07-10 21:23 ` Ferruh Yigit
2019-07-10 23:52 ` yoursunny
2019-07-10 20:09 ` [dpdk-dev] [PATCH v3] " Ferruh Yigit
2019-07-11 7:46 ` Ferruh Yigit
2019-07-15 20:50 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1662932.6VjZo4KV3e@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=sodey@rbbn.com \
--cc=stephen@networkplumber.org \
--cc=sunnylandh@gmail.com \
--cc=zhouyates@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.