From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v5 4/5] vhost: eventfd_link: replace
	copy-pasted sys_close
Date: Wed, 17 Jun 2015 17:24:24 +0200
Message-ID: <1665929.SfCu3BinAE@xps13>
References: <1427994080-10163-1-git-send-email-pboldin@mirantis.com>
 <1429184910-30186-5-git-send-email-pboldin@mirantis.com>
 <C37D651A908B024F974696C65296B57B0F476567@SHSMSX101.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: "Xie, Huawei" <huawei.xie@intel.com>, Pavel Boldin <pboldin@mirantis.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wg0-f46.google.com (mail-wg0-f46.google.com [74.125.82.46])
 by dpdk.org (Postfix) with ESMTP id 5723CC498
 for <dev@dpdk.org>; Wed, 17 Jun 2015 17:25:25 +0200 (CEST)
Received: by wgbhy7 with SMTP id hy7so40057625wgb.2
 for <dev@dpdk.org>; Wed, 17 Jun 2015 08:25:25 -0700 (PDT)
In-Reply-To: <C37D651A908B024F974696C65296B57B0F476567@SHSMSX101.ccr.corp.intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2015-05-07 06:54, Xie, Huawei:
> On 4/16/2015 7:48 PM, Pavel Boldin wrote:
> > +	/* Closing the source_fd */
> > +	ret = sys_close(eventfd_copy.source_fd);
> Pavel:
> Here we close the fd and re-install a new file on this fd later. 
> sys_close does all cleanup.
> But, for instance, if we allocate new fd later, normally it will reuse
> the just freed fds by sys_close, is there issue here? 

Pavel, Huawei,
Could we come to a conclusion on this patch series please?