From: Rob Herring <robh@kernel.org>
To: Weilong Chen <chenweilong@huawei.com>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
xuwei5@huawei.com, yangyicong@hisilicon.com,
linux-i2c@vger.kernel.org, robh+dt@kernel.org, wsa@kernel.org
Subject: Re: [PATCH next v7 2/2] dt-bindings: i2c: add entry for hisilicon,i2c-ascend910
Date: Fri, 21 Oct 2022 08:07:51 -0500 [thread overview]
Message-ID: <166635752527.3428089.707277745439761591.robh@kernel.org> (raw)
In-Reply-To: <20221021035638.203929-2-chenweilong@huawei.com>
On Fri, 21 Oct 2022 11:56:38 +0800, Weilong Chen wrote:
> Add the new compatible for HiSilicon i2c.
>
> Signed-off-by: Weilong Chen <chenweilong@huawei.com>
> ---
> Change since v6:
> - Rename to hisilicon,i2c-ascend910.yaml
> - Change all IIC to I2C
> - Add maintainer name
> Link: https://lore.kernel.org/lkml/7520818b-de40-7f2a-1b03-b1dcd29a2023@huawei.com/T/#ma89d78cef45e7ac6f2c6251ed958e8658e5c1eb5
>
> .../bindings/i2c/hisilicon,i2c-ascend910.yaml | 70 +++++++++++++++++++
> MAINTAINERS | 1 +
> 2 files changed, 71 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/i2c/hisilicon,i2c-ascend910.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
./Documentation/devicetree/bindings/i2c/hisilicon,i2c-ascend910.yaml: $id: relative path/filename doesn't match actual path or filename
expected: http://devicetree.org/schemas/i2c/hisilicon,i2c-ascend910.yaml#
doc reference errors (make refcheckdocs):
MAINTAINERS: Documentation/devicetree/bindings/i2c/hisilicon,i2c-xxx.yaml
See https://patchwork.ozlabs.org/patch/
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
next prev parent reply other threads:[~2022-10-21 13:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-21 3:56 [PATCH next v7 1/2] i2c: hisi: Add initial device tree support Weilong Chen
2022-10-21 3:56 ` [PATCH next v7 2/2] dt-bindings: i2c: add entry for hisilicon,i2c-ascend910 Weilong Chen
2022-10-21 13:07 ` Rob Herring [this message]
2022-10-28 23:45 ` Krzysztof Kozlowski
2022-10-29 11:53 ` chenweilong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=166635752527.3428089.707277745439761591.robh@kernel.org \
--to=robh@kernel.org \
--cc=chenweilong@huawei.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=wsa@kernel.org \
--cc=xuwei5@huawei.com \
--cc=yangyicong@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.