From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v8 4/9] eal/bus: support for scanning of bus Date: Wed, 18 Jan 2017 00:37:14 +0100 Message-ID: <1666796.CLgGY7A5Bb@xps13> References: <1484647774-28984-1-git-send-email-shreyansh.jain@nxp.com> <1484660264-6531-1-git-send-email-shreyansh.jain@nxp.com> <1484660264-6531-5-git-send-email-shreyansh.jain@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Shreyansh Jain Return-path: Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42]) by dpdk.org (Postfix) with ESMTP id 26DB21094 for ; Wed, 18 Jan 2017 00:37:18 +0100 (CET) Received: by mail-wm0-f42.google.com with SMTP id r144so248014028wme.1 for ; Tue, 17 Jan 2017 15:37:18 -0800 (PST) In-Reply-To: <1484660264-6531-5-git-send-email-shreyansh.jain@nxp.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2017-01-17 19:07, Shreyansh Jain: > + * Generic bus object passed only as a helper for implementation to find > + * their respective registered bus object. Implementations can choose not > + * to use this variable. I think this comment is obsolete. > + * > + * @return > + * 0 for successful scan > + * !0 (<0) for unsuccessful scan with error value What do you mean with !0 (<0) ? I guess <0 is enough. > + */ > +typedef int (*rte_bus_scan_t)(void); >