From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDD18C433FE for ; Tue, 8 Nov 2022 18:00:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234527AbiKHSA0 (ORCPT ); Tue, 8 Nov 2022 13:00:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54338 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234355AbiKHSAX (ORCPT ); Tue, 8 Nov 2022 13:00:23 -0500 Received: from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com [IPv6:2607:f8b0:4864:20::1035]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7E1FC4298A for ; Tue, 8 Nov 2022 10:00:22 -0800 (PST) Received: by mail-pj1-x1035.google.com with SMTP id k5so14490653pjo.5 for ; Tue, 08 Nov 2022 10:00:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=srOBYBXjJ0LyLH8d270eQqxw6HUjH3xiNMOvx7A4gsY=; b=eENReWR7gzXXy1BAqG4WBmwK5FBnPlzeaSmQ7VyJQ6ab5Emvzcajwytz1OeD9nQw6B CljEKaLIYxRyNzkOqoDmiaCUOTNRyJred4Ed0aTA1PCqRPe9GF+4+LNex7NhRR4O13gO f3kGCD7CbeuIEkaBwAO3dkqMwPsAEJeZEEwk4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=srOBYBXjJ0LyLH8d270eQqxw6HUjH3xiNMOvx7A4gsY=; b=xfMjzvXD6al0aHQm0V4BlidBm2efCDWEtOvyYFSARYspIA4rgQbieQvzwYpCbvSC++ abMPM1lal3BpWi1H1ditult16SuqyvwmFgMmNxhSL29cUanL+w7MbNXosimQt6rofqwA coHTLi3300qEsqTCRyENNvDH8myZ9nw0xRbRvZP00pI2t8YM/bczJAJAVNy+qoH1B47/ VwobImsx1qQYj23lm6TRT7WfRqt3b9V8DEVa9CtmBL4/JS/Opg6xgcK7Vjj17+JDMEVg fN4R0ZU51WRJaxIESM7j/UholYXzYbWWxv0vnDg09VxCw8mMrCJYn/0zLgYLSsWonCxH ktXA== X-Gm-Message-State: ACrzQf1sPpqOfzCNKvkRZipFxj0+hQjyckkHx9XXJqMhTweVnyyHcvzg /LdZqWQI00LQPo12WcHg5Xs21g== X-Google-Smtp-Source: AMsMyM68d5KjRap1Sfn/jTCJoUToFAGz7kZJJpw1g1YLwciHjbTY76YfuFElI8B88ypVmLhlta1JOA== X-Received: by 2002:a17:902:e5cc:b0:187:2b02:969d with SMTP id u12-20020a170902e5cc00b001872b02969dmr44540139plf.9.1667930421991; Tue, 08 Nov 2022 10:00:21 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id h3-20020a63df43000000b0046fd180640asm6040904pgj.24.2022.11.08.10.00.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Nov 2022 10:00:21 -0800 (PST) From: Kees Cook To: nathan@kernel.org, Arnd Bergmann Cc: Kees Cook , linux-kernel@vger.kernel.org, stable@vger.kernel.org, linux-arch@vger.kernel.org, xiafukun@huawei.com, ardb@kernel.org, zhaowenhui8@huawei.com Subject: Re: [PATCH] vmlinux.lds.h: Fix placement of '.data..decrypted' section Date: Tue, 8 Nov 2022 10:00:17 -0800 Message-Id: <166793041556.1591113.6967612003001783225.b4-ty@chromium.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221108174934.3384275-1-nathan@kernel.org> References: <20221108174934.3384275-1-nathan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 8 Nov 2022 10:49:34 -0700, Nathan Chancellor wrote: > Commit d4c639990036 ("vmlinux.lds.h: Avoid orphan section with !SMP") > fixed an orphan section warning by adding the '.data..decrypted' section > to the linker script under the PERCPU_DECRYPTED_SECTION define but that > placement introduced a panic with !SMP, as the percpu sections are not > instantiated with that configuration so attempting to access variables > defined with DEFINE_PER_CPU_DECRYPTED() will result in a page fault. > > [...] Applied to for-linus/hardening, thanks! [1/1] vmlinux.lds.h: Fix placement of '.data..decrypted' section https://git.kernel.org/kees/c/000f8870a47b -- Kees Cook