From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B888EC43217 for ; Thu, 17 Nov 2022 15:08:50 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DB11F10E61D; Thu, 17 Nov 2022 15:08:47 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3B34310E61D for ; Thu, 17 Nov 2022 15:08:43 +0000 (UTC) Received: from pendragon.ideasonboard.com (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 98F8C929; Thu, 17 Nov 2022 16:08:41 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1668697721; bh=KDmMkOo4Xq7I/fLq82DmVwTZhsTmGJ8/nd1M+JpkZMQ=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=c1+44ai1zErA1wfRkm8rT9CNxu4WbWDyEWYQpBQg+fuyPi2R+LVBDA9k4pIgKjVUY qH1MRmAYZ4UbF9+N607NvKwj2GoKLHVRhaQgAF61iXRqEcWU6eKFP5unX7fhYNwFs0 x192SP/P4YCTsm4xR8ccAJN/vJ8kLyQ0mwwYZNfw= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20221117122547.809644-7-tomi.valkeinen@ideasonboard.com> References: <20221117122547.809644-1-tomi.valkeinen@ideasonboard.com> <20221117122547.809644-7-tomi.valkeinen@ideasonboard.com> Subject: Re: [PATCH v1 6/8] drm: rcar-du: Add r8a779g0 support From: Kieran Bingham To: Geert Uytterhoeven , Krzysztof Kozlowski , Laurent Pinchart , Magnus Damm , Rob Herring , Tomi Valkeinen , devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org Date: Thu, 17 Nov 2022 15:08:38 +0000 Message-ID: <166869771876.50677.1905794243575000038@Monstersaurus> User-Agent: alot/0.10 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , Jonas Karlman , Jernej Skrabec , Robert Foss , Andrzej Hajda , Tomi Valkeinen Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Quoting Tomi Valkeinen (2022-11-17 12:25:45) > From: Tomi Valkeinen >=20 > Add support for DU on r8a779g0, which is identical to DU on r8a779a0. >=20 > Signed-off-by: Tomi Valkeinen > --- > drivers/gpu/drm/rcar-du/rcar_du_drv.c | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) >=20 > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c b/drivers/gpu/drm/rcar= -du/rcar_du_drv.c > index d003e8d9e7a2..b1761d4ec4e5 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c > @@ -524,6 +524,27 @@ static const struct rcar_du_device_info rcar_du_r8a7= 79a0_info =3D { > .dsi_clk_mask =3D BIT(1) | BIT(0), > }; > =20 > +static const struct rcar_du_device_info rcar_du_r8a779g0_info =3D { > + .gen =3D 3, Given that this is the V4H ... I wonder if this should be bumped already. I guess that has knock on effects through the driver though... Aside from that, Which may need more work to handle correctly: Reviewed-by: Kieran Bingham > + .features =3D RCAR_DU_FEATURE_CRTC_IRQ > + | RCAR_DU_FEATURE_VSP1_SOURCE > + | RCAR_DU_FEATURE_NO_BLENDING, > + .channels_mask =3D BIT(1) | BIT(0), > + .routes =3D { > + /* R8A779G0 has two MIPI DSI outputs. */ > + [RCAR_DU_OUTPUT_DSI0] =3D { > + .possible_crtcs =3D BIT(0), > + .port =3D 0, > + }, > + [RCAR_DU_OUTPUT_DSI1] =3D { > + .possible_crtcs =3D BIT(1), > + .port =3D 1, > + }, > + }, > + .num_rpf =3D 5, > + .dsi_clk_mask =3D BIT(1) | BIT(0), > +}; > + > static const struct of_device_id rcar_du_of_table[] =3D { > { .compatible =3D "renesas,du-r8a7742", .data =3D &rcar_du_r8a779= 0_info }, > { .compatible =3D "renesas,du-r8a7743", .data =3D &rzg1_du_r8a774= 3_info }, > @@ -549,6 +570,7 @@ static const struct of_device_id rcar_du_of_table[] = =3D { > { .compatible =3D "renesas,du-r8a77990", .data =3D &rcar_du_r8a77= 99x_info }, > { .compatible =3D "renesas,du-r8a77995", .data =3D &rcar_du_r8a77= 99x_info }, > { .compatible =3D "renesas,du-r8a779a0", .data =3D &rcar_du_r8a77= 9a0_info }, > + { .compatible =3D "renesas,du-r8a779g0", .data =3D &rcar_du_r8a77= 9g0_info }, > { } > }; > =20 > --=20 > 2.34.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 472EAC433FE for ; Thu, 17 Nov 2022 15:12:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240605AbiKQPMZ (ORCPT ); Thu, 17 Nov 2022 10:12:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55030 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240607AbiKQPKt (ORCPT ); Thu, 17 Nov 2022 10:10:49 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C218864546; Thu, 17 Nov 2022 07:08:43 -0800 (PST) Received: from pendragon.ideasonboard.com (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 98F8C929; Thu, 17 Nov 2022 16:08:41 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1668697721; bh=KDmMkOo4Xq7I/fLq82DmVwTZhsTmGJ8/nd1M+JpkZMQ=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=c1+44ai1zErA1wfRkm8rT9CNxu4WbWDyEWYQpBQg+fuyPi2R+LVBDA9k4pIgKjVUY qH1MRmAYZ4UbF9+N607NvKwj2GoKLHVRhaQgAF61iXRqEcWU6eKFP5unX7fhYNwFs0 x192SP/P4YCTsm4xR8ccAJN/vJ8kLyQ0mwwYZNfw= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20221117122547.809644-7-tomi.valkeinen@ideasonboard.com> References: <20221117122547.809644-1-tomi.valkeinen@ideasonboard.com> <20221117122547.809644-7-tomi.valkeinen@ideasonboard.com> Subject: Re: [PATCH v1 6/8] drm: rcar-du: Add r8a779g0 support From: Kieran Bingham Cc: Andrzej Hajda , Neil Armstrong , Robert Foss , Jonas Karlman , Jernej Skrabec , Tomi Valkeinen To: Geert Uytterhoeven , Krzysztof Kozlowski , Laurent Pinchart , Magnus Damm , Rob Herring , Tomi Valkeinen , devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org Date: Thu, 17 Nov 2022 15:08:38 +0000 Message-ID: <166869771876.50677.1905794243575000038@Monstersaurus> User-Agent: alot/0.10 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Tomi Valkeinen (2022-11-17 12:25:45) > From: Tomi Valkeinen >=20 > Add support for DU on r8a779g0, which is identical to DU on r8a779a0. >=20 > Signed-off-by: Tomi Valkeinen > --- > drivers/gpu/drm/rcar-du/rcar_du_drv.c | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) >=20 > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c b/drivers/gpu/drm/rcar= -du/rcar_du_drv.c > index d003e8d9e7a2..b1761d4ec4e5 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c > @@ -524,6 +524,27 @@ static const struct rcar_du_device_info rcar_du_r8a7= 79a0_info =3D { > .dsi_clk_mask =3D BIT(1) | BIT(0), > }; > =20 > +static const struct rcar_du_device_info rcar_du_r8a779g0_info =3D { > + .gen =3D 3, Given that this is the V4H ... I wonder if this should be bumped already. I guess that has knock on effects through the driver though... Aside from that, Which may need more work to handle correctly: Reviewed-by: Kieran Bingham > + .features =3D RCAR_DU_FEATURE_CRTC_IRQ > + | RCAR_DU_FEATURE_VSP1_SOURCE > + | RCAR_DU_FEATURE_NO_BLENDING, > + .channels_mask =3D BIT(1) | BIT(0), > + .routes =3D { > + /* R8A779G0 has two MIPI DSI outputs. */ > + [RCAR_DU_OUTPUT_DSI0] =3D { > + .possible_crtcs =3D BIT(0), > + .port =3D 0, > + }, > + [RCAR_DU_OUTPUT_DSI1] =3D { > + .possible_crtcs =3D BIT(1), > + .port =3D 1, > + }, > + }, > + .num_rpf =3D 5, > + .dsi_clk_mask =3D BIT(1) | BIT(0), > +}; > + > static const struct of_device_id rcar_du_of_table[] =3D { > { .compatible =3D "renesas,du-r8a7742", .data =3D &rcar_du_r8a779= 0_info }, > { .compatible =3D "renesas,du-r8a7743", .data =3D &rzg1_du_r8a774= 3_info }, > @@ -549,6 +570,7 @@ static const struct of_device_id rcar_du_of_table[] = =3D { > { .compatible =3D "renesas,du-r8a77990", .data =3D &rcar_du_r8a77= 99x_info }, > { .compatible =3D "renesas,du-r8a77995", .data =3D &rcar_du_r8a77= 99x_info }, > { .compatible =3D "renesas,du-r8a779a0", .data =3D &rcar_du_r8a77= 9a0_info }, > + { .compatible =3D "renesas,du-r8a779g0", .data =3D &rcar_du_r8a77= 9g0_info }, > { } > }; > =20 > --=20 > 2.34.1 >