From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A70BAC433FE for ; Thu, 17 Nov 2022 15:56:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239894AbiKQP4u (ORCPT ); Thu, 17 Nov 2022 10:56:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33746 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239779AbiKQP4i (ORCPT ); Thu, 17 Nov 2022 10:56:38 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 66EAC769D9; Thu, 17 Nov 2022 07:56:37 -0800 (PST) Received: from pendragon.ideasonboard.com (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 6DCE1929; Thu, 17 Nov 2022 16:56:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1668700595; bh=KPO+OjnefHJI5WTgv+SZ55f7fYrJUjWGP+l48eabV7k=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=nptFuSPPTAVQ46xpdmJAI6lO2pltlzZeXouyRe/ZehR1pNs+CNGVcO4NHXQMMQ5pM gk8i7zpF0GjJP3QoY3zf0yq4RUJxlz+C84bJnqi7n3LrXoXXpd1JXUcwTXeh2bms03 AgDFaZj1M3t7C01W+g9osa9aOiya5/HbQzXKdvT8= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <8d848493-24a8-4ffb-239e-9e7baa232a42@ideasonboard.com> References: <20221117122547.809644-1-tomi.valkeinen@ideasonboard.com> <20221117122547.809644-8-tomi.valkeinen@ideasonboard.com> <166869996543.50677.17182739414507530884@Monstersaurus> <8d848493-24a8-4ffb-239e-9e7baa232a42@ideasonboard.com> Subject: Re: [PATCH v1 7/8] drm: rcar-du: dsi: Add r8A779g0 support From: Kieran Bingham Cc: Andrzej Hajda , Neil Armstrong , Robert Foss , Jonas Karlman , Jernej Skrabec , Tomi Valkeinen To: Geert Uytterhoeven , Krzysztof Kozlowski , Laurent Pinchart , Magnus Damm , Rob Herring , Tomi Valkeinen , devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org Date: Thu, 17 Nov 2022 15:56:32 +0000 Message-ID: <166870059260.50677.7640208301376893584@Monstersaurus> User-Agent: alot/0.10 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Tomi Valkeinen (2022-11-17 15:49:36) > On 17/11/2022 17:46, Kieran Bingham wrote: > >> + if (ret) > >> + return ret; > >> + > >> + if (setup_info->hsfreq <=3D MHZ(1000)) > >> + ret =3D WRITE_PHTW(0x01020100, 0x01910170, 0x01020171, > >> + 0x01110172); > > The <=3D1Gbps reads: > >=20 > > <=3D1Gbps > >=20 > > Set PHTW=3DH=E2=80=9901020100 > > Set PHTW=3DH=E2=80=9901010172 > > Set PHTW=3DH=E2=80=9901570170 > > Set PHTW=3DH=E2=80=9901060171 > > Set PHTW=3DH=E2=80=9901110172 > >=20 > > Is it clear why theres a difference here? >=20 > What doc is that? Mine (R19UH0172EJ0054 Rev.0.54) says: Hrm ... mine is R19UH0172EJ0051 ... So I guess I'm on an outdated datasheet. Which leaves me pondering if I should just wave my hand over my eyes and add a tag ... (Or see if I can dig up the later datasheet) ;-) -- Kieran >=20 > Set PHTW=3DH=E2=80=9901020100 > Set PHTW=3DH=E2=80=9901910170 > Set PHTW=3DH=E2=80=9901020171 > Set PHTW=3DH=E2=80=9901110172 >=20 > Tomi > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F1C0BC433FE for ; Thu, 17 Nov 2022 15:56:41 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D576B10E642; Thu, 17 Nov 2022 15:56:40 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id EE3D910E642 for ; Thu, 17 Nov 2022 15:56:36 +0000 (UTC) Received: from pendragon.ideasonboard.com (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 6DCE1929; Thu, 17 Nov 2022 16:56:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1668700595; bh=KPO+OjnefHJI5WTgv+SZ55f7fYrJUjWGP+l48eabV7k=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=nptFuSPPTAVQ46xpdmJAI6lO2pltlzZeXouyRe/ZehR1pNs+CNGVcO4NHXQMMQ5pM gk8i7zpF0GjJP3QoY3zf0yq4RUJxlz+C84bJnqi7n3LrXoXXpd1JXUcwTXeh2bms03 AgDFaZj1M3t7C01W+g9osa9aOiya5/HbQzXKdvT8= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <8d848493-24a8-4ffb-239e-9e7baa232a42@ideasonboard.com> References: <20221117122547.809644-1-tomi.valkeinen@ideasonboard.com> <20221117122547.809644-8-tomi.valkeinen@ideasonboard.com> <166869996543.50677.17182739414507530884@Monstersaurus> <8d848493-24a8-4ffb-239e-9e7baa232a42@ideasonboard.com> Subject: Re: [PATCH v1 7/8] drm: rcar-du: dsi: Add r8A779g0 support From: Kieran Bingham To: Geert Uytterhoeven , Krzysztof Kozlowski , Laurent Pinchart , Magnus Damm , Rob Herring , Tomi Valkeinen , devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org Date: Thu, 17 Nov 2022 15:56:32 +0000 Message-ID: <166870059260.50677.7640208301376893584@Monstersaurus> User-Agent: alot/0.10 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , Jonas Karlman , Jernej Skrabec , Robert Foss , Andrzej Hajda , Tomi Valkeinen Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Quoting Tomi Valkeinen (2022-11-17 15:49:36) > On 17/11/2022 17:46, Kieran Bingham wrote: > >> + if (ret) > >> + return ret; > >> + > >> + if (setup_info->hsfreq <=3D MHZ(1000)) > >> + ret =3D WRITE_PHTW(0x01020100, 0x01910170, 0x01020171, > >> + 0x01110172); > > The <=3D1Gbps reads: > >=20 > > <=3D1Gbps > >=20 > > Set PHTW=3DH=E2=80=9901020100 > > Set PHTW=3DH=E2=80=9901010172 > > Set PHTW=3DH=E2=80=9901570170 > > Set PHTW=3DH=E2=80=9901060171 > > Set PHTW=3DH=E2=80=9901110172 > >=20 > > Is it clear why theres a difference here? >=20 > What doc is that? Mine (R19UH0172EJ0054 Rev.0.54) says: Hrm ... mine is R19UH0172EJ0051 ... So I guess I'm on an outdated datasheet. Which leaves me pondering if I should just wave my hand over my eyes and add a tag ... (Or see if I can dig up the later datasheet) ;-) -- Kieran >=20 > Set PHTW=3DH=E2=80=9901020100 > Set PHTW=3DH=E2=80=9901910170 > Set PHTW=3DH=E2=80=9901020171 > Set PHTW=3DH=E2=80=9901110172 >=20 > Tomi >