From: Thomas Monjalon <thomas@monjalon.net>
To: "Stanisław Kardach" <kda@semihalf.com>
Cc: dev@dpdk.org, Michal Krawczyk <mk@semihalf.com>,
erik.g.carrillo@intel.com
Subject: Re: [dpdk-dev] [PATCH 2/2] test: proceed if timer subsystem was initialized
Date: Tue, 06 Apr 2021 17:40:38 +0200 [thread overview]
Message-ID: <1669035.bN16AnX8SA@thomas> (raw)
In-Reply-To: <CALVGJWLZJ=ygHK0-Q5Xd3h6wNHmuBvDxFGaSUD=HUY25R=NfyA@mail.gmail.com>
06/04/2021 17:31, Stanisław Kardach:
> Hi Thomas,
>
> Thanks for the review.
>
> On Tue, Apr 6, 2021 at 5:24 PM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> > 26/03/2021 11:47, Michal Krawczyk:
> > > From: Stanislaw Kardach <kda@semihalf.com>
> > >
> > > rte_timer_subsystem_init() may return -EALREADY if the timer subsystem
> > > was already initialized. This can happen i.e. in PMD code (see
> > > eth_ena_dev_init). This is not an error, rather a notification as the
> > > initialization function simply returns without any action taken.
> >
> > Missing these lines:
> >
> > Fixes: 50247fe03fe0 ("test/timer: exercise new APIs in secondary process")
> > Cc: stable@dpdk.org
>
> Will add in V2.
>
> >
> >
> > > Signed-off-by: Stanislaw Kardach <kda@semihalf.com>
> > > Reviewed-by: Michal Krawczyk <mk@semihalf.com>
> > > ---
> > > app/test/test.c | 11 ++++++-----
> > > 1 file changed, 6 insertions(+), 5 deletions(-)
> > >
> > > diff --git a/app/test/test.c b/app/test/test.c
> > > index 624dd48042..864523ed61 100644
> > > --- a/app/test/test.c
> > > +++ b/app/test/test.c
> > > @@ -134,8 +134,13 @@ main(int argc, char **argv)
> > > goto out;
> > > }
> > >
> > > + argv += ret;
> > > +
> > > + prgname = argv[0];
> > > +
> > > #ifdef RTE_LIB_TIMER
> > > - if (rte_timer_subsystem_init() < 0) {
> > > + ret = rte_timer_subsystem_init();
> > > + if (ret < 0 && ret != -EALREADY) {
> > > ret = -1;
> > > goto out;
> > > }
> > > @@ -146,10 +151,6 @@ main(int argc, char **argv)
> > > goto out;
> > > }
> > >
> > > - argv += ret;
> > > -
> > > - prgname = argv[0];
> > > -
> >
> > How this change for argv/prgname is related to the fix?
> >
> This patch saves the return value of rte_timer_subsystem_init() in ret
> which overwrites the previous ret that held the number of arguments
> consumed by rte_eal_init(). Similarly because rte_eal_init() reshuffles
> argv, the prgname is effectively at argv[ret]. So I need to move this logic
> before the timer subsystem check.
OK I didn't see the consequence on ret variable.
In this case I can merge with the added lines.
No need of v2.
next prev parent reply other threads:[~2021-04-06 15:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-26 10:47 [dpdk-dev] [PATCH 0/2] Fix unit tests execution for ENA PMD Michal Krawczyk
2021-03-26 10:47 ` [dpdk-dev] [PATCH 1/2] timer: clarify subsystem_init return value Michal Krawczyk
2021-03-29 20:50 ` Carrillo, Erik G
2021-03-26 10:47 ` [dpdk-dev] [PATCH 2/2] test: proceed if timer subsystem was initialized Michal Krawczyk
2021-04-06 15:24 ` Thomas Monjalon
2021-04-06 15:31 ` Stanisław Kardach
2021-04-06 15:40 ` Thomas Monjalon [this message]
2021-04-08 21:15 ` [dpdk-dev] [PATCH 0/2] Fix unit tests execution for ENA PMD Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1669035.bN16AnX8SA@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=erik.g.carrillo@intel.com \
--cc=kda@semihalf.com \
--cc=mk@semihalf.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.