From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f44.google.com (mail-io1-f44.google.com [209.85.166.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BDF9F2F26 for ; Thu, 24 Nov 2022 17:39:35 +0000 (UTC) Received: by mail-io1-f44.google.com with SMTP id g26so949373iob.11 for ; Thu, 24 Nov 2022 09:39:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=date:subject:message-id:references:in-reply-to:cc:to:from :mime-version:content-transfer-encoding:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=IoktBuMa4PVRuI5/Wo0/xDwZpz9ewe3rcWXZGPg/Ou4=; b=U+BMO7UbqopZXXYHznaXCx1XmwgqRIlYyUkZ5xd2931mbtxYoyeeIPmQHamqHT6Gmo BDCEx5wLNYCaS8JbSpohz29VpfeVSKMilXpn2H1AeScHEbkstithHIMepDEqm6jODBhL 2dCX5AAwTKW4ypf2aEc+1zhoY2i7prfNJpns/T3tmweF8v1YCxNK10PmqbNilGAPXmAj FrY70jZ8CvW47o2vJ4pwOXeQlgdzsFKnJZfRclkK9FrWMBem7urRxv6o3h0ZGtAjApkF TTnx3hzWIgWXd6xvtZyYSmko7q44XMvF2nxiQLlHGwSU7I07l1te5SBIGzzpK1w0/xq2 2JYg== X-Gm-Message-State: ANoB5pn5UvJhczSry6mDUjq5SKLrxLMkAwrW0xgBlE16+OCBl2UsQtfJ ax6NR1r2VnWD6Xtz0Wk1GA== X-Google-Smtp-Source: AA0mqf6u4sFD+aGrlSoj75GanwIIheHbWEuFFhr8HAzTVS6PxR/piCFthw25bzyO3jj4ay7YIeMfaw== X-Received: by 2002:a02:6309:0:b0:375:4dbf:6ca4 with SMTP id j9-20020a026309000000b003754dbf6ca4mr6392316jac.315.1669311574693; Thu, 24 Nov 2022 09:39:34 -0800 (PST) Received: from robh_at_kernel.org ([64.188.179.252]) by smtp.gmail.com with ESMTPSA id g6-20020a02a086000000b003754033c6aesm593628jah.155.2022.11.24.09.39.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Nov 2022 09:39:34 -0800 (PST) Received: (nullmailer pid 4182342 invoked by uid 1000); Thu, 24 Nov 2022 17:39:27 -0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk X-Mailing-List: chrome-platform@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Rob Herring To: Pin-yen Lin Cc: Prashant Malani , Greg Kroah-Hartman , Heikki Krogerus , devicetree@vger.kernel.org, ", Andy Shevchenko" , dri-devel@lists.freedesktop.org, Laurent Pinchart , linux-acpi@vger.kernel.org, AngeloGioacchino Del Regno , Rob Herring , chrome-platform@lists.linux.dev, Robert Foss , Allen Chen , Hsin-Yi Wang , =?UTF-8?B?TsOtY29sYXMgRiAuIFIgLiBBIC4gUHJhZG8=?= , Neil Armstrong , Daniel Vetter , Sakari Ailus , Guenter Roeck , Stephen Boyd , Andrzej Hajda , Daniel Scally , Marek Vasut , Benson Leung , "Rafael J . Wysocki" , Thomas Zimmermann , David Airlie , linux-kernel@vger.kernel.org, Jonas Karlman , Lyude Paul , Krzysztof Kozlowski , Javier Martinez Canillas , Xin Ji , Jernej Skrabec In-Reply-To: <20221124102056.393220-4-treapking@chromium.org> References: <20221124102056.393220-1-treapking@chromium.org> <20221124102056.393220-4-treapking@chromium.org> Message-Id: <166930150025.3946612.5757271936642172776.robh@kernel.org> Subject: Re: [PATCH v6 3/7] dt-bindings: drm/bridge: anx7625: Add mode-switch support Date: Thu, 24 Nov 2022 11:39:27 -0600 On Thu, 24 Nov 2022 18:20:52 +0800, Pin-yen Lin wrote: > Analogix 7625 can be used in systems to switch the DP traffic between > two downstreams, which can be USB Type-C DisplayPort alternate mode > lane or regular DisplayPort output ports. > > Update the binding to accommodate this usage by introducing a > data-lanes and a mode-switch property on endpoints. > > Also include the link to the product brief in the bindings. > > Signed-off-by: Pin-yen Lin > > --- > > Changes in v6: > - Remove switches node and use endpoints and data-lanes property to > describe the connections. > > .../display/bridge/analogix,anx7625.yaml | 73 ++++++++++++++++++- > 1 file changed, 71 insertions(+), 2 deletions(-) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: ./Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml:218:1: [error] syntax error: found character '\t' that cannot start any token (syntax) dtschema/dtc warnings/errors: make[1]: *** Deleting file 'Documentation/devicetree/bindings/display/bridge/analogix,anx7625.example.dts' Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml:218:1: found character '\t' that cannot start any token make[1]: *** [Documentation/devicetree/bindings/Makefile:26: Documentation/devicetree/bindings/display/bridge/analogix,anx7625.example.dts] Error 1 make[1]: *** Waiting for unfinished jobs.... ./Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml:218:1: found character '\t' that cannot start any token /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml: ignoring, error parsing file make: *** [Makefile:1492: dt_binding_check] Error 2 doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20221124102056.393220-4-treapking@chromium.org This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7E598C433FE for ; Thu, 24 Nov 2022 17:39:47 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CEEA010E1B3; Thu, 24 Nov 2022 17:39:45 +0000 (UTC) Received: from mail-io1-f44.google.com (mail-io1-f44.google.com [209.85.166.44]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8984810E1B3 for ; Thu, 24 Nov 2022 17:39:35 +0000 (UTC) Received: by mail-io1-f44.google.com with SMTP id 11so1641560iou.0 for ; Thu, 24 Nov 2022 09:39:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=date:subject:message-id:references:in-reply-to:cc:to:from :mime-version:content-transfer-encoding:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=IoktBuMa4PVRuI5/Wo0/xDwZpz9ewe3rcWXZGPg/Ou4=; b=MkPzcUj7ux74A1u4b1SCPIE+Jt/9/XtmbxylHYAa73VKDoYCmkiJT/Hzi+pPACB6Hy eUKC+a/2dXUMO8wPepBHM4kq+jSH74+XFyk2v9njfzSrMTjzU1V0LLPc9eYsesrzwZuq r2/GmdoY+5PQcXs2pDM5nF4WyGLkvdXvj+X2vYG6HvObGJ71yu7iEp9IkXgAkcCUyopi ZY4BHCcK8rnUm9+wAmSyhYnjfCvZcV3sDE4s8uGM8xm93gCjVUdWB3JKgJ+y3ttBPXWo yl1pPj7SDsTIQC6GN4pTerBKh/RPCxQ2W2qw/P6cKEq0gpahR8uqq9x9S96KgDAFto/L o+/g== X-Gm-Message-State: ANoB5pnKCuiNH+uw5gzkvSXszFa5sLjP2iVVvB9v52lwmQGP9xLOZLla JQMdCMyQ9EoGjKP/msmVOg== X-Google-Smtp-Source: AA0mqf6u4sFD+aGrlSoj75GanwIIheHbWEuFFhr8HAzTVS6PxR/piCFthw25bzyO3jj4ay7YIeMfaw== X-Received: by 2002:a02:6309:0:b0:375:4dbf:6ca4 with SMTP id j9-20020a026309000000b003754dbf6ca4mr6392316jac.315.1669311574693; Thu, 24 Nov 2022 09:39:34 -0800 (PST) Received: from robh_at_kernel.org ([64.188.179.252]) by smtp.gmail.com with ESMTPSA id g6-20020a02a086000000b003754033c6aesm593628jah.155.2022.11.24.09.39.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Nov 2022 09:39:34 -0800 (PST) Received: (nullmailer pid 4182342 invoked by uid 1000); Thu, 24 Nov 2022 17:39:27 -0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 From: Rob Herring To: Pin-yen Lin In-Reply-To: <20221124102056.393220-4-treapking@chromium.org> References: <20221124102056.393220-1-treapking@chromium.org> <20221124102056.393220-4-treapking@chromium.org> Message-Id: <166930150025.3946612.5757271936642172776.robh@kernel.org> Subject: Re: [PATCH v6 3/7] dt-bindings: drm/bridge: anx7625: Add mode-switch support Date: Thu, 24 Nov 2022 11:39:27 -0600 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Heikki Krogerus , Krzysztof Kozlowski , "Rafael J . Wysocki" , dri-devel@lists.freedesktop.org, Laurent Pinchart , Andrzej Hajda , Guenter Roeck , Marek Vasut , chrome-platform@lists.linux.dev, Javier Martinez Canillas , Jernej Skrabec , linux-acpi@vger.kernel.org, devicetree@vger.kernel.org, Sakari Ailus , =?UTF-8?B?TsOtY29sYXMgRiAuIFIgLiBBIC4gUHJhZG8=?= , Jonas Karlman , Allen Chen , Stephen Boyd , Rob Herring , Hsin-Yi Wang , ", Andy Shevchenko" , Xin Ji , AngeloGioacchino Del Regno , Neil Armstrong , Thomas Zimmermann , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Robert Foss , Daniel Scally , Prashant Malani Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, 24 Nov 2022 18:20:52 +0800, Pin-yen Lin wrote: > Analogix 7625 can be used in systems to switch the DP traffic between > two downstreams, which can be USB Type-C DisplayPort alternate mode > lane or regular DisplayPort output ports. > > Update the binding to accommodate this usage by introducing a > data-lanes and a mode-switch property on endpoints. > > Also include the link to the product brief in the bindings. > > Signed-off-by: Pin-yen Lin > > --- > > Changes in v6: > - Remove switches node and use endpoints and data-lanes property to > describe the connections. > > .../display/bridge/analogix,anx7625.yaml | 73 ++++++++++++++++++- > 1 file changed, 71 insertions(+), 2 deletions(-) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: ./Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml:218:1: [error] syntax error: found character '\t' that cannot start any token (syntax) dtschema/dtc warnings/errors: make[1]: *** Deleting file 'Documentation/devicetree/bindings/display/bridge/analogix,anx7625.example.dts' Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml:218:1: found character '\t' that cannot start any token make[1]: *** [Documentation/devicetree/bindings/Makefile:26: Documentation/devicetree/bindings/display/bridge/analogix,anx7625.example.dts] Error 1 make[1]: *** Waiting for unfinished jobs.... ./Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml:218:1: found character '\t' that cannot start any token /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml: ignoring, error parsing file make: *** [Makefile:1492: dt_binding_check] Error 2 doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20221124102056.393220-4-treapking@chromium.org This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command.