From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0AA11C43217 for ; Thu, 1 Dec 2022 15:36:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231799AbiLAPgK (ORCPT ); Thu, 1 Dec 2022 10:36:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43934 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231945AbiLAPgA (ORCPT ); Thu, 1 Dec 2022 10:36:00 -0500 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2044.outbound.protection.outlook.com [40.107.92.44]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CEF68113D; Thu, 1 Dec 2022 07:35:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kVEYi2ojpYDpcnQ4jeC8zBmYMxIncDMmoleP4+FnWsIlu6cfIVHzBJrIU6Gh0I3JG1oNgm3xxeLFqTlcV1v3aahe1o3hV50ri5sdMYCR9wDKABdL3cKXts2/1YbvVp72GH+N2BsT27oARJcifKwDwELogPGZiv0bbmsWRd4uM8JDMdlbug+wpNX+/PKc0TojVosmxGTO/oWBNK3np+o+mLgMbVRuTeanLEBU97syS4X5JXxgk4NxHP8gTOboblX+o9kpD2RIG4OdqriV+Ir9itDz6wPNC9QZJy8DR/o/90ambforFf91iDVRrhfWpnpaVzSajS1l3Unqvm/WyrFdkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KxUQvFyJ9gYG3TLNi6xY905cZDc4s8wgJu3+LzyMdnI=; b=adcaMcB4TEBsO087Kw5LfsMqlASBUO4E2Jy8/dHqCdEDxIatlByvZPu6GKcBlulgijYYss+xbuadUste45nj6Qfxy/NElvqxKXtTjPRW294OM9GRwdL9yzY7odbZNkQncuFIw1o4Z2WOk92h7lvdCFwxkkrpqbB8o8nnVgJFlIMBQ7+Ig9SeL7JMrM3erE2X0BxSNk6l+uInYP83dE4mpm62cPE+VBsZoe62dYzlDgEmGb29nsNVjLeG1hcaqEHJR9yCtSr/MUIJiKLzO8VZlgKdNHQKYf/beWWQ+dZej9Di92O2m6+mHcwwO1aFLpHJP4/4DGMfz7SWRQPQBgUYfA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linutronix.de smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KxUQvFyJ9gYG3TLNi6xY905cZDc4s8wgJu3+LzyMdnI=; b=WRrXnxcURUec8g2drh5qgIB+RP6+J4JXS//kz8YWkbTUQ76I4zK5GRxFzkY2YdVHWz9a11P2WUp3/u+I+oo+h4XPL4fcB5Mr0AAA5QOmHKSzcy+skNexw3+AU4wOAPNj+QzVtxs0PNIMYLLu64HJ86CuazmXisA4OwFhmXvGaZ0= Received: from MW4PR03CA0169.namprd03.prod.outlook.com (2603:10b6:303:8d::24) by BN9PR12MB5114.namprd12.prod.outlook.com (2603:10b6:408:137::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23; Thu, 1 Dec 2022 15:35:56 +0000 Received: from CO1NAM11FT077.eop-nam11.prod.protection.outlook.com (2603:10b6:303:8d:cafe::c3) by MW4PR03CA0169.outlook.office365.com (2603:10b6:303:8d::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23 via Frontend Transport; Thu, 1 Dec 2022 15:35:56 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT077.mail.protection.outlook.com (10.13.175.55) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5834.8 via Frontend Transport; Thu, 1 Dec 2022 15:35:56 +0000 Received: from [127.0.1.1] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 1 Dec 2022 09:35:53 -0600 Subject: [PATCH v9 00/13] Support for AMD QoS new features From: Babu Moger To: , , , , CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Date: Thu, 1 Dec 2022 09:35:53 -0600 Message-ID: <166990882621.17806.16780480657453071426.stgit@bmoger-ubuntu> User-Agent: StGit/1.1.dev103+g5369f4c MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT077:EE_|BN9PR12MB5114:EE_ X-MS-Office365-Filtering-Correlation-Id: cf948a29-c2f3-438f-e7a0-08dad3b1bd29 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7ozzluzx0qiarnnXZNx42C3ULch8x5ZyJMR08EWyvUz2OrMbl61cQHUv8eq0VBRfQHGGcrKnuUyr22hej8/zW5eq5xiLXt5ZigyuXaUqgxh4vTEXTi8oPiZbZrB0sYtkjmDxGwfpzd1UAeRjQsoq81pJKh6WxnYknWanlQMw7BOBwuRAPv/rYqA0/0J9STEs1SPpqLK+Yx4fz7wb6HDqZlZDAXzsbR2ERa5gHmY/bVYzY3PJAWZFQtOnSPcjb6bbYZUnnfhYQk2mQb46ECyjw5/XZF/Y2moDnTqOQ5aEjvdsA5p3baRUpTFJ3kQHPDJhU4WvsTy0DHR4ScITBi8/UsWIczwA0QQHQ6Fly4dknAAL5SCTUrK7+mmbtijCLh6fKM+yKyONvRV90ZMq63ZiX9hwEp50Hd1pJpX55cc7lSv63EZEB2X73bKEqt0yXAodAXeu8c/Pgc8EUOnWSUGDKOJexJfRulOeT/DDKc9UkBAnF0DgMdXPsTdYRUfhDwr2DdxM+FfaNHMYw3d8wBy9gzTsSloKXG2f9Ll9KAQNLrvg/ueVLCElQLjRL3mObHPxoyl0Cb8vG9hJWpSPgstcMK9DdhyTUtGYxGISz3E1QPAWWbD/HHOjW3BFQ7emRpjh9pUDX40XR+T+4UQ+W3pQIaMWT4n7mr1urve7FABg3dTfPD+mxfrJ3bEi8yZyci3ELP3i0kgtV1ZMnOvHXg8EARlVohJtBOfX7l2abU6MyZAjasJGXeY/0vyt90FR/Ncz42v4wUJwpAWZGjGmoluzCd2zihbQIU18JE5EjZGJRyyjIuNK71X5S6KAP8eXd7Cd2S9KhIB7bENJTDBb3AC1OQ== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(7916004)(396003)(376002)(346002)(39860400002)(136003)(451199015)(46966006)(40470700004)(36840700001)(966005)(16526019)(186003)(36860700001)(2906002)(83380400001)(81166007)(356005)(33716001)(70206006)(8676002)(70586007)(40460700003)(41300700001)(9686003)(82740400003)(478600001)(26005)(40480700001)(82310400005)(47076005)(336012)(5660300002)(103116003)(316002)(426003)(86362001)(8936002)(54906003)(110136005)(7416002)(4326008)(7406005)(44832011)(16576012)(71626007)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2022 15:35:56.0940 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cf948a29-c2f3-438f-e7a0-08dad3b1bd29 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT077.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5114 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org New AMD processors can now support following QoS features.=0A= =0A= 1. Slow Memory Bandwidth Allocation (SMBA)=0A= With this feature, the QOS enforcement policies can be applied=0A= to the external slow memory connected to the host. QOS enforcement=0A= is accomplished by assigning a Class Of Service (COS) to a processor=0A= and specifying allocations or limits for that COS for each resource=0A= to be allocated.=0A= =0A= Currently, CXL.memory is the only supported "slow" memory device. With= =0A= the support of SMBA feature the hardware enables bandwidth allocation=0A= on the slow memory devices.=0A= =0A= 2. Bandwidth Monitoring Event Configuration (BMEC)=0A= The bandwidth monitoring events mbm_total_event and mbm_local_event =0A= are set to count all the total and local reads/writes respectively.=0A= With the introduction of slow memory, the two counters are not enough=0A= to count all the different types are memory events. With the feature=0A= BMEC, the users have the option to configure mbm_total_event and=0A= mbm_local_event to count the specific type of events.=0A= =0A= Following are the bitmaps of events supported.=0A= Bits Description=0A= 6 Dirty Victims from the QOS domain to all types of memory=0A= 5 Reads to slow memory in the non-local NUMA domain=0A= 4 Reads to slow memory in the local NUMA domain=0A= 3 Non-temporal writes to non-local NUMA domain=0A= 2 Non-temporal writes to local NUMA domain=0A= 1 Reads to memory in the non-local NUMA domain=0A= 0 Reads to memory in the local NUMA domain=0A= =0A= This series adds support for these features.=0A= =0A= Feature description is available in the specification, "AMD64 Technology Pl= atform Quality of Service Extensions, Revision: 1.03 Publication # 56375=0A= Revision: 1.03 Issue Date: February 2022".=0A= =0A= Link: https://www.amd.com/en/support/tech-docs/amd64-technology-platform-qu= ality-service-extensions=0A= Link: https://bugzilla.kernel.org/show_bug.cgi?id=3D206537=0A= ---=0A= v9:=0A= Summary of changes:=0A= 1. Rebased on top of lastest tip/master as of 11/30.=0A= 2. Most of the changes are result of the comments from Fenghua, Reinette a= nd Peter Newman.=0A= 3. Fixed the cpuid dependancy.=0A= 4. Added the __init attribute to rdt_get_mon_l3_config and mbm_config_rfty= pe_init.=0A= 5. Added new function resctrl_arch_reset_rmid_all to clear all rmid statue= s.=0A= 6. Changed mon_event_config_index_get based on Reinette's comments.=0A= 7. Changed mbm_config_rftype_init to take care of few extra error handling= .=0A= 8. Few other minor changes and text changes.=0A= =0A= v8:=0A= https://lore.kernel.org/lkml/166759188265.3281208.11769277079826754455.stg= it@bmoger-ubuntu/=0A= Changes:=0A= 1. Removed init attribute for rdt_cpu_has to make it available for all the= files.=0A= 2. Updated the change log for mon_features to correct the names of config = files.=0A= 3. Changed configuration file name from mbm_total_config to mbm_total_byte= s_config.=0A= This is more consistant with other changes.=0A= 4. Added lock protection while reading/writing the config file.=0A= 5. Other few minor text changes. I have been missing few comments in last = couple of=0A= revisions. Hope I have addressed all of them this time.=0A= =0A= v7:=0A= https://lore.kernel.org/lkml/166604543832.5345.9696970469830919982.stgit@b= moger-ubuntu/=0A= Changes:=0A= Not much of a change. Missed one comment from Reinette from v5. Corrected = it now.=0A= Few format corrections from Sanjaya.=0A= =0A= v6:=0A= https://lore.kernel.org/lkml/166543345606.23830.3120625408601531368.stgit@= bmoger-ubuntu/=0A= Summary of changes:=0A= 1. Rebased on top of lastest tip tree. Fixed few minor conflicts.=0A= 2. Fixed format issue with scattered.c.=0A= 3. Removed config_name from the structure mon_evt. It is not required.=0A= 4. The read/write format for mbm_total_config and mbm_local_config will be= same=0A= as schemata format "id0=3Dval0;id1=3Dval1;...". This is comment from Fe= nghua.=0A= 5. Added more comments MSR_IA32_EVT_CFG_BASE writng.=0A= 5. Few text changes in resctrl.rst =0A= =0A= v5:=0A= https://lore.kernel.org/lkml/166431016617.373387.1968875281081252467.stgi= t@bmoger-ubuntu/=0A= Summary of changes.=0A= 1. Split the series into two. The first two patches are bug fixes. So, se= nt them separate.=0A= 2. The config files mbm_total_config and mbm_local_config are now under= =0A= /sys/fs/resctrl/info/L3_MON/. Removed these config files from mon grou= ps.=0A= 3. Ran "checkpatch --strict --codespell" on all the patches. Looks good w= ith few known exceptions.=0A= 4. Few minor text changes in resctrl.rst file. =0A= =0A= v4:=0A= https://lore.kernel.org/lkml/166257348081.1043018.11227924488792315932.st= git@bmoger-ubuntu/=0A= Got numerios of comments from Reinette Chatre. Addressed most of them. = =0A= Summary of changes.=0A= 1. Removed mon_configurable under /sys/fs/resctrl/info/L3_MON/. =0A= 2. Updated mon_features texts if the BMEC is supported.=0A= 3. Added more explanation about the slow memory support.=0A= 4. Replaced smp_call_function_many with on_each_cpu_mask call.=0A= 5. Removed arch_has_empty_bitmaps=0A= 6. Few other text changes.=0A= 7. Removed Reviewed-by if the patch is modified.=0A= 8. Rebased the patches to latest tip.=0A= =0A= v3:=0A= https://lore.kernel.org/lkml/166117559756.6695.16047463526634290701.stgit= @bmoger-ubuntu/=0A= a. Rebased the patches to latest tip. Resolved some conflicts.=0A= https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git=0A= b. Taken care of feedback from Bagas Sanjaya.=0A= c. Added Reviewed by from Mingo.=0A= Note: I am still looking for comments from Reinette or Fenghua.=0A= =0A= v2:=0A= https://lore.kernel.org/lkml/165938717220.724959.10931629283087443782.stg= it@bmoger-ubuntu/=0A= a. Rebased the patches to latest stable tree (v5.18.15). Resolved some co= nflicts.=0A= b. Added the patch to fix CBM issue on AMD. This was originally discussed= =0A= https://lore.kernel.org/lkml/20220517001234.3137157-1-eranian@google.c= om/=0A= =0A= v1:=0A= https://lore.kernel.org/lkml/165757543252.416408.13547339307237713464.stg= it@bmoger-ubuntu/=0A= =0A= Babu Moger (13):=0A= x86/cpufeatures: Add Slow Memory Bandwidth Allocation feature flag=0A= x86/resctrl: Add a new resource type RDT_RESOURCE_SMBA=0A= x86/cpufeatures: Add Bandwidth Monitoring Event Configuration feature= flag=0A= x86/resctrl: Include new features in command line options=0A= x86/resctrl: Detect and configure Slow Memory Bandwidth Allocation=0A= x86/resctrl: Add __init attribute to rdt_get_mon_l3_config()=0A= x86/resctrl: Introduce data structure to support monitor configuratio= n=0A= x86/resctrl: Add sysfs interface to read mbm_total_bytes_config=0A= x86/resctrl: Add sysfs interface to read mbm_local_bytes_config=0A= x86/resctrl: Add sysfs interface to write mbm_total_bytes_config=0A= x86/resctrl: Add sysfs interface to write mbm_local_bytes_config=0A= x86/resctrl: Replace smp_call_function_many() with on_each_cpu_mask()= =0A= Documentation/x86: Update resctrl.rst for new features=0A= =0A= =0A= .../admin-guide/kernel-parameters.txt | 2 +-=0A= Documentation/x86/resctrl.rst | 138 +++++++-=0A= arch/x86/include/asm/cpufeatures.h | 2 +=0A= arch/x86/include/asm/msr-index.h | 2 +=0A= arch/x86/kernel/cpu/cpuid-deps.c | 2 +=0A= arch/x86/kernel/cpu/resctrl/core.c | 54 ++-=0A= arch/x86/kernel/cpu/resctrl/ctrlmondata.c | 2 +-=0A= arch/x86/kernel/cpu/resctrl/internal.h | 28 ++=0A= arch/x86/kernel/cpu/resctrl/monitor.c | 26 +-=0A= arch/x86/kernel/cpu/resctrl/rdtgroup.c | 309 ++++++++++++++++--=0A= arch/x86/kernel/cpu/scattered.c | 2 +=0A= include/linux/resctrl.h | 10 +=0A= 12 files changed, 544 insertions(+), 33 deletions(-)=0A= =0A= --=0A=