From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v7] ether: add support for vtune task tracing Date: Fri, 22 Sep 2017 12:42:33 +0200 Message-ID: <1671807.t1LnDJUZi1@xps> References: <1500915997-26223-1-git-send-email-ilia.kurakin@intel.com> <20170908125721.2878-1-ilia.kurakin@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, jerin.jacob@caviumnetworks.com, keith.wiles@intel.com, dmitry.galanov@intel.com To: ilia.kurakin@intel.com Return-path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 01CEF7CDE for ; Fri, 22 Sep 2017 12:42:35 +0200 (CEST) In-Reply-To: <20170908125721.2878-1-ilia.kurakin@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 08/09/2017 14:57, ilia.kurakin@intel.com: > + /* See rte_ethdev_profile.h to find comments on code below. */ > + __rte_eth_profile_rx_init(port_id, dev); We can find easily where the function is defined. Please replace this comment by something like that: /* Initialize Rx profiling if enabled at compilation time. */ Why not checking an error code for this initialization? If we enable it, we expect the application to abort if the profiling does not work. > --- /dev/null > +++ b/lib/librte_ether/rte_ethdev_profile.h This file is internal so it should not appear in doxygen index. Please remove rte_ prefix from the filename to blacklist it from doxygen point of view. You can apply the same change to the .c file for consistency.