From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DAD8C53210 for ; Wed, 4 Jan 2023 14:57:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236020AbjADO4e (ORCPT ); Wed, 4 Jan 2023 09:56:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45332 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239533AbjADO4Z (ORCPT ); Wed, 4 Jan 2023 09:56:25 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 50195FACC for ; Wed, 4 Jan 2023 06:56:25 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E135861758 for ; Wed, 4 Jan 2023 14:56:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E3E26C433D2; Wed, 4 Jan 2023 14:56:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1672844184; bh=gFweX0ORFgrSd7w33oQiIs/TW+GT9VykIJg1qVDLB0I=; h=Subject:To:Cc:From:Date:From; b=IbQLgapugXUrJszB6ILDYWJ3Trzu57/lpUILo02ldT8n0sN1UgGtyP+pN00rPEuUT 4UeKCQeeYgSAedTEtq55Z9ut3FSus8TlqFYRj1tIVEZlH0WBZIKqdXxiKUP0SpekAl Bnby5PCRdZss4n6itJcbf8AjmH5Wo0WnF/Xxif5Q= Subject: FAILED: patch "[PATCH] fs: ext4: initialize fsdata in pagecache_write()" failed to apply to 5.4-stable tree To: glider@google.com, ebiggers@google.com, ebiggers@kernel.org, tytso@mit.edu Cc: From: Date: Wed, 04 Jan 2023 15:55:03 +0100 Message-ID: <167284410396148@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org The patch below does not apply to the 5.4-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . Possible dependencies: 956510c0c743 ("fs: ext4: initialize fsdata in pagecache_write()") bd256fda92ef ("ext4: use memcpy_to_page() in pagecache_write()") thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From 956510c0c7439e90b8103aaeaf4da92878c622f0 Mon Sep 17 00:00:00 2001 From: Alexander Potapenko Date: Mon, 21 Nov 2022 12:21:30 +0100 Subject: [PATCH] fs: ext4: initialize fsdata in pagecache_write() When aops->write_begin() does not initialize fsdata, KMSAN reports an error passing the latter to aops->write_end(). Fix this by unconditionally initializing fsdata. Cc: Eric Biggers Fixes: c93d8f885809 ("ext4: add basic fs-verity support") Reported-by: syzbot+9767be679ef5016b6082@syzkaller.appspotmail.com Signed-off-by: Alexander Potapenko Reviewed-by: Eric Biggers Link: https://lore.kernel.org/r/20221121112134.407362-1-glider@google.com Signed-off-by: Theodore Ts'o Cc: stable@kernel.org diff --git a/fs/ext4/verity.c b/fs/ext4/verity.c index 3c640bd7ecae..30e3b65798b5 100644 --- a/fs/ext4/verity.c +++ b/fs/ext4/verity.c @@ -79,7 +79,7 @@ static int pagecache_write(struct inode *inode, const void *buf, size_t count, size_t n = min_t(size_t, count, PAGE_SIZE - offset_in_page(pos)); struct page *page; - void *fsdata; + void *fsdata = NULL; int res; res = aops->write_begin(NULL, mapping, pos, n, &page, &fsdata);