From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DD132C5479D for ; Wed, 11 Jan 2023 10:49:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wCbQn1k1ZTTrTfQlb388nmFBfVknGILImAJ/laJW/M8=; b=KS44HGJlGRIMTj cFb6ezW1CCaJ8VeH23Jh8FUc2Kt7a5rVd43m7iL+im1wAssUzuB6Sm07MBb20qXUd0AvjnL258s77 udmN3sByeFrhH19RhYWvGBmEBKu6EXZqFa7827cjSyopfSixvtK/8k1p71i1ZYPzpix42l6I5Kodp AwJz00+xzcBHAW3LSmMjFxBt0OXec9dRekeRgdpf40g8+P9bLgMT3V0a6PwAkDjV1VAk5JqHJWQgm oRKctZ/eeDcgMnRaySx+b1KDTL1fn0mAZY7ylrX1jMBBc2UEIGJUfN/zHcJuEqdA/KXUu1ukJe9pn q0N3i863gBRdNu9Wh79g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pFYfP-00Atmw-Rq; Wed, 11 Jan 2023 10:49:11 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pFYep-00AtUy-9N; Wed, 11 Jan 2023 10:48:37 +0000 Received: from ip5b412258.dynamic.kabel-deutschland.de ([91.65.34.88] helo=phil.lan) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pFYem-0004Wz-VS; Wed, 11 Jan 2023 11:48:33 +0100 From: Heiko Stuebner To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Arnaud Ferraris , Caleb Connolly , devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org, Rob Herring , Krzysztof Kozlowski Cc: Heiko Stuebner , kernel@collabora.com Subject: Re: [PATCH] arm64: dts: rockchip: fix input enable pinconf on rk3399 Date: Wed, 11 Jan 2023 11:48:25 +0100 Message-Id: <167343400179.2680857.5225762201628008377.b4-ty@sntech.de> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221215101947.254896-1-arnaud.ferraris@collabora.com> References: <20221215101947.254896-1-arnaud.ferraris@collabora.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230111_024835_355931_4966D4D6 X-CRM114-Status: GOOD ( 12.22 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Thu, 15 Dec 2022 11:19:47 +0100, Arnaud Ferraris wrote: > When the input enable pinconf was introduced, a default drive-strength > value of 2 was set for the pull up/down configs. However, this parameter > is unneeded when configuring the pin as input, and having a single > hardcoded value here is actually harmful: GPIOs on the RK3399 have > various same drive-strength capabilities depending on the bank and port > they belong to. > > [...] Applied, thanks! [1/1] arm64: dts: rockchip: fix input enable pinconf on rk3399 commit: 6f515b663d49a14fb63f8c5d0a2a4ae53d44790a Best regards, -- Heiko Stuebner _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 760FAC46467 for ; Wed, 11 Jan 2023 10:49:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238579AbjAKKtZ (ORCPT ); Wed, 11 Jan 2023 05:49:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33416 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238698AbjAKKsi (ORCPT ); Wed, 11 Jan 2023 05:48:38 -0500 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DF0E513E85; Wed, 11 Jan 2023 02:48:34 -0800 (PST) Received: from ip5b412258.dynamic.kabel-deutschland.de ([91.65.34.88] helo=phil.lan) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pFYem-0004Wz-VS; Wed, 11 Jan 2023 11:48:33 +0100 From: Heiko Stuebner To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Arnaud Ferraris , Caleb Connolly , devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org, Rob Herring , Krzysztof Kozlowski Cc: Heiko Stuebner , kernel@collabora.com Subject: Re: [PATCH] arm64: dts: rockchip: fix input enable pinconf on rk3399 Date: Wed, 11 Jan 2023 11:48:25 +0100 Message-Id: <167343400179.2680857.5225762201628008377.b4-ty@sntech.de> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221215101947.254896-1-arnaud.ferraris@collabora.com> References: <20221215101947.254896-1-arnaud.ferraris@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 15 Dec 2022 11:19:47 +0100, Arnaud Ferraris wrote: > When the input enable pinconf was introduced, a default drive-strength > value of 2 was set for the pull up/down configs. However, this parameter > is unneeded when configuring the pin as input, and having a single > hardcoded value here is actually harmful: GPIOs on the RK3399 have > various same drive-strength capabilities depending on the bank and port > they belong to. > > [...] Applied, thanks! [1/1] arm64: dts: rockchip: fix input enable pinconf on rk3399 commit: 6f515b663d49a14fb63f8c5d0a2a4ae53d44790a Best regards, -- Heiko Stuebner From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C0DE9C54EBE for ; Wed, 11 Jan 2023 10:49:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tEeeQW09sEAY0OPtmEV5zslgA5zboZJlZ65lJUlTM6Y=; b=S/FzUIHXN0g9AL IX7lR9YoNhhfMeyxRG649JEcRsc3oJGqZzwjOlbHD2ksrCU6qYg2snyqeCl/pfPLsIhA8vgn+NuKM +vZAhZKGS8dea9Xqlm4KH/6ZtWKgR/xuYHpdj6y41H1Aymy4Yf8rffoQjhU1rQ8p+yX0lS2UOJzo3 IgFJpELhVMt9CueojAr+ezAu1xfwMBjeyvkIeR539AUq1vKRZC4OaqKEbmM2VVXWojrOJpOCFJA2S w8JkzutjVoRA6pDXx3TzlZRnXAm0KpXu1riETXiOvRZMA1g9E3VqaDZxBNVoEKNCv3QMnAvUyMf8U 7G8T4Ze9APvoaOutgcKg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pFYfG-00Atim-Ph; Wed, 11 Jan 2023 10:49:02 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pFYep-00AtUy-9N; Wed, 11 Jan 2023 10:48:37 +0000 Received: from ip5b412258.dynamic.kabel-deutschland.de ([91.65.34.88] helo=phil.lan) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pFYem-0004Wz-VS; Wed, 11 Jan 2023 11:48:33 +0100 From: Heiko Stuebner To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Arnaud Ferraris , Caleb Connolly , devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org, Rob Herring , Krzysztof Kozlowski Cc: Heiko Stuebner , kernel@collabora.com Subject: Re: [PATCH] arm64: dts: rockchip: fix input enable pinconf on rk3399 Date: Wed, 11 Jan 2023 11:48:25 +0100 Message-Id: <167343400179.2680857.5225762201628008377.b4-ty@sntech.de> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221215101947.254896-1-arnaud.ferraris@collabora.com> References: <20221215101947.254896-1-arnaud.ferraris@collabora.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230111_024835_355931_4966D4D6 X-CRM114-Status: GOOD ( 12.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 15 Dec 2022 11:19:47 +0100, Arnaud Ferraris wrote: > When the input enable pinconf was introduced, a default drive-strength > value of 2 was set for the pull up/down configs. However, this parameter > is unneeded when configuring the pin as input, and having a single > hardcoded value here is actually harmful: GPIOs on the RK3399 have > various same drive-strength capabilities depending on the bank and port > they belong to. > > [...] Applied, thanks! [1/1] arm64: dts: rockchip: fix input enable pinconf on rk3399 commit: 6f515b663d49a14fb63f8c5d0a2a4ae53d44790a Best regards, -- Heiko Stuebner _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel