All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Kees Cook <keescook@chromium.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
	linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-hardening@vger.kernel.org
Subject: Re: [PATCH] regulator: s5m8767: Bounds check id indexing into arrays
Date: Sat, 28 Jan 2023 20:47:21 +0000	[thread overview]
Message-ID: <167493884134.2529563.8166230650067316693.b4-ty@kernel.org> (raw)
In-Reply-To: <20230128005358.never.313-kees@kernel.org>

On Fri, 27 Jan 2023 16:53:58 -0800, Kees Cook wrote:
> The compiler has no way to know if "id" is within the array bounds of
> the regulators array. Add a check for this and a build-time check that
> the regulators and reg_voltage_map arrays are sized the same. Seen with
> GCC 13:
> 
> ../drivers/regulator/s5m8767.c: In function 's5m8767_pmic_probe':
> ../drivers/regulator/s5m8767.c:936:35: warning: array subscript [0, 36] is outside array bounds of 'struct regulator_desc[37]' [-Warray-bounds=]
>   936 |                         regulators[id].vsel_reg =
>       |                         ~~~~~~~~~~^~~~
> 
> [...]

Applied to

   broonie/regulator.git for-next

Thanks!

[1/1] regulator: s5m8767: Bounds check id indexing into arrays
      commit: e314e15a0b58f9d051c00b25951073bcdae61953

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark


      parent reply	other threads:[~2023-01-28 20:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-28  0:53 [PATCH] regulator: s5m8767: Bounds check id indexing into arrays Kees Cook
2023-01-28 10:39 ` Krzysztof Kozlowski
2023-01-28 20:47 ` Mark Brown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=167493884134.2529563.8166230650067316693.b4-ty@kernel.org \
    --to=broonie@kernel.org \
    --cc=keescook@chromium.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.