All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: rockchip: set sdmmc0 speed to sd-uhs-sdr50
@ 2023-01-28 11:24 ` Dan Johansen
  0 siblings, 0 replies; 6+ messages in thread
From: Dan Johansen @ 2023-01-28 11:24 UTC (permalink / raw)
  To: robh+dt, krzysztof.kozlowski+dt, heiko
  Cc: devicetree, linux-rockchip, Dan Johansen

As other rk336x based devices, the Rock 3 Model A has issues with high
speed SD cards, so lower the speed to 50 instead of 104 in the same
manor has the Quartz64 Model B has.

Fixes: 22a442e6 ("arm64: dts: rockchip: add basic dts for the radxa
rock3 model a")

Signed-off-by: Dan Johansen <strit@manjaro.org>
---
 arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
index a1c5fdf7d68f..e2e159371a9e 100644
--- a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
@@ -730,7 +730,7 @@ &sdmmc0 {
 	disable-wp;
 	pinctrl-names = "default";
 	pinctrl-0 = <&sdmmc0_bus4 &sdmmc0_clk &sdmmc0_cmd &sdmmc0_det>;
-	sd-uhs-sdr104;
+	sd-uhs-sdr50;
 	vmmc-supply = <&vcc3v3_sd>;
 	vqmmc-supply = <&vccio_sd>;
 	status = "okay";
-- 
2.39.1


_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH] arm64: dts: rockchip: set sdmmc0 speed to sd-uhs-sdr50
@ 2023-01-28 11:24 ` Dan Johansen
  0 siblings, 0 replies; 6+ messages in thread
From: Dan Johansen @ 2023-01-28 11:24 UTC (permalink / raw)
  To: robh+dt, krzysztof.kozlowski+dt, heiko
  Cc: devicetree, linux-rockchip, Dan Johansen

As other rk336x based devices, the Rock 3 Model A has issues with high
speed SD cards, so lower the speed to 50 instead of 104 in the same
manor has the Quartz64 Model B has.

Fixes: 22a442e6 ("arm64: dts: rockchip: add basic dts for the radxa
rock3 model a")

Signed-off-by: Dan Johansen <strit@manjaro.org>
---
 arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
index a1c5fdf7d68f..e2e159371a9e 100644
--- a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
@@ -730,7 +730,7 @@ &sdmmc0 {
 	disable-wp;
 	pinctrl-names = "default";
 	pinctrl-0 = <&sdmmc0_bus4 &sdmmc0_clk &sdmmc0_cmd &sdmmc0_det>;
-	sd-uhs-sdr104;
+	sd-uhs-sdr50;
 	vmmc-supply = <&vcc3v3_sd>;
 	vqmmc-supply = <&vccio_sd>;
 	status = "okay";
-- 
2.39.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] arm64: dts: rockchip: set sdmmc0 speed to sd-uhs-sdr50
  2023-01-28 11:24 ` Dan Johansen
@ 2023-01-29 11:09   ` Krzysztof Kozlowski
  -1 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2023-01-29 11:09 UTC (permalink / raw)
  To: Dan Johansen, robh+dt, krzysztof.kozlowski+dt, heiko
  Cc: devicetree, linux-rockchip

On 28/01/2023 12:24, Dan Johansen wrote:
> As other rk336x based devices, the Rock 3 Model A has issues with high
> speed SD cards, so lower the speed to 50 instead of 104 in the same
> manor has the Quartz64 Model B has.
> 
> Fixes: 22a442e6 ("arm64: dts: rockchip: add basic dts for the radxa
> rock3 model a")

Don't break the tags, one line please.

> 

And drop the blank line between tags.

Thanks.

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] arm64: dts: rockchip: set sdmmc0 speed to sd-uhs-sdr50
@ 2023-01-29 11:09   ` Krzysztof Kozlowski
  0 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2023-01-29 11:09 UTC (permalink / raw)
  To: Dan Johansen, robh+dt, krzysztof.kozlowski+dt, heiko
  Cc: devicetree, linux-rockchip

On 28/01/2023 12:24, Dan Johansen wrote:
> As other rk336x based devices, the Rock 3 Model A has issues with high
> speed SD cards, so lower the speed to 50 instead of 104 in the same
> manor has the Quartz64 Model B has.
> 
> Fixes: 22a442e6 ("arm64: dts: rockchip: add basic dts for the radxa
> rock3 model a")

Don't break the tags, one line please.

> 

And drop the blank line between tags.

Thanks.

Best regards,
Krzysztof


_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] arm64: dts: rockchip: set sdmmc0 speed to sd-uhs-sdr50
  2023-01-28 11:24 ` Dan Johansen
@ 2023-01-29 13:39   ` Heiko Stuebner
  -1 siblings, 0 replies; 6+ messages in thread
From: Heiko Stuebner @ 2023-01-29 13:39 UTC (permalink / raw)
  To: robh+dt, krzysztof.kozlowski+dt, Dan Johansen
  Cc: Heiko Stuebner, devicetree, linux-rockchip

On Sat, 28 Jan 2023 12:24:32 +0100, Dan Johansen wrote:
> As other rk336x based devices, the Rock 3 Model A has issues with high
> speed SD cards, so lower the speed to 50 instead of 104 in the same
> manor has the Quartz64 Model B has.
> 
> Fixes: 22a442e6 ("arm64: dts: rockchip: add basic dts for the radxa
> rock3 model a")
> 
> [...]

Applied, thanks!

[1/1] arm64: dts: rockchip: set sdmmc0 speed to sd-uhs-sdr50
      commit: 96e908b46e65b623ea325c984a0034307a0d456a

Best regards,
-- 
Heiko Stuebner <heiko@sntech.de>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] arm64: dts: rockchip: set sdmmc0 speed to sd-uhs-sdr50
@ 2023-01-29 13:39   ` Heiko Stuebner
  0 siblings, 0 replies; 6+ messages in thread
From: Heiko Stuebner @ 2023-01-29 13:39 UTC (permalink / raw)
  To: robh+dt, krzysztof.kozlowski+dt, Dan Johansen
  Cc: Heiko Stuebner, devicetree, linux-rockchip

On Sat, 28 Jan 2023 12:24:32 +0100, Dan Johansen wrote:
> As other rk336x based devices, the Rock 3 Model A has issues with high
> speed SD cards, so lower the speed to 50 instead of 104 in the same
> manor has the Quartz64 Model B has.
> 
> Fixes: 22a442e6 ("arm64: dts: rockchip: add basic dts for the radxa
> rock3 model a")
> 
> [...]

Applied, thanks!

[1/1] arm64: dts: rockchip: set sdmmc0 speed to sd-uhs-sdr50
      commit: 96e908b46e65b623ea325c984a0034307a0d456a

Best regards,
-- 
Heiko Stuebner <heiko@sntech.de>

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2023-01-29 13:40 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-28 11:24 [PATCH] arm64: dts: rockchip: set sdmmc0 speed to sd-uhs-sdr50 Dan Johansen
2023-01-28 11:24 ` Dan Johansen
2023-01-29 11:09 ` Krzysztof Kozlowski
2023-01-29 11:09   ` Krzysztof Kozlowski
2023-01-29 13:39 ` Heiko Stuebner
2023-01-29 13:39   ` Heiko Stuebner

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.