From: Rob Herring <robh@kernel.org>
To: Manuel Traut <manuel.traut@mt.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-input@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Frieder Schrempf <frieder.schrempf@kontron.de>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Subject: Re: [PATCH v9 3/4] dt-bindings: input: pwm-beeper: add volume
Date: Mon, 30 Jan 2023 09:29:03 -0600 [thread overview]
Message-ID: <167509249482.2676771.1698495294796937190.robh@kernel.org> (raw)
In-Reply-To: <20230130135650.1407156-4-manuel.traut@mt.com>
On Mon, 30 Jan 2023 14:56:49 +0100, Manuel Traut wrote:
> Adds an array of supported volume levels and a default volume level.
>
> Signed-off-by: Manuel Traut <manuel.traut@mt.com>
> ---
> .../devicetree/bindings/input/pwm-beeper.yaml | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/input/pwm-beeper.example.dtb: beeper: 'default-volume-level', 'volume-levels' do not match any of the regexes: 'pinctrl-[0-9]+'
From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/input/pwm-beeper.yaml
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230130135650.1407156-4-manuel.traut@mt.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2023-01-30 15:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-30 13:56 [PATCH v9 0/4] input: pwm-beeper: add feature to set volume level Manuel Traut
2023-01-30 13:56 ` [PATCH v9 1/4] dt-bindings: input: pwm-beeper: Convert txt bindings to yaml Manuel Traut
2023-01-30 23:00 ` Rob Herring
2023-01-30 13:56 ` [PATCH v9 2/4] input: pwm-beeper: add feature to set volume via sysfs Manuel Traut
2023-01-30 13:56 ` [PATCH v9 3/4] dt-bindings: input: pwm-beeper: add volume Manuel Traut
2023-01-30 15:29 ` Rob Herring [this message]
2023-02-01 8:37 ` Krzysztof Kozlowski
2023-01-30 13:56 ` [PATCH v9 4/4] input: pwm-beeper: set volume levels by devicetree Manuel Traut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=167509249482.2676771.1698495294796937190.robh@kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=frieder.schrempf@kontron.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manuel.traut@mt.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.