From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5F4FC64EC7 for ; Tue, 14 Feb 2023 16:57:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231908AbjBNQ54 (ORCPT ); Tue, 14 Feb 2023 11:57:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49242 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232517AbjBNQ5u (ORCPT ); Tue, 14 Feb 2023 11:57:50 -0500 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2E9604EE3; Tue, 14 Feb 2023 08:57:47 -0800 (PST) Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 31EGYEMR020138; Tue, 14 Feb 2023 16:57:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type : content-transfer-encoding; s=corp-2022-7-12; bh=N5x1b7fTJZ+VC4q/9vSjX8MBd5hq+5lTQEBy3Cn+Ffk=; b=0Cz4P0d22KpD2p8imwWEDwySImbXgZOTKgFhdknGq4lSN6/VQERNhOsYF/xR6dK3CYgR PhX3sbUMY9qCrBoIHQpNQKlM84/mDkSlN0CzfpGjp7TufJ4YtwZvJj+oEHqZFi2c1VW4 gtUb++YyjqdoCNCXtsZaN1/NyB/Rwh8kUEDf/PUx5RLvKR0sYQlfS4CXSb32/Z0ugWFa Ogb5/igt1j7hKTuvzCt5mVban4u3MkKpnJss5lrw6aH8kXkk5zKv/Q/YQQZT7cgcdhpu Q2h6ds6NX5vcTPmjTv1drPTD9RjmvYuoxdY7/HU6hbiiAOK7qesUiICV9q81bWd14d+U uw== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3np3jtwwx0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 14 Feb 2023 16:57:43 +0000 Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 31EGs2UV009673; Tue, 14 Feb 2023 16:57:42 GMT Received: from pps.reinject (localhost [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3np1f5uuge-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 14 Feb 2023 16:57:42 +0000 Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 31EGuHof039739; Tue, 14 Feb 2023 16:57:41 GMT Received: from ca-mkp2.ca.oracle.com.com (mpeterse-ol9.allregionaliads.osdevelopmeniad.oraclevcn.com [100.100.251.135]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTP id 3np1f5uuff-3; Tue, 14 Feb 2023 16:57:41 +0000 From: "Martin K. Petersen" To: linux-scsi@vger.kernel.org, Greg Kroah-Hartman Cc: "Martin K . Petersen" , Karan Tilak Kumar , Sesidhar Baddela , "James E.J. Bottomley" , linux-kernel@vger.kernel.org Subject: Re: [PATCH] scsi: snic: fix memory leak with using debugfs_lookup() Date: Tue, 14 Feb 2023 11:57:29 -0500 Message-Id: <167639371120.486235.16718699518610367058.b4-ty@oracle.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230202141009.2290380-1-gregkh@linuxfoundation.org> References: <20230202141009.2290380-1-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22 definitions=2023-02-14_11,2023-02-14_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 phishscore=0 suspectscore=0 mlxscore=0 spamscore=0 mlxlogscore=926 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2302140144 X-Proofpoint-ORIG-GUID: VHSvAC3VKqN3b8wepkMLcgtuIIaXok74 X-Proofpoint-GUID: VHSvAC3VKqN3b8wepkMLcgtuIIaXok74 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 02 Feb 2023 15:10:09 +0100, Greg Kroah-Hartman wrote: > When calling debugfs_lookup() the result must have dput() called on it, > otherwise the memory will leak over time. To make things simpler, just > call debugfs_lookup_and_remove() instead which handles all of the logic at > once. > > Applied to 6.3/scsi-queue, thanks! [1/1] scsi: snic: fix memory leak with using debugfs_lookup() https://git.kernel.org/mkp/scsi/c/ad0e4e2fab92 -- Martin K. Petersen Oracle Linux Engineering