From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B177C678D4 for ; Thu, 2 Mar 2023 19:34:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229905AbjCBTe4 (ORCPT ); Thu, 2 Mar 2023 14:34:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57928 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229591AbjCBTev (ORCPT ); Thu, 2 Mar 2023 14:34:51 -0500 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 15F4D1B542 for ; Thu, 2 Mar 2023 11:34:51 -0800 (PST) Received: from linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net (linux.microsoft.com [13.77.154.182]) by linux.microsoft.com (Postfix) with ESMTPSA id 6EF0920B9C3D; Thu, 2 Mar 2023 11:34:50 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 6EF0920B9C3D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1677785690; bh=6Tvtuiro6Rs44YifCyzt6GKgNmrargfr4Wcp7VYJ/Rw=; h=From:To:Subject:Date:From; b=dm4J+fjRRLotjP7dvmezTypnoJLOxIvEVLDJq9AoVZ+cNBO4FhmFp5ZYrBi6hLEys zDH8HgC0bm+0LgUJM6YwI+LMSbVvz5BQKwDQkS9RlImGnLjzmew1WcLDmTR/Pld7Dx RV65/T76wxnm/wVu3o4K+QTTPmrAJlVq8fzIQ3s0= From: Saurabh Sengar To: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, johan+linaro@kernel.org, isaku.yamahata@intel.com, mikelley@microsoft.com, linux-kernel@vger.kernel.org Subject: [PATCH] x86/ioapic: Don't return 0 as valid virq Date: Thu, 2 Mar 2023 11:34:46 -0800 Message-Id: <1677785686-2152-1-git-send-email-ssengar@linux.microsoft.com> X-Mailer: git-send-email 1.8.3.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Zero is invalid virq and should't be returned as a valid value for lower irq bound. If IO-APIC and gsi_top are not initialized return the 'from' value as virq. Signed-off-by: Saurabh Sengar --- arch/x86/kernel/apic/io_apic.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c index a868b76cd3d4..000cc6159b8b 100644 --- a/arch/x86/kernel/apic/io_apic.c +++ b/arch/x86/kernel/apic/io_apic.c @@ -2483,9 +2483,11 @@ unsigned int arch_dynirq_lower_bound(unsigned int from) /* * dmar_alloc_hwirq() may be called before setup_IO_APIC(), so use * gsi_top if ioapic_dynirq_base hasn't been initialized yet. + * + * Incase gsi_top is also not initialized return @from. */ if (!ioapic_initialized) - return gsi_top; + return gsi_top ? : from; /* * For DT enabled machines ioapic_dynirq_base is irrelevant and not * updated. So simply return @from if ioapic_dynirq_base == 0. -- 2.34.1