From: "Theodore Ts'o" <tytso@mit.edu>
To: linux-ext4@vger.kernel.org, Eric Biggers <ebiggers@kernel.org>
Cc: "Theodore Ts'o" <tytso@mit.edu>,
linux-fscrypt@vger.kernel.org, stable@vger.kernel.org,
Matthew Wilcox <willy@infradead.org>, Tejun Heo <tj@kernel.org>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] ext4: fix cgroup writeback accounting with fs-layer encryption
Date: Tue, 7 Mar 2023 23:33:22 -0500 [thread overview]
Message-ID: <167824999281.2129363.12204207098890359786.b4-ty@mit.edu> (raw)
In-Reply-To: <20230203005503.141557-1-ebiggers@kernel.org>
On Thu, 2 Feb 2023 16:55:03 -0800, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> When writing a page from an encrypted file that is using
> filesystem-layer encryption (not inline encryption), ext4 encrypts the
> pagecache page into a bounce page, then writes the bounce page.
>
> It also passes the bounce page to wbc_account_cgroup_owner(). That's
> incorrect, because the bounce page is a newly allocated temporary page
> that doesn't have the memory cgroup of the original pagecache page.
> This makes wbc_account_cgroup_owner() not account the I/O to the owner
> of the pagecache page as it should.
>
> [...]
Applied, thanks!
[1/1] ext4: fix cgroup writeback accounting with fs-layer encryption
commit: ffec85d53d0f39ee4680a2cf0795255e000e1feb
Best regards,
--
Theodore Ts'o <tytso@mit.edu>
prev parent reply other threads:[~2023-03-08 4:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-03 0:55 [PATCH] ext4: fix cgroup writeback accounting with fs-layer encryption Eric Biggers
2023-02-03 18:19 ` Tejun Heo
2023-03-07 19:52 ` Eric Biggers
2023-03-08 4:33 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=167824999281.2129363.12204207098890359786.b4-ty@mit.edu \
--to=tytso@mit.edu \
--cc=ebiggers@kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=tj@kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.