All of lore.kernel.org
 help / color / mirror / Atom feed
From: Babu Moger <babu.moger@amd.com>
To: <corbet@lwn.net>, <reinette.chatre@intel.com>,
	<tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>
Cc: <fenghua.yu@intel.com>, <dave.hansen@linux.intel.com>,
	<x86@kernel.org>, <hpa@zytor.com>, <paulmck@kernel.org>,
	<akpm@linux-foundation.org>, <quic_neeraju@quicinc.com>,
	<rdunlap@infradead.org>, <damien.lemoal@opensource.wdc.com>,
	<songmuchun@bytedance.com>, <peterz@infradead.org>,
	<jpoimboe@kernel.org>, <pbonzini@redhat.com>,
	<babu.moger@amd.com>, <chang.seok.bae@intel.com>,
	<pawan.kumar.gupta@linux.intel.com>, <jmattson@google.com>,
	<daniel.sneddon@linux.intel.com>, <sandipan.das@amd.com>,
	<tony.luck@intel.com>, <james.morse@arm.com>,
	<linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<bagasdotme@gmail.com>, <eranian@google.com>,
	<christophe.leroy@csgroup.eu>,
	<pawan.kumar.gupta@linux.intel.com>, <jarkko@kernel.org>,
	<adrian.hunter@intel.com>, <quic_jiles@quicinc.com>,
	<peternewman@google.com>, <babu.moger@amd.com>
Subject: [PATCH v4 0/7] x86/resctrl: Miscellaneous resctrl features
Date: Mon, 17 Apr 2023 18:33:56 -0500	[thread overview]
Message-ID: <168177435378.1758847.8317743523931859131.stgit@bmoger-ubuntu> (raw)

These series adds support few minor features.
1. Support assigning multiple tasks to control/mon groups in one command.
2. Add debug mount option for resctrl interface.
3. Add RMID and CLOSID in resctrl interface when mounted with debug option.
4. While doing these above changes, found that rftype flags needed some cleanup.
   They were named inconsistently. Re-arranged them much more cleanly now.
   Hope it can help future additions.

---
v4: Changes since v3
    Addressed comments from Reinette and others.
    Removed newline requirement when adding tasks.
    Dropped one of the changes on flags. Kept the flag names mostly same.
    Changed the names of closid and rmid to ctrl_hw_id and mon_hw_id respectively.
    James had some concerns about adding these files. But I thing it is big problem.
    Please comment back if we can do better. 
    Tried to address Reinette's comment on patch 7. But due to current code design
    I could not do it exact way. But changed it little bit to make it easy debug
    file additions in the future.  

v3: Changes since v2
    Still waiting for more comments. While waiting, addressed few comments from Fenghua.
    Added few more texts in the documentation about multiple tasks assignment feature.
    Added pid in last_cmd_status when applicable.
    Introduced static resctrl_debug to save the debug option.
    Few minor text changes.
  
v2: Changes since v1
  a. Removed the changes to add the task's threads automatically. It required
     book keeping to handle the failures and gets complicated. Removed that change
     for now.
  b. Added -o debug option to mount in debug mode(comment from Fenghua)
  c. Added debug files rmid and closid. Stephane wanted to rename them more
     generic to accommodate ARM. It kind of loses meaning if is renamed differently.
     Kept it same for now. Will change if he feels strong about it. 

v3: https://lore.kernel.org/lkml/167778850105.1053859.14596357862185564029.stgit@bmoger-ubuntu/
v2: https://lore.kernel.org/lkml/167537433143.647488.9641864719195184123.stgit@bmoger-ubuntu/
v1: https://lore.kernel.org/lkml/167278351577.34228.12803395505584557101.stgit@bmoger-ubuntu/

Babu Moger (7):
      x86/resctrl: Add multiple tasks to the resctrl group at once
      x86/resctrl: Remove unnecessary rftype flags
      x86/resctrl: Rename rftype flags for consistency
      x86/resctrl: Re-arrange RFTYPE flags and add more comments
      x86/resctrl: Introduce "-o debug" mount option
      x86/resctrl: Display CLOSID and RMID for the resctrl groups
      x86/resctrl: Add debug files when mounted with debug option


 Documentation/x86/resctrl.rst          |  29 +++-
 arch/x86/kernel/cpu/resctrl/internal.h |  62 ++++++--
 arch/x86/kernel/cpu/resctrl/rdtgroup.c | 188 ++++++++++++++++++++++---
 3 files changed, 243 insertions(+), 36 deletions(-)

--


             reply	other threads:[~2023-04-17 23:34 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-17 23:33 Babu Moger [this message]
2023-04-17 23:34 ` [PATCH v4 1/7] x86/resctrl: Add multiple tasks to the resctrl group at once Babu Moger
2023-04-19 12:58   ` Ilpo Järvinen
2023-04-19 14:52     ` Moger, Babu
2023-04-20  9:38       ` Ilpo Järvinen
2023-05-04 18:57   ` Reinette Chatre
2023-05-05 17:09     ` Moger, Babu
2023-05-05 18:49       ` Reinette Chatre
2023-05-09 17:13         ` Moger, Babu
2023-04-17 23:34 ` [PATCH v4 2/7] x86/resctrl: Remove unnecessary rftype flags Babu Moger
2023-05-04 18:58   ` Reinette Chatre
2023-05-05 18:31     ` Moger, Babu
2023-05-05 18:54       ` Reinette Chatre
2023-05-05 19:04         ` Moger, Babu
2023-05-05 21:28           ` Reinette Chatre
2023-05-09 18:54             ` Moger, Babu
2023-05-09 19:31             ` Moger, Babu
2023-04-17 23:34 ` [PATCH v4 3/7] x86/resctrl: Rename rftype flags for consistency Babu Moger
2023-04-19 12:44   ` Ilpo Järvinen
2023-04-19 14:29     ` Moger, Babu
2023-05-04 19:00   ` Reinette Chatre
     [not found]     ` <232c8e85-0d5b-8e24-33d0-eab5eee186f0@amd.com>
2023-05-05 21:24       ` Reinette Chatre
2023-05-09 17:42         ` Moger, Babu
2023-04-17 23:34 ` [PATCH v4 4/7] x86/resctrl: Re-arrange RFTYPE flags and add more comments Babu Moger
2023-05-04 19:00   ` Reinette Chatre
2023-05-05 20:40     ` Moger, Babu
2023-05-05 21:24       ` Reinette Chatre
2023-05-09 17:33         ` Moger, Babu
2023-04-17 23:34 ` [PATCH v4 5/7] x86/resctrl: Introduce "-o debug" mount option Babu Moger
2023-05-04 19:02   ` Reinette Chatre
2023-05-05 21:26     ` Moger, Babu
2023-04-17 23:34 ` [PATCH v4 6/7] x86/resctrl: Display CLOSID and RMID for the resctrl groups Babu Moger
2023-04-18  2:22   ` Bagas Sanjaya
2023-04-18 14:11     ` Moger, Babu
2023-05-04 19:04   ` Reinette Chatre
2023-05-05 21:45     ` Moger, Babu
2023-05-05 23:25       ` Reinette Chatre
2023-04-17 23:35 ` [PATCH v4 7/7] x86/resctrl: Add debug files when mounted with debug option Babu Moger
2023-04-19 13:20   ` Ilpo Järvinen
2023-04-19 15:16     ` Moger, Babu
2023-04-19 15:16     ` Moger, Babu
2023-04-19 17:16     ` Moger, Babu
2023-04-20  8:59       ` Ilpo Järvinen
2023-04-21 18:47         ` Moger, Babu
2023-04-24 15:12           ` Ilpo Järvinen
2023-05-04 18:54 ` [PATCH v4 0/7] x86/resctrl: Miscellaneous resctrl features Reinette Chatre
2023-05-05 15:43   ` Moger, Babu
2023-05-05 17:47     ` Reinette Chatre
2023-05-05 18:03       ` Moger, Babu
2023-05-29 10:18 ` Shaopeng Tan (Fujitsu)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=168177435378.1758847.8317743523931859131.stgit@bmoger-ubuntu \
    --to=babu.moger@amd.com \
    --cc=adrian.hunter@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=bagasdotme@gmail.com \
    --cc=bp@alien8.de \
    --cc=chang.seok.bae@intel.com \
    --cc=christophe.leroy@csgroup.eu \
    --cc=corbet@lwn.net \
    --cc=damien.lemoal@opensource.wdc.com \
    --cc=daniel.sneddon@linux.intel.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=eranian@google.com \
    --cc=fenghua.yu@intel.com \
    --cc=hpa@zytor.com \
    --cc=james.morse@arm.com \
    --cc=jarkko@kernel.org \
    --cc=jmattson@google.com \
    --cc=jpoimboe@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=paulmck@kernel.org \
    --cc=pawan.kumar.gupta@linux.intel.com \
    --cc=pbonzini@redhat.com \
    --cc=peternewman@google.com \
    --cc=peterz@infradead.org \
    --cc=quic_jiles@quicinc.com \
    --cc=quic_neeraju@quicinc.com \
    --cc=rdunlap@infradead.org \
    --cc=reinette.chatre@intel.com \
    --cc=sandipan.das@amd.com \
    --cc=songmuchun@bytedance.com \
    --cc=tglx@linutronix.de \
    --cc=tony.luck@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.