All of
 help / color / mirror / Atom feed
From: David Howells <>
To: Miklos Szeredi <>
Cc:, Al Viro <>,
	Kernel Mailing List <>,
	Linux-Fsdevel <>,
	"" <>
Subject: Re: Can ovl_drop_write() be called earlier in ovl_dentry_open()
Date: Mon, 01 Jun 2015 16:45:03 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Miklos Szeredi <> wrote:

> > In ovl_dentry_open(), ovl_drop_write() is called after vfs_open() - but is
> > this actually necessary?  Can't we just drop it post-copyup?  After all,
> > that's all we wanted the write lock for, right?
> Hmm,  that could result in a race where remount r/o of upper fs comes
> in between copy-up and vfs_open() so copy-up succeeds but the actual
> open fails.  It's harmless, though, and not  very likely.  So I guess
> your patch is OK.

That race is there anyway if there's no copy up, right?


  parent reply	other threads:[~2015-06-01 15:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-01 13:52 David Howells
2015-06-01 14:21 ` [PATCH] overlay: Call ovl_drop_write() " David Howells
2015-06-01 14:22 ` Can ovl_drop_write() be called " Miklos Szeredi
2015-06-01 15:45 ` David Howells [this message]
2015-06-01 15:51   ` Miklos Szeredi
2015-06-01 15:53   ` David Howells

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \
    --subject='Re: Can ovl_drop_write() be called earlier in ovl_dentry_open()' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.