From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 947B9C07E9C for ; Thu, 8 Jul 2021 16:50:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7DDE361625 for ; Thu, 8 Jul 2021 16:50:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229838AbhGHQxa (ORCPT ); Thu, 8 Jul 2021 12:53:30 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:50630 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229542AbhGHQx3 (ORCPT ); Thu, 8 Jul 2021 12:53:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1625763046; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2OB0zSrc/L137vieSn1bV5IcC6z0P+Q1vkoqM8xpfTo=; b=YEQI2B85NKHdFVQI9+sMoi9OQUYYjxYD9xmr1/qK7ZADcxSoiYTbcDrsRho6CcmU7gf8ij Skecd1g8ifNnPg4itELRXECm9Zzt6z2Wkg9rYG5rrVlBAxdSFUssSXIYoVSQBjdIUuu0xS RxLBq0Egot0aiHI+DjuU5/Dr6N7gRLA= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-409-Aqzgl9nqP6SbmHbz6Z2bMw-1; Thu, 08 Jul 2021 12:50:45 -0400 X-MC-Unique: Aqzgl9nqP6SbmHbz6Z2bMw-1 Received: by mail-ed1-f70.google.com with SMTP id y18-20020a0564022712b029038ffac1995eso3658955edd.12 for ; Thu, 08 Jul 2021 09:50:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=2OB0zSrc/L137vieSn1bV5IcC6z0P+Q1vkoqM8xpfTo=; b=jdvaQ62Cl4D4m6BNVfWkxXYM7g5dTChOcj7+gKenelXRykNcubDrFjCCea0NofOp2y pRCt5G5ayNn2PfMp0P8YJsBI7OfJtFQSUNqQlM9RjCbjyLpuSlq2nrYdZjmiZjj0ssRY 47uzA6DNkFXDKY+ABfe8kKVk1Dcn8gM2AsSEpo2LK7rFR7GrglH9whMAn0UDPz9hjaKc vPXJM7sB44gmnR5CIJIQcGeqcNH5WtzuEVQPARTGGpvCMxRg1yuYJ/5puqJwjp4W+DtC xwdnC4xy8xp1Ja4PYpV+7wQjADszboPAf+1x8wDouVtdWyc3XX9Qk+34GTi9xF0uHL/8 ar4A== X-Gm-Message-State: AOAM530BUA7+oXNUtbFvV5HAG25y2nHmcVyudUhEM+50Xz/ZOkG8n26p lft3AkAc2zuyfP3hAPDVGQcO1YmJXv15QaysMe6hR9g/eyX9YN/e05BKofXBFAyQ14nGxCzkfGZ yE3hadg6nmO3bFac6gWWHPHkA X-Received: by 2002:a17:907:d8c:: with SMTP id go12mr19890645ejc.442.1625763044386; Thu, 08 Jul 2021 09:50:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzk9fO2BRrb8OTLwrPrz4tYr5MAon9lbPn4sasbXn1PywwYC0XefPHKB81KozyzGnj+G0mQ5Q== X-Received: by 2002:a17:907:d8c:: with SMTP id go12mr19890610ejc.442.1625763044210; Thu, 08 Jul 2021 09:50:44 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id j6sm1618320eds.58.2021.07.08.09.50.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Jul 2021 09:50:43 -0700 (PDT) Subject: Re: [PATCH 0/5] KVM: x86: Use kernel x86 cpuid utilities in KVM selftests To: Jim Mattson , Ricardo Koller Cc: kvm@vger.kernel.org, Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , "H. Peter Anvin" , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Joerg Roedel , Nathan Chancellor , Nick Desaulniers , linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com References: <20210422005626.564163-1-ricarkol@google.com> From: Paolo Bonzini Message-ID: <16823e91-5caf-f52e-e0dc-28ebb9a87b47@redhat.com> Date: Thu, 8 Jul 2021 18:50:41 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29/06/21 19:28, Jim Mattson wrote: >> Thanks. I was thinking about kvm-unit-tests, but the issue is that it >> would also be a copy. And just like with kernel headers, it would be >> ideal to keep them in-sync. The advantage of the kernel headers is that >> it's much easier to check and fix diffs with them. On the other hand, as >> you say, there would not be any #ifdef stuff with kvm=unit-tests. Please >> let me know what you think. > > I think the kvm-unit-tests implementation is superior to the kernel > implementation, but that's probably because I suggested it. Still, I > think there's an argument to be made that selftests, unlike > kvm-unit-tests, are part of the kernel distribution and should be > consistent with the kernel where possible. > > Paolo? I also prefer the kvm-unit-tests implementation, for what it's worth... Let's see what the code looks like? Paolo