From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC30E19B; Mon, 5 Jun 2023 02:12:57 +0000 (UTC) Received: from out30-112.freemail.mail.aliyun.com (out30-112.freemail.mail.aliyun.com [115.124.30.112]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3A893B1; Sun, 4 Jun 2023 19:12:54 -0700 (PDT) X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R711e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045170;MF=xuanzhuo@linux.alibaba.com;NM=1;PH=DS;RN=13;SR=0;TI=SMTPD_---0VkIJNup_1685931170; Received: from localhost(mailfrom:xuanzhuo@linux.alibaba.com fp:SMTPD_---0VkIJNup_1685931170) by smtp.aliyun-inc.com; Mon, 05 Jun 2023 10:12:51 +0800 Message-ID: <1685931044.5893385-2-xuanzhuo@linux.alibaba.com> Subject: Re: [PATCH vhost v10 10/10] virtio_net: support dma premapped Date: Mon, 5 Jun 2023 10:10:44 +0800 From: Xuan Zhuo To: Jakub Kicinski Cc: virtualization@lists.linux-foundation.org, "Michael S. Tsirkin" , Jason Wang , "David S. Miller" , Eric Dumazet , Paolo Abeni , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , netdev@vger.kernel.org, bpf@vger.kernel.org References: <20230602092206.50108-1-xuanzhuo@linux.alibaba.com> <20230602092206.50108-11-xuanzhuo@linux.alibaba.com> <20230602233152.4d9b9ba4@kernel.org> In-Reply-To: <20230602233152.4d9b9ba4@kernel.org> X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: On Fri, 2 Jun 2023 23:31:52 -0700, Jakub Kicinski wrote: > On Fri, 2 Jun 2023 17:22:06 +0800 Xuan Zhuo wrote: > > drivers/net/virtio_net.c | 163 +++++++++++++++++++++++++++++++++------ > > ack for this going via the vhost tree, FWIW, but you'll potentially > need to wait for the merge window to move forward with the actual > af xdp patches, in this case. My current plan is to let virtio support premapped dma first, and then implement virtio-net to support af-xdp zerocopy. This will indeed involve two branches. But most of the implementations in this patch are virtio code, so I think it would be more appropriate to commit to vhost. Do you have any good ideas? Thanks. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6B4CDC7EE2C for ; Mon, 5 Jun 2023 02:13:02 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id D7D9D4032B; Mon, 5 Jun 2023 02:13:01 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org D7D9D4032B X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0hYfCIvWG5ee; Mon, 5 Jun 2023 02:13:01 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp2.osuosl.org (Postfix) with ESMTPS id 71B8B40017; Mon, 5 Jun 2023 02:13:00 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 71B8B40017 Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 3B2E9C0037; Mon, 5 Jun 2023 02:13:00 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id DFC34C0029 for ; Mon, 5 Jun 2023 02:12:58 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id B3C08417FB for ; Mon, 5 Jun 2023 02:12:58 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org B3C08417FB X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id muSTuvQVA1Gz for ; Mon, 5 Jun 2023 02:12:57 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 0EB01417E6 Received: from out30-101.freemail.mail.aliyun.com (out30-101.freemail.mail.aliyun.com [115.124.30.101]) by smtp4.osuosl.org (Postfix) with ESMTPS id 0EB01417E6 for ; Mon, 5 Jun 2023 02:12:56 +0000 (UTC) X-Alimail-AntiSpam: AC=PASS; BC=-1|-1; BR=01201311R711e4; CH=green; DM=||false|; DS=||; FP=0|-1|-1|-1|0|-1|-1|-1; HT=ay29a033018045170; MF=xuanzhuo@linux.alibaba.com; NM=1; PH=DS; RN=13; SR=0; TI=SMTPD_---0VkIJNup_1685931170; Received: from localhost(mailfrom:xuanzhuo@linux.alibaba.com fp:SMTPD_---0VkIJNup_1685931170) by smtp.aliyun-inc.com; Mon, 05 Jun 2023 10:12:51 +0800 Message-ID: <1685931044.5893385-2-xuanzhuo@linux.alibaba.com> Subject: Re: [PATCH vhost v10 10/10] virtio_net: support dma premapped Date: Mon, 5 Jun 2023 10:10:44 +0800 From: Xuan Zhuo To: Jakub Kicinski References: <20230602092206.50108-1-xuanzhuo@linux.alibaba.com> <20230602092206.50108-11-xuanzhuo@linux.alibaba.com> <20230602233152.4d9b9ba4@kernel.org> In-Reply-To: <20230602233152.4d9b9ba4@kernel.org> Cc: Jesper Dangaard Brouer , Daniel Borkmann , "Michael S. Tsirkin" , netdev@vger.kernel.org, John Fastabend , Alexei Starovoitov , virtualization@lists.linux-foundation.org, Eric Dumazet , bpf@vger.kernel.org, Paolo Abeni , "David S. Miller" X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" On Fri, 2 Jun 2023 23:31:52 -0700, Jakub Kicinski wrote: > On Fri, 2 Jun 2023 17:22:06 +0800 Xuan Zhuo wrote: > > drivers/net/virtio_net.c | 163 +++++++++++++++++++++++++++++++++------ > > ack for this going via the vhost tree, FWIW, but you'll potentially > need to wait for the merge window to move forward with the actual > af xdp patches, in this case. My current plan is to let virtio support premapped dma first, and then implement virtio-net to support af-xdp zerocopy. This will indeed involve two branches. But most of the implementations in this patch are virtio code, so I think it would be more appropriate to commit to vhost. Do you have any good ideas? Thanks. _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization