From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D34C7EB64DA for ; Sun, 18 Jun 2023 20:51:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229764AbjFRUvW (ORCPT ); Sun, 18 Jun 2023 16:51:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48776 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229639AbjFRUuI (ORCPT ); Sun, 18 Jun 2023 16:50:08 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DA378E4F; Sun, 18 Jun 2023 13:50:06 -0700 (PDT) Date: Sun, 18 Jun 2023 20:50:05 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1687121405; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xCFs+WVBnorywR4TvQ0Vs07yRWRFxviJoCcGWxR8i4o=; b=dr6VuJCJMG8S3etF6Cv8OnPGfwx8CRDwLePE8XB1n1T1xUoovV7b6DFpZMu6IMEAM0R7pf LjvOol0vl/4IGApnJT4Bf0k3MqLZe9w61/0EPaIPHu639d6WlnH8GxZ/lx7BwjF9BKhfv3 AMnUeU2Ir+n2rRlABgaaxLbzxUJ20kDehwa5w3ZQheswuTyz9iphg+8TkegcW7VkUIksrr TA0bzmzt4Fbpcg/lssogGWGHHlYhAfHpNORrkrC1OGRReM0Mbg8zrLP/K+B+jCXBU6uTdM 9GkadbeRFzLejmH6O3fPoEQbGx9x8sDxqEp+YAMO/mBns6Rphxq6yoiPBK9Gew== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1687121405; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xCFs+WVBnorywR4TvQ0Vs07yRWRFxviJoCcGWxR8i4o=; b=w8E7cdYNq8CU0uElrDq2+JEKOLewAiolrOzHagCcYNxRrR5Wg9gRf7vzO1HHY/fhxSx+ph aF7xG0e26PGHBTDA== From: "tip-bot2 for Thomas Gleixner" Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip: timers/core] posix-timers: Set k_itimer:: It_signal to NULL on exit() Cc: Thomas Gleixner , Frederic Weisbecker , x86@kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20230425183313.196462644@linutronix.de> References: <20230425183313.196462644@linutronix.de> MIME-Version: 1.0 Message-ID: <168712140508.404.13177458639953476257.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The following commit has been merged into the timers/core branch of tip: Commit-ID: 72786ff23d5acb7bf3e2535831b2f1dc55c7f44e Gitweb: https://git.kernel.org/tip/72786ff23d5acb7bf3e2535831b2f1dc55c7f44e Author: Thomas Gleixner AuthorDate: Tue, 25 Apr 2023 20:49:06 +02:00 Committer: Thomas Gleixner CommitterDate: Sun, 18 Jun 2023 22:41:49 +02:00 posix-timers: Set k_itimer:: It_signal to NULL on exit() Technically it's not required to set k_itimer::it_signal to NULL on exit() because there is no other thread anymore which could lookup the timer concurrently. Set it to NULL for consistency sake and add a comment to that effect. Signed-off-by: Thomas Gleixner Reviewed-by: Frederic Weisbecker Link: https://lore.kernel.org/r/20230425183313.196462644@linutronix.de --- kernel/time/posix-timers.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/kernel/time/posix-timers.c b/kernel/time/posix-timers.c index de3fca8..c1b77c5 100644 --- a/kernel/time/posix-timers.c +++ b/kernel/time/posix-timers.c @@ -1101,6 +1101,14 @@ retry_delete: } list_del(&timer->list); + /* + * Setting timer::it_signal to NULL is technically not required + * here as nothing can access the timer anymore legitimately via + * the hash table. Set it to NULL nevertheless so that all deletion + * paths are consistent. + */ + WRITE_ONCE(timer->it_signal, NULL); + spin_unlock_irqrestore(&timer->it_lock, flags); release_posix_timer(timer, IT_ID_SET); }