From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B22C6EB64DD for ; Mon, 3 Jul 2023 05:23:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229923AbjGCFXi (ORCPT ); Mon, 3 Jul 2023 01:23:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52400 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229680AbjGCFXf (ORCPT ); Mon, 3 Jul 2023 01:23:35 -0400 Received: from gandalf.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 015551B0 for ; Sun, 2 Jul 2023 22:23:33 -0700 (PDT) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4QvZ8K5xWTz4wxv; Mon, 3 Jul 2023 15:23:29 +1000 (AEST) From: Michael Ellerman To: Nicholas Piggin , Christophe Leroy , Rob Herring Cc: Darren Stevens , "R.T.Dickinson" , Christian Zigotzky , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org In-Reply-To: <20230505171816.3175865-1-robh@kernel.org> References: <20230505171816.3175865-1-robh@kernel.org> Subject: Re: [PATCH] powerpc: isa-bridge: Fix ISA mmapping when "ranges" is not present Message-Id: <168836167601.46386.17041701491443802315.b4-ty@ellerman.id.au> Date: Mon, 03 Jul 2023 15:21:16 +1000 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 05 May 2023 12:18:17 -0500, Rob Herring wrote: > Commit e4ab08be5b49 ("powerpc/isa-bridge: Remove open coded "ranges" > parsing") broke PASemi Nemo board booting. The issue is the ISA I/O > range was not getting mapped as the logic to handle no "ranges" was > inverted. If phb_io_base_phys is non-zero, then the ISA range defaults > to the first 64K of the PCI I/O space. phb_io_base_phys should only be 0 > when looking for a non-PCI ISA region. > > [...] Applied to powerpc/fixes. [1/1] powerpc: isa-bridge: Fix ISA mmapping when "ranges" is not present https://git.kernel.org/powerpc/c/79de36042eecb684e0f748d17ba52f365fde0d65 cheers From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 47D8AC0015E for ; Mon, 3 Jul 2023 05:27:32 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4QvZDy5vTPz3d8p for ; Mon, 3 Jul 2023 15:27:30 +1000 (AEST) Received: from gandalf.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4QvZ8M1wbRz3bdV for ; Mon, 3 Jul 2023 15:23:31 +1000 (AEST) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4QvZ8K5xWTz4wxv; Mon, 3 Jul 2023 15:23:29 +1000 (AEST) From: Michael Ellerman To: Nicholas Piggin , Christophe Leroy , Rob Herring In-Reply-To: <20230505171816.3175865-1-robh@kernel.org> References: <20230505171816.3175865-1-robh@kernel.org> Subject: Re: [PATCH] powerpc: isa-bridge: Fix ISA mmapping when "ranges" is not present Message-Id: <168836167601.46386.17041701491443802315.b4-ty@ellerman.id.au> Date: Mon, 03 Jul 2023 15:21:16 +1000 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Darren Stevens , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, "R.T.Dickinson" , Christian Zigotzky Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Fri, 05 May 2023 12:18:17 -0500, Rob Herring wrote: > Commit e4ab08be5b49 ("powerpc/isa-bridge: Remove open coded "ranges" > parsing") broke PASemi Nemo board booting. The issue is the ISA I/O > range was not getting mapped as the logic to handle no "ranges" was > inverted. If phb_io_base_phys is non-zero, then the ISA range defaults > to the first 64K of the PCI I/O space. phb_io_base_phys should only be 0 > when looking for a non-PCI ISA region. > > [...] Applied to powerpc/fixes. [1/1] powerpc: isa-bridge: Fix ISA mmapping when "ranges" is not present https://git.kernel.org/powerpc/c/79de36042eecb684e0f748d17ba52f365fde0d65 cheers