All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Masami Hiramatsu (Google)" <mhiramat@kernel.org>
To: linux-trace-kernel@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
	Steven Rostedt <rostedt@goodmis.org>,
	mhiramat@kernel.org, Martin KaFai Lau <martin.lau@linux.dev>,
	bpf@vger.kernel.org, Sven Schnelle <svens@linux.ibm.com>,
	Alexei Starovoitov <ast@kernel.org>
Subject: [PATCH v2 1/9] tracing/probes: Fix to add NULL check for BTF APIs
Date: Tue, 18 Jul 2023 00:23:27 +0900	[thread overview]
Message-ID: <168960740754.34107.12202350138610653557.stgit@devnote2> (raw)
In-Reply-To: <168960739768.34107.15145201749042174448.stgit@devnote2>

From: Masami Hiramatsu (Google) <mhiramat@kernel.org>

Since find_btf_func_param() abd btf_type_by_id() can return NULL,
the caller must check the return value correctly.

Fixes: b576e09701c7 ("tracing/probes: Support function parameters if BTF is available")
Signed-off-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
---
 kernel/trace/trace_probe.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/kernel/trace/trace_probe.c b/kernel/trace/trace_probe.c
index b2b726bea1f9..c68a72707852 100644
--- a/kernel/trace/trace_probe.c
+++ b/kernel/trace/trace_probe.c
@@ -386,12 +386,12 @@ static const struct btf_type *find_btf_func_proto(const char *funcname)
 
 	/* Get BTF_KIND_FUNC type */
 	t = btf_type_by_id(btf, id);
-	if (!btf_type_is_func(t))
+	if (!t || !btf_type_is_func(t))
 		return ERR_PTR(-ENOENT);
 
 	/* The type of BTF_KIND_FUNC is BTF_KIND_FUNC_PROTO */
 	t = btf_type_by_id(btf, t->type);
-	if (!btf_type_is_func_proto(t))
+	if (!t || !btf_type_is_func_proto(t))
 		return ERR_PTR(-ENOENT);
 
 	return t;
@@ -443,7 +443,7 @@ static int parse_btf_arg(const char *varname, struct fetch_insn *code,
 	if (!ctx->params) {
 		params = find_btf_func_param(ctx->funcname, &ctx->nr_params,
 					     ctx->flags & TPARG_FL_TPOINT);
-		if (IS_ERR(params)) {
+		if (IS_ERR_OR_NULL(params)) {
 			trace_probe_log_err(ctx->offset, NO_BTF_ENTRY);
 			return PTR_ERR(params);
 		}
@@ -1273,7 +1273,7 @@ const char **traceprobe_expand_meta_args(int argc, const char *argv[],
 
 	params = find_btf_func_param(ctx->funcname, &nr_params,
 				     ctx->flags & TPARG_FL_TPOINT);
-	if (IS_ERR(params)) {
+	if (IS_ERR_OR_NULL(params)) {
 		if (args_idx != -1) {
 			/* $arg* requires BTF info */
 			trace_probe_log_err(0, NOSUP_BTFARG);


  reply	other threads:[~2023-07-17 15:24 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-17 15:23 [PATCH v2 0/9] tracing: Improbe BTF support on probe events Masami Hiramatsu (Google)
2023-07-17 15:23 ` Masami Hiramatsu (Google) [this message]
2023-07-17 15:23 ` [PATCH v2 2/9] bpf/btf: tracing: Move finding func-proto API and getting func-param API to BTF Masami Hiramatsu (Google)
2023-07-17 18:39   ` Steven Rostedt
2023-07-17 23:46     ` Masami Hiramatsu
2023-07-17 23:51       ` Alexei Starovoitov
2023-07-18  1:03         ` Masami Hiramatsu
2023-07-17 23:51       ` Steven Rostedt
2023-07-18  1:02         ` Masami Hiramatsu
2023-07-18  2:40   ` Donglin Peng
2023-07-18 10:44     ` Masami Hiramatsu
2023-07-18 13:56       ` Masami Hiramatsu
2023-07-18 17:11         ` Alexei Starovoitov
2023-07-18 23:03           ` Masami Hiramatsu
2023-07-18 23:12             ` Alexei Starovoitov
2023-07-19 15:17               ` Masami Hiramatsu
2023-07-19  2:09             ` Donglin Peng
2023-07-19 15:15               ` Masami Hiramatsu
2023-07-19 12:36   ` Alan Maguire
2023-07-19 15:24     ` Masami Hiramatsu
2023-07-19 15:49       ` Alan Maguire
2023-07-17 15:23 ` [PATCH v2 3/9] bpf/btf: Add a function to search a member of a struct/union Masami Hiramatsu (Google)
2023-07-20 22:34   ` Alan Maguire
2023-07-21 14:22     ` Masami Hiramatsu
2023-07-17 15:23 ` [PATCH v2 4/9] tracing/probes: Support BTF based data structure field access Masami Hiramatsu (Google)
2023-07-20 22:51   ` Alan Maguire
2023-07-21 14:22     ` Masami Hiramatsu
2023-07-17 15:24 ` [PATCH v2 5/9] tracing/probes: Support BTF field access from $retval Masami Hiramatsu (Google)
2023-07-17 15:24 ` [PATCH v2 6/9] tracing/probes: Add string type check with BTF Masami Hiramatsu (Google)
2023-07-17 15:24 ` [PATCH v2 7/9] tracing/fprobe-event: Assume fprobe is a return event by $retval Masami Hiramatsu (Google)
2023-07-17 15:24 ` [PATCH v2 8/9] selftests/ftrace: Add BTF fields access testcases Masami Hiramatsu (Google)
2023-07-20 23:00   ` Alan Maguire
2023-07-21  1:42     ` Masami Hiramatsu
2023-07-17 15:24 ` [PATCH v2 9/9] Documentation: tracing: Update fprobe event example with BTF field Masami Hiramatsu (Google)
2023-07-20 22:53   ` Alan Maguire
2023-07-21 13:58     ` Masami Hiramatsu
2023-07-19  9:02 ` [PATCH v2 0/9] tracing: Improbe BTF support on probe events Alan Maguire
2023-07-19 16:01   ` Masami Hiramatsu
2023-07-20 21:50     ` Alan Maguire
2023-07-25 23:45       ` Masami Hiramatsu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=168960740754.34107.12202350138610653557.stgit@devnote2 \
    --to=mhiramat@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=martin.lau@linux.dev \
    --cc=rostedt@goodmis.org \
    --cc=svens@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.