Re: [PATCH v7 1/1] dt-bindings: pinctrl: Update pinctrl-single to use yaml

[Rob Herring <robh@kernel.org>]

On Fri, 21 Jul 2023 11:26:49 +0300, Tony Lindgren wrote:
> Update binding for yaml and remove the old related txt bindings. Note that
> we are also adding the undocumented pinctrl-single,slew-rate property. And
> we only use the first example from the old binding.
> 
> As we are mostly using a generic compatible across various SoCs, let's not
> start adding matches for random pin group node naming. Let's standardize on
> pin group node name ending in -pins with an optional instance number
> suffix.
> 
> As a pin group may have additional pins added to it later on, let's always
> use -pins rather than -pin for the gropu name.
> 
> Most of the dts files have been updated already for the pin group node
> names with a few changes still pending.
> 
> Cc: Nishanth Menon <nm@ti.com>
> Cc: Vignesh Raghavendra <vigneshr@ti.com>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> ---
> 
> Changes since v6:
> - Avoid adding lots of matches and only accept nodes ending in -pins
>   with an optional suffix for instance number
> 
> - Update title to drop driver related stuff as noted by Krzysztof
> 
> Changes since v5:
> - Fix issues noted by Krzysztof
> 
> Changes since v4:
> - Removed legacy matching for pin group node names, let's fix the dts
>   files instead to use "pins" naming with dashes. This also fixed the
>   new warnings introduced for "not of type 'object'" for anything named
>   pin
> 
> Changes since v3:
> - Fix issues noted by Rob for v2 version that I had missed
> 
> - Categorize patternProperties a bit to make fixing dts files easier
> 
> Changes since v2:
> 
> - Drop old ti,omap-pinctrl.txt in addition to old pinctrl-single.txt
> 
> - Replace reference to pinctrl-single.txt to point to the yaml in ctrl.txt
> 
> Changes since v1:
> 
> - The v1 version was a WIP patch posted as an example in thread
>   "dt binding check error with hash and comma"
> 
> ---
>  .../devicetree/bindings/arm/omap/ctrl.txt     |   2 +-
>  .../bindings/pinctrl/pinctrl-single.txt       | 262 ------------------
>  .../bindings/pinctrl/pinctrl-single.yaml      | 206 ++++++++++++++
>  .../bindings/pinctrl/ti,omap-pinctrl.txt      |  13 -
>  4 files changed, 207 insertions(+), 276 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/pinctrl/pinctrl-single.txt
>  create mode 100644 Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml
>  delete mode 100644 Documentation/devicetree/bindings/pinctrl/ti,omap-pinctrl.txt
> 

Reviewed-by: Rob Herring <robh@kernel.org>