From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFB78EE498F for ; Fri, 18 Aug 2023 18:05:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379350AbjHRSEr (ORCPT ); Fri, 18 Aug 2023 14:04:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45078 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1379371AbjHRSEX (ORCPT ); Fri, 18 Aug 2023 14:04:23 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 765E82D70 for ; Fri, 18 Aug 2023 11:04:22 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 04DF567EFC for ; Fri, 18 Aug 2023 18:04:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 85097C433CC; Fri, 18 Aug 2023 18:04:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692381861; bh=P15k+ZGTnh3saf8KGpHE9eVH30ID/HlxHmNdojIcpx0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=vOJfCUsFtYqGREnA5GesxwE4BTL2LNH71u1NZ4aF2VXFru1FyM15kV4Tu9R7V2OA7 +/5uGTenGy+RpjW1x8bWlf3xyAPg1E0cIk9u2f17rDT8/lI3+ph3i/BZdVdjruhbz9 T7Vo2qKyfrTsdMeK0ed/TTP0h7pXr0m3/tOSTFDv7SvbZwilAs99mg0RcCeAT/VHp9 dCbi4phDlRELTY/WZe6fIj+iPlaW/2lY+6UZ/+OsmO95bJadtTyrGUBO3JRklSqm+s x9lCIb8BtSKASOt5HJqIVyw33vkF8OiHWvIYic/8z8Uw1Vr+8QSak6hf6gg8FzhqHk bZCzQuOgJAcDQ== From: Will Deacon To: Tomislav Novak , Catalin Marinas Cc: kernel-team@android.com, Will Deacon , Alexei Starovoitov , Russell King , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Mark Rutland , Samuel Gosselin Subject: Re: [PATCH v2] hw_breakpoint: fix single-stepping when using bpf_overflow_handler Date: Fri, 18 Aug 2023 19:04:10 +0100 Message-Id: <169237465034.1400900.4830514571452045431.b4-ty@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20230605191923.1219974-1-tnovak@meta.com> References: <20230605191923.1219974-1-tnovak@meta.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 5 Jun 2023 12:19:23 -0700, Tomislav Novak wrote: > Arm platforms use is_default_overflow_handler() to determine if the > hw_breakpoint code should single-step over the breakpoint trigger or > let the custom handler deal with it. > > Since bpf_overflow_handler() currently isn't recognized as a default > handler, attaching a BPF program to a PERF_TYPE_BREAKPOINT event causes > it to keep firing (the instruction triggering the data abort exception > is never skipped). For example: > > [...] Applied to will (for-next/perf), thanks! [1/1] hw_breakpoint: fix single-stepping when using bpf_overflow_handler https://git.kernel.org/will/c/d11a69873d9a Cheers, -- Will https://fixes.arm64.dev https://next.arm64.dev https://will.arm64.dev From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 55218EE498E for ; Fri, 18 Aug 2023 18:05:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KBrQrX80q8CDHlqrmTEgyuyEwOJxcdEI1UOl0rOaFxE=; b=RRvEaP6Gvph/W5 sMzrCIhCgyyOGPd/yGyK3Nny1VeoZAiALh7OYmB619w+09ktmqyVsfIJDovk/IY5B3IkHo114SW51 tbx0SHuAX1gIgeBgplb/GppprAx1aVJuzY/J5yZIbtXWucI8Hhw+pYNkTpjvezleo/6RuMfNBph9x cyAg8R1pEvo0/yZlyPebM/pf17gCP++P5LDh3Tta4s+uS5Xkuoo8dDjxZrKPOkJz0uTf64o3N9kN6 sXvL0Pbxh5CE3I7fH8bRFbQCpbU9kqIVr+JiRv0r3BTCkylz24a2LykXZdUZDY2RNsoY0JsPO5vkf BO3BWeCaiu/fJjFywxyA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qX3pl-009qTe-3D; Fri, 18 Aug 2023 18:04:30 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qX3pe-009qRr-26 for linux-arm-kernel@lists.infradead.org; Fri, 18 Aug 2023 18:04:24 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 07DF867F0F; Fri, 18 Aug 2023 18:04:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 85097C433CC; Fri, 18 Aug 2023 18:04:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692381861; bh=P15k+ZGTnh3saf8KGpHE9eVH30ID/HlxHmNdojIcpx0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=vOJfCUsFtYqGREnA5GesxwE4BTL2LNH71u1NZ4aF2VXFru1FyM15kV4Tu9R7V2OA7 +/5uGTenGy+RpjW1x8bWlf3xyAPg1E0cIk9u2f17rDT8/lI3+ph3i/BZdVdjruhbz9 T7Vo2qKyfrTsdMeK0ed/TTP0h7pXr0m3/tOSTFDv7SvbZwilAs99mg0RcCeAT/VHp9 dCbi4phDlRELTY/WZe6fIj+iPlaW/2lY+6UZ/+OsmO95bJadtTyrGUBO3JRklSqm+s x9lCIb8BtSKASOt5HJqIVyw33vkF8OiHWvIYic/8z8Uw1Vr+8QSak6hf6gg8FzhqHk bZCzQuOgJAcDQ== From: Will Deacon To: Tomislav Novak , Catalin Marinas Cc: kernel-team@android.com, Will Deacon , Alexei Starovoitov , Russell King , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Mark Rutland , Samuel Gosselin Subject: Re: [PATCH v2] hw_breakpoint: fix single-stepping when using bpf_overflow_handler Date: Fri, 18 Aug 2023 19:04:10 +0100 Message-Id: <169237465034.1400900.4830514571452045431.b4-ty@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20230605191923.1219974-1-tnovak@meta.com> References: <20230605191923.1219974-1-tnovak@meta.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230818_110422_731089_EEE9123E X-CRM114-Status: GOOD ( 11.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 5 Jun 2023 12:19:23 -0700, Tomislav Novak wrote: > Arm platforms use is_default_overflow_handler() to determine if the > hw_breakpoint code should single-step over the breakpoint trigger or > let the custom handler deal with it. > > Since bpf_overflow_handler() currently isn't recognized as a default > handler, attaching a BPF program to a PERF_TYPE_BREAKPOINT event causes > it to keep firing (the instruction triggering the data abort exception > is never skipped). For example: > > [...] Applied to will (for-next/perf), thanks! [1/1] hw_breakpoint: fix single-stepping when using bpf_overflow_handler https://git.kernel.org/will/c/d11a69873d9a Cheers, -- Will https://fixes.arm64.dev https://next.arm64.dev https://will.arm64.dev _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel