From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: linuxppc-dev@lists.ozlabs.org, Russell Currey <ruscur@russell.cc>
Cc: ajd@linux.ibm.com, Nageswara R Sastry <rnsastry@linux.ibm.com>
Subject: Re: [PATCH] powerpc/iommu: Fix notifiers being shared by PCI and VIO buses
Date: Thu, 31 Aug 2023 14:02:30 +1000 [thread overview]
Message-ID: <169345455029.11824.1206105586738991003.b4-ty@ellerman.id.au> (raw)
In-Reply-To: <20230322035322.328709-1-ruscur@russell.cc>
On Wed, 22 Mar 2023 14:53:22 +1100, Russell Currey wrote:
> fail_iommu_setup() registers the fail_iommu_bus_notifier struct to both
> PCI and VIO buses. struct notifier_block is a linked list node, so this
> causes any notifiers later registered to either bus type to also be
> registered to the other since they share the same node.
>
> This causes issues in (at least) the vgaarb code, which registers a
> notifier for PCI buses. pci_notify() ends up being called on a vio
> device, converted with to_pci_dev() even though it's not a PCI device,
> and finally makes a bad access in vga_arbiter_add_pci_device() as
> discovered with KASAN:
>
> [...]
Applied to powerpc/next.
[1/1] powerpc/iommu: Fix notifiers being shared by PCI and VIO buses
https://git.kernel.org/powerpc/c/c37b6908f7b2bd24dcaaf14a180e28c9132b9c58
cheers
prev parent reply other threads:[~2023-08-31 4:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-22 3:53 [PATCH] powerpc/iommu: Fix notifiers being shared by PCI and VIO buses Russell Currey
2023-03-22 6:18 ` Andrew Donnellan
2023-03-22 12:49 ` R Nageswara Sastry
2023-08-31 4:02 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=169345455029.11824.1206105586738991003.b4-ty@ellerman.id.au \
--to=patch-notifications@ellerman.id.au \
--cc=ajd@linux.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=rnsastry@linux.ibm.com \
--cc=ruscur@russell.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.