From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-stable] [PATCH] app/testpmd: fix dcb config
	failure
Date: Thu, 26 Jul 2018 19:18:20 +0200
Message-ID: <1694337.hYEmcJhZCz@xps>
References: <1532431954-123708-1-git-send-email-xiaoyun.li@intel.com>
 <8CEF83825BEC744B83065625E567D7C260CCF024@IRSMSX107.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>, "Wu,
 Jingjing" <jingjing.wu@intel.com>, "dev@dpdk.org" <dev@dpdk.org>,
 ferruh.yigit@intel.com
To: "Iremonger, Bernard" <bernard.iremonger@intel.com>, "Li,
 Xiaoyun" <xiaoyun.li@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 782B31C01
 for <dev@dpdk.org>; Thu, 26 Jul 2018 19:18:27 +0200 (CEST)
In-Reply-To: <8CEF83825BEC744B83065625E567D7C260CCF024@IRSMSX107.ger.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

> > After adding RSS hash offload check, default rss_hf will fail on devices that do
> > not support all bits. This will lead to dcb config failure. The patch fixes this
> > issue by taking rss_hf as a suggested value and only setting bits that the
> > device supports based on rte_eth_dev_get_info.
> > 
> > Fixes: 8863a1fbfc66 ("ethdev: add supported hash function check")
> > Fixes: 1a572499beb6 ("app/testpmd: setup DCB forwarding based on traffic
> > class")
> > Cc: stable@dpdk.org
> > 
> > Signed-off-by: Xiaoyun Li <xiaoyun.li@intel.com>
> 
> Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>

NACK

testpmd is a test application for developpers.
It must fail if the PMD cannot support user-requested features.

For other applications, there can be a smooth fallback
if and only if there are appropriate logs.
This is what Ferruh did for examples:
	http://git.dpdk.org/dpdk/commit/?id=4f5701f28bd