From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80C90C433FE for ; Wed, 8 Sep 2021 18:24:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 645CD60ED8 for ; Wed, 8 Sep 2021 18:24:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349814AbhIHS0A (ORCPT ); Wed, 8 Sep 2021 14:26:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57484 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233322AbhIHSZ6 (ORCPT ); Wed, 8 Sep 2021 14:25:58 -0400 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2110EC061575; Wed, 8 Sep 2021 11:24:50 -0700 (PDT) Received: by mail-wr1-x42a.google.com with SMTP id q26so4618606wrc.7; Wed, 08 Sep 2021 11:24:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=FlE0qMHbL5+xBmP2RU91kwGqsR+DkDaJdTbdBQ5TmKk=; b=o48JoJtHkBYjPAO44vHE1FRjZeflq+UFvLIUFRuK1vqw6gOsuLlMpBzWH0hQmIVvfw tF9Y96/la7KKN6+zBA6ax4Ptwrw4SDNMgMettvE9Xewh+Jge7x2+dN2VCE0Y/B2CpB4u jSnvc5EM21arIvJ0lM/RjaZ9qdGYyWkfR3IGocHrkDfYLo9zDn4gz/jX0l9/gpwAQ4Kk 22cbe+e5TZ3nKqT27XZsz58S27CoTClzbNejH4iIw7miZKyI1EaldbpTEfr2lOtgv+Gd pMoosNRfOEpLH814Y6XE/3mO1TNqqSL5yJMOWr79YNPgxyG3ulyjn3l4HasxK6OTlrjX DA4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=FlE0qMHbL5+xBmP2RU91kwGqsR+DkDaJdTbdBQ5TmKk=; b=ZLlTQQHmq405lgHEOrcYlrRIwt8RCRS/peSOax56bs66L4VZLaWegNxBD/YxEe3h5C 8PzjVvxCdRldLz98+U39DG8i71ruBtp5biuoLnpqf+PH9OAwVdVeabOwFXtajgxGpeFm nKdNrZNRr/e2fndxwX37YIU5Wgh+YpXkf9A37NXBl2kuwQgjyJSaF01cnmOuoaLiDuEU G1XP/HMQ6QZb3x+gCwok6C2uveF9Rn6eSBjKaBv/pU8Q7Xlvctf6NHXYLGZqseg8Xr7c SuYETTM4YiJT2F55i+rZUpxmfUYfKnor5wO6JfbwDCAiiSs5YbU/Tv4sck1IEH1cz0MP PWrA== X-Gm-Message-State: AOAM531mtzguiMG7QrUwUt7MmA/Q25gQ2CTyarrsBv8PtYzClWmSShch syMijsqKEdMKvJW4qc8UJlaHz5uw9a6xGQ== X-Google-Smtp-Source: ABdhPJwtC89X6xnx4xtVm673l7DLn0DTu6g4+HEMXMg8vrY94kM9EOD9wkdDHf52cV7Oh7FP9uExZg== X-Received: by 2002:adf:e606:: with SMTP id p6mr5619132wrm.231.1631125488779; Wed, 08 Sep 2021 11:24:48 -0700 (PDT) Received: from kista.localnet (cpe-86-58-29-253.static.triera.net. [86.58.29.253]) by smtp.gmail.com with ESMTPSA id s14sm2580837wmc.25.2021.09.08.11.24.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Sep 2021 11:24:48 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Yong Deng , Mauro Carvalho Chehab , Maxime Ripard , Chen-Yu Tsai , "open list:CSI DRIVERS FOR ALLWINNER V3s" , "moderated list:ARM/Allwinner sunXi SoC support" , "open list:ARM/Allwinner sunXi SoC support" , open list , Ondrej Jirman Cc: Ondrej Jirman Subject: Re: [PATCH] media: sun6i-csi: Allow the video device to be open multiple times Date: Wed, 08 Sep 2021 20:24:47 +0200 Message-ID: <1694867.cU3HQo44PE@kista> In-Reply-To: <20210908105609.1823449-1-megous@megous.com> References: <20210908105609.1823449-1-megous@megous.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Ondrej! Dne sreda, 08. september 2021 ob 12:56:09 CEST je Ondrej Jirman napisal(a): > Previously it was possible, but a recent fix for uninitialized > `ret` variable broke this behavior. > > v4l2_fh_is_singular_file() check is there just to determine > whether the power needs to be enabled, and it's not a failure > if it returns false. > > Fixes: ba9139116bc0538 ("media: sun6i-csi: add a missing return code") Only 12 characters for SHA-1 ID > Signed-off-by: Ondrej Jirman Otherwise: Reviewed-by: Jernej Skrabec Best regards, Jernej From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7383072 for ; Wed, 8 Sep 2021 18:24:50 +0000 (UTC) Received: by mail-wr1-f48.google.com with SMTP id q11so4626070wrr.9 for ; Wed, 08 Sep 2021 11:24:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=FlE0qMHbL5+xBmP2RU91kwGqsR+DkDaJdTbdBQ5TmKk=; b=o48JoJtHkBYjPAO44vHE1FRjZeflq+UFvLIUFRuK1vqw6gOsuLlMpBzWH0hQmIVvfw tF9Y96/la7KKN6+zBA6ax4Ptwrw4SDNMgMettvE9Xewh+Jge7x2+dN2VCE0Y/B2CpB4u jSnvc5EM21arIvJ0lM/RjaZ9qdGYyWkfR3IGocHrkDfYLo9zDn4gz/jX0l9/gpwAQ4Kk 22cbe+e5TZ3nKqT27XZsz58S27CoTClzbNejH4iIw7miZKyI1EaldbpTEfr2lOtgv+Gd pMoosNRfOEpLH814Y6XE/3mO1TNqqSL5yJMOWr79YNPgxyG3ulyjn3l4HasxK6OTlrjX DA4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=FlE0qMHbL5+xBmP2RU91kwGqsR+DkDaJdTbdBQ5TmKk=; b=M1ThBwddC64ya7qbMUsTvtl0yRk5e+qfQgoJRKUNdfFP0QmqIqXiGMVU+vfRPak+vy b22FGXK6L19Ov2ZNSH4YPl34ddofZBmPu1l54f2Au/EsKPaHgpv4ZdUFWKD1syMyC1Ei SKG3QWWIXszDMK9RdYs3pHiBOBZSbN5XrTsGB5KIyIj+1pi+EoSVOnHg4XamPWQcWFTZ cHMYSbRcYgCo8tqfW3A/jCIOMO8yl808qqfnMuWHV3QUICHwihxuW83mZK7I3zWKy/Iv 00PEQUmBi88JjiWPB7ez+Ew4SbiqTgpSHrlWV6ZH309NIGjkkgJFeCWdX9wYeioFCboj c69w== X-Gm-Message-State: AOAM532lkxBjqo4bqVp+hIM/pcNCex/yuO5GLRZZoQI6R2g5+iCMWfZr mPpCH6CMwqPkq9eN9NrULQg= X-Google-Smtp-Source: ABdhPJwtC89X6xnx4xtVm673l7DLn0DTu6g4+HEMXMg8vrY94kM9EOD9wkdDHf52cV7Oh7FP9uExZg== X-Received: by 2002:adf:e606:: with SMTP id p6mr5619132wrm.231.1631125488779; Wed, 08 Sep 2021 11:24:48 -0700 (PDT) Received: from kista.localnet (cpe-86-58-29-253.static.triera.net. [86.58.29.253]) by smtp.gmail.com with ESMTPSA id s14sm2580837wmc.25.2021.09.08.11.24.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Sep 2021 11:24:48 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Yong Deng , Mauro Carvalho Chehab , Maxime Ripard , Chen-Yu Tsai , "open list:CSI DRIVERS FOR ALLWINNER V3s" , "moderated list:ARM/Allwinner sunXi SoC support" , "open list:ARM/Allwinner sunXi SoC support" , open list , Ondrej Jirman Cc: Ondrej Jirman Subject: Re: [PATCH] media: sun6i-csi: Allow the video device to be open multiple times Date: Wed, 08 Sep 2021 20:24:47 +0200 Message-ID: <1694867.cU3HQo44PE@kista> In-Reply-To: <20210908105609.1823449-1-megous@megous.com> References: <20210908105609.1823449-1-megous@megous.com> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Hi Ondrej! Dne sreda, 08. september 2021 ob 12:56:09 CEST je Ondrej Jirman napisal(a): > Previously it was possible, but a recent fix for uninitialized > `ret` variable broke this behavior. > > v4l2_fh_is_singular_file() check is there just to determine > whether the power needs to be enabled, and it's not a failure > if it returns false. > > Fixes: ba9139116bc0538 ("media: sun6i-csi: add a missing return code") Only 12 characters for SHA-1 ID > Signed-off-by: Ondrej Jirman Otherwise: Reviewed-by: Jernej Skrabec Best regards, Jernej From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A999BC433FE for ; Wed, 8 Sep 2021 18:26:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7BD0261078 for ; Wed, 8 Sep 2021 18:26:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7BD0261078 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=eseas8ildMx85UE2WG0j1k2voJ9NsodIiCZbserjMXE=; b=F+lvXXOU7iNPzc EsV5qaXQns5Utq36hKnltP1UPj8+JgmfmyI9Qj2kTShwU6e9kbtftolJwJbK+Ne18m28eOW5TVDxp slWNEWgXe4RNlLXcbfHXLyiClNtx88k9DX0fxqnlTZ+pDdaY7DDsrj8q9jWB8MGZUBzHT5KdHhiIu j/5imc1cJdD+I4pKq7TkjZ/ZE0DPm1VID33P/eq9uKJIuhrMyYswlz940KORikiccvK/NPnXq7lsa w+EZ7xlC2mILa/FlzK6+zpEmO8oG84qNQbE4K41F52qQiq3EborlJD7yIGlBSnCLe4iuH/xPh0NEp LWijSG+PLKcVtV/twdlA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mO2Fk-007Oro-Sd; Wed, 08 Sep 2021 18:24:57 +0000 Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mO2Fg-007Oqv-Qx for linux-arm-kernel@lists.infradead.org; Wed, 08 Sep 2021 18:24:54 +0000 Received: by mail-wr1-x435.google.com with SMTP id u16so4645992wrn.5 for ; Wed, 08 Sep 2021 11:24:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=FlE0qMHbL5+xBmP2RU91kwGqsR+DkDaJdTbdBQ5TmKk=; b=o48JoJtHkBYjPAO44vHE1FRjZeflq+UFvLIUFRuK1vqw6gOsuLlMpBzWH0hQmIVvfw tF9Y96/la7KKN6+zBA6ax4Ptwrw4SDNMgMettvE9Xewh+Jge7x2+dN2VCE0Y/B2CpB4u jSnvc5EM21arIvJ0lM/RjaZ9qdGYyWkfR3IGocHrkDfYLo9zDn4gz/jX0l9/gpwAQ4Kk 22cbe+e5TZ3nKqT27XZsz58S27CoTClzbNejH4iIw7miZKyI1EaldbpTEfr2lOtgv+Gd pMoosNRfOEpLH814Y6XE/3mO1TNqqSL5yJMOWr79YNPgxyG3ulyjn3l4HasxK6OTlrjX DA4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=FlE0qMHbL5+xBmP2RU91kwGqsR+DkDaJdTbdBQ5TmKk=; b=2t+I6yYL+wyUAohW7cohsz/RK+0P3jXfPkF45HVcmFgYGzuYdtde84XB3J1h2y2QzE 7xz8L9/LxJsenHlr8vqikzRC6UT7BkRpUIaZWWVmivT/6TtxuVLEl0j2s2VhBCmw0YSe 5Y8rPZKz4Pkhk85KkKcGzjCA4s1XB3n2ON1/fnAd0iyNaS+SMlzARY1YMYdlxxmty/CY EaM90F/eJ7ZU5X7h8SiYJesJSulLGvkrG+j1Vkz/ZxbQlqbEr5qvwdmRDkurj8eOVt+/ Dr8tx3Crxgzrz2j79CsBguVVkV3u5A1BsiYjvhXVPQtwAW9Rl6SaDQXARVial15qm8oT aNmA== X-Gm-Message-State: AOAM5310z9TbKMFYYY1Hoz2nig0WmPN8iugz3VF2i3B7MXppxY7W3pCh XSuCQWoi98UeInEKd5gMTjo= X-Google-Smtp-Source: ABdhPJwtC89X6xnx4xtVm673l7DLn0DTu6g4+HEMXMg8vrY94kM9EOD9wkdDHf52cV7Oh7FP9uExZg== X-Received: by 2002:adf:e606:: with SMTP id p6mr5619132wrm.231.1631125488779; Wed, 08 Sep 2021 11:24:48 -0700 (PDT) Received: from kista.localnet (cpe-86-58-29-253.static.triera.net. [86.58.29.253]) by smtp.gmail.com with ESMTPSA id s14sm2580837wmc.25.2021.09.08.11.24.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Sep 2021 11:24:48 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Yong Deng , Mauro Carvalho Chehab , Maxime Ripard , Chen-Yu Tsai , "open list:CSI DRIVERS FOR ALLWINNER V3s" , "moderated list:ARM/Allwinner sunXi SoC support" , "open list:ARM/Allwinner sunXi SoC support" , open list , Ondrej Jirman Cc: Ondrej Jirman Subject: Re: [PATCH] media: sun6i-csi: Allow the video device to be open multiple times Date: Wed, 08 Sep 2021 20:24:47 +0200 Message-ID: <1694867.cU3HQo44PE@kista> In-Reply-To: <20210908105609.1823449-1-megous@megous.com> References: <20210908105609.1823449-1-megous@megous.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210908_112452_903582_34E418F5 X-CRM114-Status: GOOD ( 11.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Ondrej! Dne sreda, 08. september 2021 ob 12:56:09 CEST je Ondrej Jirman napisal(a): > Previously it was possible, but a recent fix for uninitialized > `ret` variable broke this behavior. > > v4l2_fh_is_singular_file() check is there just to determine > whether the power needs to be enabled, and it's not a failure > if it returns false. > > Fixes: ba9139116bc0538 ("media: sun6i-csi: add a missing return code") Only 12 characters for SHA-1 ID > Signed-off-by: Ondrej Jirman Otherwise: Reviewed-by: Jernej Skrabec Best regards, Jernej _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel