From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750922AbdE3TcG (ORCPT ); Tue, 30 May 2017 15:32:06 -0400 Received: from mout.gmx.net ([212.227.17.21]:59665 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750761AbdE3TcF (ORCPT ); Tue, 30 May 2017 15:32:05 -0400 Subject: Re: [tip:x86/urgent] x86/PAT: Fix Xorg regression on CPUs that don't support PAT To: Mikulas Patocka , Dominik Brodowski Cc: Andy Lutomirski , Toshi Kani , Borislav Petkov , Andrew Morton , Brian Gerst , Linus Torvalds , "H. Peter Anvin" , Ingo Molnar , Thomas Gleixner , Peter Zijlstra , "Luis R. Rodriguez" , Denys Vlasenko , Josh Poimboeuf , "linux-kernel@vger.kernel.org" References: <3d69fb9d-651a-8266-8e00-789fedd74659@gmx.de> <20170530171440.GA1599@light.dominikbrodowski.net> From: Bernhard Held Message-ID: <169741b1-3038-3d8b-6d61-462f1e9f7082@gmx.de> Date: Tue, 30 May 2017 21:30:07 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: de-DE Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:3RAToy1DZnnV7mx2h7kIGWfC18K5qRGla/PTKS/xfpJhI9EyfOS wTTgsbJudSnrpkEObV1pyPiv7fdQ8Bb7FTvJ7jEXyakrUb+F3R8Z1HkKGCA1Z2tcxrpniwS wzJ1WIWVV5GCGX9Q6Ezxh6lpUZRXxiRH7pGSJWMQqw+wrggOjnqghrG9MmrESZVbrR99cVy C0QWW0sN+BXNVQZKLqt6Q== X-UI-Out-Filterresults: notjunk:1;V01:K0:6yG6y4NmSaU=:Xf1vPofQARoc/iXixSwoH+ 0n34Zej5SZwslFL7X3TzhaT1CEwulO7nE/3Sph+4UVcmDNm+YQOzfuVsC2OkBpwKGnoQ0P3N8 C6XWoPxGxziCTzRZ5LkYwJ6jt2yBgubCNEb1D2E86MzUTET9/kotRYamDedSu9G+HC0WJt9f+ 5V8jUb8U7deiEUdXmNo5N/fls8r+WBZWquvz96JqDMNwzXHHEHV8WieXNWaerMbi0P9Y36xCH mmMTHgApp18dtcFrs/igAsBSmpQXceWtqcSOzawpCz6/af1zhT4aXRv2ycpy0hjW1162WKXeb 6sTpDqJozryUjG7Lj5x+XRj7TusZF4CpfNgzuwpOzs6EmRiezF+na5hEENvbek+m7OG06I/VZ QQ04ZoKZJrMULplPQIl1utYeqs3/2VqwmmdxV8U4D9PAtllE+dWq6zoNBNlzF0k+63wt6ahUn oI34VsWq9zrEdDZ08iE5fr+rABWbYp+0wwvmIYuN4RBxdRZcqS1Glhm6yZLJIK43LHddbDejX eKUw1KDHp/TgQugFBPFTtPsAkvIjyeapU10IsGXXm+1lc8PuMU0ucYOkcwPiVNuMXDYkfI8vK fVxdJAWrDJGS7lBID65vvL99mmI/oxWJF/Zf7k/vm1RcopLMH23kZIXbBiV3XHGtaV4hvXWq4 mPaoTV9nvjoIr+Zpm9+YbI+cri7VurvGh4mcRH7lhwkpMcy/rTWCjw8fFHQ58PEQrktj4hrq5 Z41+VGv/SaB/BedxSr16nhCUEGhykVk4pknmCYBkd6sr9wKWh11hyL5AtG49COXkOzOOVpJus riQSe1m Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/30/2017 at 07:59 PM, Mikulas Patocka wrote: > > > On Tue, 30 May 2017, Dominik Brodowski wrote: > >> Same boot problem here (Intel(R) Core(TM) i5-5200U CPU on a Dell XPS 13), >> git-bisected to the same patch... >> >> On Mon, May 29, 2017 at 06:50:57PM -0400, Mikulas Patocka wrote: >>> Please do the following three tests and test if the kernel boots. >>> >>> 1. use the PAT patch and revert the change to the function pat_enabled() >>> - i.e. change it to the original: >>> bool pat_enabled(void) >>> { >>> return !!__pat_enabled; >>> } >> >> No joy. >> >>> 2. use the PAT patch and revert the change to the function pat_ap_init >>> - i.e. change it to the original: >>> static void pat_ap_init(u64 pat) >>> { >>> if (!boot_cpu_has(X86_FEATURE_PAT)) { >> >> Joy. > > It is interesting - does it mean that the boot cpu does have PAT and the > secondary CPUs don't? Please send /proc/cpuinfo with all the cores active. > > This part of the patch is not required anyway, so I will resubmit the > patch with this part disabled (and with an added call to > init_cache_modes() as Andy suggested). > > Mikulas > >>> 3. use the full PAT patch and apply the below patch on the top of it. >> >> No joy. Same result here., only #2 boots. processor : 0 vendor_id : GenuineIntel cpu family : 6 model : 23 model name : Intel(R) Xeon(R) CPU E5450 @ 3.00GHz stepping : 10 microcode : 0xa0b cpu MHz : 2000.000 cache size : 6144 KB physical id : 0 siblings : 4 core id : 0 cpu cores : 4 apicid : 0 initial apicid : 0 fpu : yes fpu_exception : yes cpuid level : 13 wp : yes flags : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx lm constant_tsc arch_perfmon pebs bts rep_good nopl cpuid aperfmperf pni dtes64 monitor ds_cpl vmx est tm2 ssse3 cx16 xtpr pdcm dca sse4_1 xsave lahf_lm tpr_shadow vnmi flexpriority dtherm bugs : bogomips : 5999.70 clflush size : 64 cache_alignment : 64 address sizes : 38 bits physical, 48 bits virtual power management: processor : 1 vendor_id : GenuineIntel cpu family : 6 model : 23 model name : Intel(R) Xeon(R) CPU E5450 @ 3.00GHz stepping : 10 microcode : 0xa0b cpu MHz : 2000.000 cache size : 6144 KB physical id : 0 siblings : 4 core id : 3 cpu cores : 4 apicid : 3 initial apicid : 3 fpu : yes fpu_exception : yes cpuid level : 13 wp : yes flags : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx lm constant_tsc arch_perfmon pebs bts rep_good nopl cpuid aperfmperf pni dtes64 monitor ds_cpl vmx est tm2 ssse3 cx16 xtpr pdcm dca sse4_1 xsave lahf_lm tpr_shadow vnmi flexpriority dtherm bugs : bogomips : 5999.98 clflush size : 64 cache_alignment : 64 address sizes : 38 bits physical, 48 bits virtual power management: processor : 2 vendor_id : GenuineIntel cpu family : 6 model : 23 model name : Intel(R) Xeon(R) CPU E5450 @ 3.00GHz stepping : 10 microcode : 0xa0b cpu MHz : 2000.000 cache size : 6144 KB physical id : 0 siblings : 4 core id : 2 cpu cores : 4 apicid : 2 initial apicid : 2 fpu : yes fpu_exception : yes cpuid level : 13 wp : yes flags : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx lm constant_tsc arch_perfmon pebs bts rep_good nopl cpuid aperfmperf pni dtes64 monitor ds_cpl vmx est tm2 ssse3 cx16 xtpr pdcm dca sse4_1 xsave lahf_lm tpr_shadow vnmi flexpriority dtherm bugs : bogomips : 5900.00 clflush size : 64 cache_alignment : 64 address sizes : 38 bits physical, 48 bits virtual power management: processor : 3 vendor_id : GenuineIntel cpu family : 6 model : 23 model name : Intel(R) Xeon(R) CPU E5450 @ 3.00GHz stepping : 10 microcode : 0xa0b cpu MHz : 2000.000 cache size : 6144 KB physical id : 0 siblings : 4 core id : 1 cpu cores : 4 apicid : 1 initial apicid : 1 fpu : yes fpu_exception : yes cpuid level : 13 wp : yes flags : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx lm constant_tsc arch_perfmon pebs bts rep_good nopl cpuid aperfmperf pni dtes64 monitor ds_cpl vmx est tm2 ssse3 cx16 xtpr pdcm dca sse4_1 xsave lahf_lm tpr_shadow vnmi flexpriority dtherm bugs : bogomips : 5999.98 clflush size : 64 cache_alignment : 64 address sizes : 38 bits physical, 48 bits virtual power management: Cheers, Bernhard