From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751518AbeBWIgJ (ORCPT ); Fri, 23 Feb 2018 03:36:09 -0500 Received: from szxga01-in.huawei.com ([45.249.212.187]:5892 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750796AbeBWIgH (ORCPT ); Fri, 23 Feb 2018 03:36:07 -0500 From: "liwei (CM)" To: Arnd Bergmann CC: Rob Herring , Mark Rutland , "xuwei (O)" , Catalin Marinas , Will Deacon , Vinayak Holikatti , "James E.J. Bottomley" , "Martin K. Petersen" , Kevin Hilman , Gregory CLEMENT , Thomas Petazzoni , Masahiro Yamada , Riku Voipio , Thierry Reding , Krzysztof Kozlowski , DTML , Linux Kernel Mailing List , Linux ARM , linux-scsi , zangleigang , Gengjianfeng , Guodong Xu , Zhangfei Gao , "Fengbaopeng (kevin, Kirin Solution Dept)" Subject: =?utf-8?B?562U5aSNOiBbUEFUQ0ggdjggMi81XSBkdC1iaW5kaW5nczogc2NzaTogdWZz?= =?utf-8?Q?:_add_document_for_hisi-ufs?= Thread-Topic: [PATCH v8 2/5] dt-bindings: scsi: ufs: add document for hisi-ufs Thread-Index: AQHTpLNt7xq76dhVgkeSgBp0Vy2vQaOrAJgAgAauIaA= Date: Fri, 23 Feb 2018 08:35:54 +0000 Message-ID: <1699CE87DE933F49876AD744B5DC140FA56267@DGGEMM506-MBS.china.huawei.com> References: <20180213101412.5717-1-liwei213@huawei.com> <20180213101412.5717-3-liwei213@huawei.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.189.155.72] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id w1N8aCxb012519 Hi, Arnd Sorry late for you. The following two suggestions we have really discussed https://lkml.org/lkml/2017/11/30/1077 -----邮件原件----- 发件人: arndbergmann@gmail.com [mailto:arndbergmann@gmail.com] 代表 Arnd Bergmann 发送时间: 2018年2月19日 17:58 收件人: liwei (CM) 抄送: Rob Herring; Mark Rutland; xuwei (O); Catalin Marinas; Will Deacon; Vinayak Holikatti; James E.J. Bottomley; Martin K. Petersen; Kevin Hilman; Gregory CLEMENT; Thomas Petazzoni; Masahiro Yamada; Riku Voipio; Thierry Reding; Krzysztof Kozlowski; Eric Anholt; DTML; Linux Kernel Mailing List; Linux ARM; linux-scsi; zangleigang; Gengjianfeng; Guodong Xu; Zhangfei Gao; Fengbaopeng (kevin, Kirin Solution Dept) 主题: Re: [PATCH v8 2/5] dt-bindings: scsi: ufs: add document for hisi-ufs On Tue, Feb 13, 2018 at 11:14 AM, Li Wei wrote: > add ufs node document for Hisilicon. > > Signed-off-by: Li Wei > --- > Documentation/devicetree/bindings/ufs/ufs-hisi.txt | 37 > ++++++++++++++++++++++ > 1 file changed, 37 insertions(+) > create mode 100644 Documentation/devicetree/bindings/ufs/ufs-hisi.txt I'm pretty sure we've discussed it before, but can you make this so that the generic properties are part of the ufshcd binding, and you refer to it from here, only describing in what ways the hisi ufs binding differs from the standard? > diff --git a/Documentation/devicetree/bindings/ufs/ufs-hisi.txt > b/Documentation/devicetree/bindings/ufs/ufs-hisi.txt > new file mode 100644 > index 000000000000..0d21b57496cf > --- /dev/null > +++ b/Documentation/devicetree/bindings/ufs/ufs-hisi.txt > @@ -0,0 +1,37 @@ > +* Hisilicon Universal Flash Storage (UFS) Host Controller > + > +UFS nodes are defined to describe on-chip UFS hardware macro. > +Each UFS Host Controller should have its own node. > + > +Required properties: > +- compatible : compatible list, contains one of the following - > + "hisilicon,hi3660-ufs", "jedec,ufs-1.1" for hisi ufs > + host controller present on Hi36xx chipset. > +- reg : should contain UFS register address space & UFS SYS CTRL register address, > +- interrupt-parent : interrupt device > +- interrupts : interrupt number > +- clocks : List of phandle and clock specifier pairs > +- clock-names : List of clock input name strings sorted in the same > + order as the clocks property. > +"ref_clk", "phy_clk" is optional The clock names sound generic enough, should we have both in the generic binding? "ref_clk" is in the ufshcd-pltfrm binding, but "phy_clk" is not; what do you mean is that these two don't need to document here? > +- resets : reset node register, one reset the clk and the other reset the controller > +- reset-names : describe reset node register This looks incomplete. What is the name of the reset line supposed to be? I'd also suggest you document it in the ufshcd binding instead. As discussed in https://lkml.org/lkml/2017/11/30/1077; If document it in the ufshcd binding, I think it needs some codes to parse them in ufshcd.c/ufshcd-pltfrm.c, but I think these codes may not be applicable to other SOC manufacturers. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: "liwei (CM)" Subject: =?utf-8?B?562U5aSNOiBbUEFUQ0ggdjggMi81XSBkdC1iaW5kaW5nczogc2NzaTogdWZz?= =?utf-8?Q?:_add_document_for_hisi-ufs?= Date: Fri, 23 Feb 2018 08:35:54 +0000 Message-ID: <1699CE87DE933F49876AD744B5DC140FA56267@DGGEMM506-MBS.china.huawei.com> References: <20180213101412.5717-1-liwei213@huawei.com> <20180213101412.5717-3-liwei213@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: Content-Language: zh-CN List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Arnd Bergmann Cc: Mark Rutland , Catalin Marinas , Will Deacon , Masahiro Yamada , "xuwei (O)" , Vinayak Holikatti , "James E.J. Bottomley" , linux-scsi , Kevin Hilman , zangleigang , Krzysztof Kozlowski , Zhangfei Gao , Thierry Reding , DTML , "Fengbaopeng (kevin, Kirin Solution Dept)" , Rob Herring , Gregory CLEMENT , Linux ARM , Thomas Petazzoni , Guodong Xu , Martin K. Pet List-Id: devicetree@vger.kernel.org SGksIEFybmQNCg0KU29ycnkgbGF0ZSBmb3IgeW91Lg0KVGhlIGZvbGxvd2luZyB0d28gc3VnZ2Vz dGlvbnMgd2UgaGF2ZSByZWFsbHkgZGlzY3Vzc2VkDQpodHRwczovL2xrbWwub3JnL2xrbWwvMjAx Ny8xMS8zMC8xMDc3DQoNCi0tLS0t6YKu5Lu25Y6f5Lu2LS0tLS0NCuWPkeS7tuS6ujogYXJuZGJl cmdtYW5uQGdtYWlsLmNvbSBbbWFpbHRvOmFybmRiZXJnbWFubkBnbWFpbC5jb21dIOS7o+ihqCBB cm5kIEJlcmdtYW5uDQrlj5HpgIHml7bpl7Q6IDIwMTjlubQy5pyIMTnml6UgMTc6NTgNCuaUtuS7 tuS6ujogbGl3ZWkgKENNKQ0K5oqE6YCBOiBSb2IgSGVycmluZzsgTWFyayBSdXRsYW5kOyB4dXdl aSAoTyk7IENhdGFsaW4gTWFyaW5hczsgV2lsbCBEZWFjb247IFZpbmF5YWsgSG9saWthdHRpOyBK YW1lcyBFLkouIEJvdHRvbWxleTsgTWFydGluIEsuIFBldGVyc2VuOyBLZXZpbiBIaWxtYW47IEdy ZWdvcnkgQ0xFTUVOVDsgVGhvbWFzIFBldGF6em9uaTsgTWFzYWhpcm8gWWFtYWRhOyBSaWt1IFZv aXBpbzsgVGhpZXJyeSBSZWRpbmc7IEtyenlzenRvZiBLb3psb3dza2k7IEVyaWMgQW5ob2x0OyBE VE1MOyBMaW51eCBLZXJuZWwgTWFpbGluZyBMaXN0OyBMaW51eCBBUk07IGxpbnV4LXNjc2k7IHph bmdsZWlnYW5nOyBHZW5namlhbmZlbmc7IEd1b2RvbmcgWHU7IFpoYW5nZmVpIEdhbzsgRmVuZ2Jh b3BlbmcgKGtldmluLCBLaXJpbiBTb2x1dGlvbiBEZXB0KQ0K5Li76aKYOiBSZTogW1BBVENIIHY4 IDIvNV0gZHQtYmluZGluZ3M6IHNjc2k6IHVmczogYWRkIGRvY3VtZW50IGZvciBoaXNpLXVmcw0K DQpPbiBUdWUsIEZlYiAxMywgMjAxOCBhdCAxMToxNCBBTSwgTGkgV2VpIDxsaXdlaTIxM0BodWF3 ZWkuY29tPiB3cm90ZToNCj4gYWRkIHVmcyBub2RlIGRvY3VtZW50IGZvciBIaXNpbGljb24uDQo+ DQo+IFNpZ25lZC1vZmYtYnk6IExpIFdlaSA8bGl3ZWkyMTNAaHVhd2VpLmNvbT4NCj4gLS0tDQo+ ICBEb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvdWZzL3Vmcy1oaXNpLnR4dCB8IDM3 IA0KPiArKysrKysrKysrKysrKysrKysrKysrDQo+ICAxIGZpbGUgY2hhbmdlZCwgMzcgaW5zZXJ0 aW9ucygrKQ0KPiAgY3JlYXRlIG1vZGUgMTAwNjQ0IERvY3VtZW50YXRpb24vZGV2aWNldHJlZS9i aW5kaW5ncy91ZnMvdWZzLWhpc2kudHh0DQoNCg0KSSdtIHByZXR0eSBzdXJlIHdlJ3ZlIGRpc2N1 c3NlZCBpdCBiZWZvcmUsIGJ1dCBjYW4geW91IG1ha2UgdGhpcyBzbyB0aGF0IHRoZSBnZW5lcmlj IHByb3BlcnRpZXMgYXJlIHBhcnQgb2YgdGhlIHVmc2hjZCBiaW5kaW5nLCBhbmQgeW91IHJlZmVy IHRvIGl0IGZyb20gaGVyZSwgb25seSBkZXNjcmliaW5nIGluIHdoYXQgd2F5cyB0aGUgaGlzaSB1 ZnMgYmluZGluZyBkaWZmZXJzIGZyb20gdGhlIHN0YW5kYXJkPw0KDQo+IGRpZmYgLS1naXQgYS9E b2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvdWZzL3Vmcy1oaXNpLnR4dCANCj4gYi9E b2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvdWZzL3Vmcy1oaXNpLnR4dA0KPiBuZXcg ZmlsZSBtb2RlIDEwMDY0NA0KPiBpbmRleCAwMDAwMDAwMDAwMDAuLjBkMjFiNTc0OTZjZg0KPiAt LS0gL2Rldi9udWxsDQo+ICsrKyBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy91 ZnMvdWZzLWhpc2kudHh0DQo+IEBAIC0wLDAgKzEsMzcgQEANCj4gKyogSGlzaWxpY29uIFVuaXZl cnNhbCBGbGFzaCBTdG9yYWdlIChVRlMpIEhvc3QgQ29udHJvbGxlcg0KPiArDQo+ICtVRlMgbm9k ZXMgYXJlIGRlZmluZWQgdG8gZGVzY3JpYmUgb24tY2hpcCBVRlMgaGFyZHdhcmUgbWFjcm8uDQo+ ICtFYWNoIFVGUyBIb3N0IENvbnRyb2xsZXIgc2hvdWxkIGhhdmUgaXRzIG93biBub2RlLg0KPiAr DQo+ICtSZXF1aXJlZCBwcm9wZXJ0aWVzOg0KPiArLSBjb21wYXRpYmxlICAgICAgICA6IGNvbXBh dGlibGUgbGlzdCwgY29udGFpbnMgb25lIG9mIHRoZSBmb2xsb3dpbmcgLQ0KPiArICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgImhpc2lsaWNvbixoaTM2NjAtdWZzIiwgImpl ZGVjLHVmcy0xLjEiIGZvciBoaXNpIHVmcw0KPiArICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgaG9zdCBjb250cm9sbGVyIHByZXNlbnQgb24gSGkzNnh4IGNoaXBzZXQuDQo+ ICstIHJlZyAgICAgICAgICAgICAgIDogc2hvdWxkIGNvbnRhaW4gVUZTIHJlZ2lzdGVyIGFkZHJl c3Mgc3BhY2UgJiBVRlMgU1lTIENUUkwgcmVnaXN0ZXIgYWRkcmVzcywNCj4gKy0gaW50ZXJydXB0 LXBhcmVudCAgOiBpbnRlcnJ1cHQgZGV2aWNlDQo+ICstIGludGVycnVwdHMgICAgICAgIDogaW50 ZXJydXB0IG51bWJlcg0KPiArLSBjbG9ja3MgICAgICAgICAgICAgICA6IExpc3Qgb2YgcGhhbmRs ZSBhbmQgY2xvY2sgc3BlY2lmaWVyIHBhaXJzDQo+ICstIGNsb2NrLW5hbWVzICAgICAgIDogTGlz dCBvZiBjbG9jayBpbnB1dCBuYW1lIHN0cmluZ3Mgc29ydGVkIGluIHRoZSBzYW1lDQo+ICsgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBvcmRlciBhcyB0aGUgY2xvY2tzIHBy b3BlcnR5LiANCj4gKyJyZWZfY2xrIiwgInBoeV9jbGsiIGlzIG9wdGlvbmFsDQoNClRoZSBjbG9j ayBuYW1lcyBzb3VuZCBnZW5lcmljIGVub3VnaCwgc2hvdWxkIHdlIGhhdmUgYm90aCBpbiB0aGUg Z2VuZXJpYyBiaW5kaW5nPw0KDQoicmVmX2NsayIgaXMgaW4gdGhlIHVmc2hjZC1wbHRmcm0gYmlu ZGluZywgYnV0ICJwaHlfY2xrIiBpcyBub3Q7IHdoYXQgZG8geW91IG1lYW4gaXMgdGhhdCB0aGVz ZSB0d28gZG9uJ3QgbmVlZCB0byBkb2N1bWVudCBoZXJlPw0KDQo+ICstIHJlc2V0cyAgICAgICAg ICAgIDogcmVzZXQgbm9kZSByZWdpc3Rlciwgb25lIHJlc2V0IHRoZSBjbGsgYW5kIHRoZSBvdGhl ciByZXNldCB0aGUgY29udHJvbGxlcg0KPiArLSByZXNldC1uYW1lcyAgICAgICA6IGRlc2NyaWJl IHJlc2V0IG5vZGUgcmVnaXN0ZXINCg0KVGhpcyBsb29rcyBpbmNvbXBsZXRlLiBXaGF0IGlzIHRo ZSBuYW1lIG9mIHRoZSByZXNldCBsaW5lIHN1cHBvc2VkIHRvIGJlPw0KSSdkIGFsc28gc3VnZ2Vz dCB5b3UgZG9jdW1lbnQgaXQgaW4gdGhlIHVmc2hjZCBiaW5kaW5nIGluc3RlYWQuDQoNCkFzIGRp c2N1c3NlZCBpbiBodHRwczovL2xrbWwub3JnL2xrbWwvMjAxNy8xMS8zMC8xMDc3Ow0KSWYgZG9j dW1lbnQgaXQgaW4gdGhlIHVmc2hjZCBiaW5kaW5nLCBJIHRoaW5rIGl0IG5lZWRzIHNvbWUgY29k ZXMgdG8gcGFyc2UgdGhlbSBpbiB1ZnNoY2QuYy91ZnNoY2QtcGx0ZnJtLmMsIGJ1dCBJIHRoaW5r IHRoZXNlIGNvZGVzIG1heSBub3QgYmUgYXBwbGljYWJsZSB0byBvdGhlciBTT0MgbWFudWZhY3R1 cmVycy4NCg0KICAgICAgQXJuZA0KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5l bEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4v bGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: liwei213@huawei.com (liwei (CM)) Date: Fri, 23 Feb 2018 08:35:54 +0000 Subject: =?utf-8?B?562U5aSNOiBbUEFUQ0ggdjggMi81XSBkdC1iaW5kaW5nczogc2NzaTogdWZz?= =?utf-8?Q?:_add_document_for_hisi-ufs?= In-Reply-To: References: <20180213101412.5717-1-liwei213@huawei.com> <20180213101412.5717-3-liwei213@huawei.com> Message-ID: <1699CE87DE933F49876AD744B5DC140FA56267@DGGEMM506-MBS.china.huawei.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, Arnd Sorry late for you. The following two suggestions we have really discussed https://lkml.org/lkml/2017/11/30/1077 -----????----- ???: arndbergmann at gmail.com [mailto:arndbergmann at gmail.com] ?? Arnd Bergmann ????: 2018?2?19? 17:58 ???: liwei (CM) ??: Rob Herring; Mark Rutland; xuwei (O); Catalin Marinas; Will Deacon; Vinayak Holikatti; James E.J. Bottomley; Martin K. Petersen; Kevin Hilman; Gregory CLEMENT; Thomas Petazzoni; Masahiro Yamada; Riku Voipio; Thierry Reding; Krzysztof Kozlowski; Eric Anholt; DTML; Linux Kernel Mailing List; Linux ARM; linux-scsi; zangleigang; Gengjianfeng; Guodong Xu; Zhangfei Gao; Fengbaopeng (kevin, Kirin Solution Dept) ??: Re: [PATCH v8 2/5] dt-bindings: scsi: ufs: add document for hisi-ufs On Tue, Feb 13, 2018 at 11:14 AM, Li Wei wrote: > add ufs node document for Hisilicon. > > Signed-off-by: Li Wei > --- > Documentation/devicetree/bindings/ufs/ufs-hisi.txt | 37 > ++++++++++++++++++++++ > 1 file changed, 37 insertions(+) > create mode 100644 Documentation/devicetree/bindings/ufs/ufs-hisi.txt I'm pretty sure we've discussed it before, but can you make this so that the generic properties are part of the ufshcd binding, and you refer to it from here, only describing in what ways the hisi ufs binding differs from the standard? > diff --git a/Documentation/devicetree/bindings/ufs/ufs-hisi.txt > b/Documentation/devicetree/bindings/ufs/ufs-hisi.txt > new file mode 100644 > index 000000000000..0d21b57496cf > --- /dev/null > +++ b/Documentation/devicetree/bindings/ufs/ufs-hisi.txt > @@ -0,0 +1,37 @@ > +* Hisilicon Universal Flash Storage (UFS) Host Controller > + > +UFS nodes are defined to describe on-chip UFS hardware macro. > +Each UFS Host Controller should have its own node. > + > +Required properties: > +- compatible : compatible list, contains one of the following - > + "hisilicon,hi3660-ufs", "jedec,ufs-1.1" for hisi ufs > + host controller present on Hi36xx chipset. > +- reg : should contain UFS register address space & UFS SYS CTRL register address, > +- interrupt-parent : interrupt device > +- interrupts : interrupt number > +- clocks : List of phandle and clock specifier pairs > +- clock-names : List of clock input name strings sorted in the same > + order as the clocks property. > +"ref_clk", "phy_clk" is optional The clock names sound generic enough, should we have both in the generic binding? "ref_clk" is in the ufshcd-pltfrm binding, but "phy_clk" is not; what do you mean is that these two don't need to document here? > +- resets : reset node register, one reset the clk and the other reset the controller > +- reset-names : describe reset node register This looks incomplete. What is the name of the reset line supposed to be? I'd also suggest you document it in the ufshcd binding instead. As discussed in https://lkml.org/lkml/2017/11/30/1077; If document it in the ufshcd binding, I think it needs some codes to parse them in ufshcd.c/ufshcd-pltfrm.c, but I think these codes may not be applicable to other SOC manufacturers. Arnd