From: "Yigit, Ferruh" <ferruh.yigit@linux.intel.com>
To: Jie Pan <panjie5@jd.com>, ferruh.yigit@intel.com
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] lib/librte_kni: fix the type for mac address
Date: Tue, 9 Apr 2019 20:47:52 +0100 [thread overview]
Message-ID: <169db6f9-fed9-abb2-27c9-68e6fac8a9f7@linux.intel.com> (raw)
In-Reply-To: <1548301983-20020-1-git-send-email-panjie5@jd.com>
On 1/24/2019 3:53 AM, Jie Pan wrote:
> The type for mac address in struct rte_kni_conf should be unsigned.
>
> Signed-off-by: Jie Pan <panjie5@jd.com>
> ---
> lib/librte_kni/rte_kni.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/librte_kni/rte_kni.h b/lib/librte_kni/rte_kni.h
> index 02ca43b..d44496c 100644
> --- a/lib/librte_kni/rte_kni.h
> +++ b/lib/librte_kni/rte_kni.h
> @@ -68,7 +68,7 @@ struct rte_kni_conf {
>
> __extension__
> uint8_t force_bind : 1; /* Flag to bind kernel thread */
> - char mac_addr[ETHER_ADDR_LEN]; /* MAC address assigned to KNI */
> + uint8_t mac_addr[ETHER_ADDR_LEN]; /* MAC address assigned to KNI */
> uint16_t mtu;
> };
>
>
Suggested title:
kni: fix the type for MAC address
In commit log, needs:
"
Fixes: 1cfe212ed17a ("kni: support MAC address change")
Cc: stable@dpdk.org
"
Hi Jie,
What do you think about 'rte_kni_common.h', 'struct rte_kni_device_info' 'char
mac_addr[6];' field, seems added with same patch adds above 'mac_addr', does it
make sense to fix it too?
also "(unsigned char *)(dev_info.mac_addr)" in 'kni_misc.c'...
If so can you please send a new version with above fixes?
Thanks,
ferruh
next prev parent reply other threads:[~2019-04-09 19:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-24 3:53 [PATCH] lib/librte_kni: fix the type for mac address Jie Pan
2019-04-04 23:27 ` [dpdk-dev] " Thomas Monjalon
2019-04-09 19:47 ` Yigit, Ferruh [this message]
2019-04-10 6:20 ` [dpdk-dev] 答复: " 潘杰
2019-04-10 6:09 ` [dpdk-dev] [PATCH v2] kni: fix the type for MAC address Jie Pan
2019-04-10 6:20 ` Jie Pan
2019-04-19 12:15 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2019-04-19 15:29 ` Rami Rosen
2019-04-19 20:58 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=169db6f9-fed9-abb2-27c9-68e6fac8a9f7@linux.intel.com \
--to=ferruh.yigit@linux.intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=panjie5@jd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.