From: David Laight <David.Laight@ACULAB.COM>
To: 'Linus Torvalds' <torvalds@linux-foundation.org>,
Matthew Wilcox <willy@infradead.org>
Cc: "Jason A. Donenfeld" <Jason@zx2c4.com>,
Linux-MM <linux-mm@kvack.org>,
linux-xfs <linux-xfs@vger.kernel.org>,
"linux-hardening@vger.kernel.org"
<linux-hardening@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Uladzislau Rezki <urezki@gmail.com>,
"Kees Cook" <keescook@chromium.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Joe Perches <joe@perches.com>
Subject: RE: [PATCH] usercopy: use unsigned long instead of uintptr_t
Date: Fri, 17 Jun 2022 09:19:17 +0000 [thread overview]
Message-ID: <169e9522f5494a47bd99c6febf90d931@AcuMS.aculab.com> (raw)
In-Reply-To: <CAHk-=wi28vwsG-JNJEz_kc=qwPkYtYfh_14eHOUZsaGESDBDBA@mail.gmail.com>
From: Linus Torvalds
> Sent: 16 June 2022 20:19
>
> On Thu, Jun 16, 2022 at 12:14 PM Linus Torvalds
> <torvalds@linux-foundation.org> wrote:
> >
> > In that situation, we'd probably just see "long long" being 128-bit
> > ("I32LP64LL128").
>
> Looking around, it looks like people prefer "long long long" (or in
> the kernel, just "u128") for this, because so many have already gotten
> used to "long long" being 64-bit, and 32-bit architectures (where
> "long" is 32-bit and "long long" is 64-bit) are still relevant enough
> that people want to keep that.
Changing 'long long' to 128 bits will break things.
Much like a certain OS that is IL32P64LL64 because too much
code used 'long' to mean 32bits when int was 16 bits.
gcc already has support for 128bit integers (on 64bit systems)
emulated using two 64bit registers (__u128 ??)
Anything wanting them probably wants them explicitly and even deciding
that uintmax_t is suddenly 128 bit will probably break things!
The only place I can imagine 'long long long' being used
is as "%llld" in printf formats.
Since 'short' and 'long' are both types and qualifiers
you can have 'long char, 'long short' and 'short long'.
These could be interesting on an I64L256 system :-)
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
next prev parent reply other threads:[~2022-06-17 9:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-16 14:36 [PATCH] usercopy: use unsigned long instead of uintptr_t Jason A. Donenfeld
2022-06-16 14:38 ` Matthew Wilcox
2022-06-16 14:51 ` Jason A. Donenfeld
2022-06-16 15:11 ` Jason A. Donenfeld
2022-06-16 15:21 ` Matthew Wilcox
2022-06-16 15:59 ` Linus Torvalds
2022-06-16 16:12 ` Linus Torvalds
2022-06-16 16:44 ` Matthew Wilcox
2022-06-16 16:56 ` Linus Torvalds
2022-06-16 19:14 ` Linus Torvalds
2022-06-16 19:18 ` Linus Torvalds
2022-06-17 9:19 ` David Laight [this message]
2022-06-17 7:58 ` Geert Uytterhoeven
2022-06-17 11:05 ` Christophe Leroy
2022-06-17 12:51 ` David Laight
2022-06-16 16:29 ` Kees Cook
2022-06-16 16:36 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=169e9522f5494a47bd99c6febf90d931@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=Jason@zx2c4.com \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=keescook@chromium.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=urezki@gmail.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.