From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43564)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <den@virtuozzo.com>) id 1cdAmB-0002Sc-CI
	for qemu-devel@nongnu.org; Mon, 13 Feb 2017 02:10:20 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <den@virtuozzo.com>) id 1cdAm8-0008Qp-6k
	for qemu-devel@nongnu.org; Mon, 13 Feb 2017 02:10:19 -0500
Received: from mail-db5eur01on0136.outbound.protection.outlook.com
	([104.47.2.136]:45037
	helo=EUR01-DB5-obe.outbound.protection.outlook.com)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <den@virtuozzo.com>) id 1cdAm7-0008QT-LW
	for qemu-devel@nongnu.org; Mon, 13 Feb 2017 02:10:16 -0500
References: <1486134413-19988-1-git-send-email-den@openvz.org>
	<5909b505-fecb-fa98-6ae7-190b846add4c@openvz.org>
From: "Denis V. Lunev" <den@virtuozzo.com>
Message-ID: <169f96e8-0ca5-264d-350a-7f085905bd5b@virtuozzo.com>
Date: Mon, 13 Feb 2017 10:10:06 +0300
MIME-Version: 1.0
In-Reply-To: <5909b505-fecb-fa98-6ae7-190b846add4c@openvz.org>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/1] mirror: do not increase offset during
 initial zero_or_discard phase - pls consider this as V3 patch
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Anton Nefedov <anton.nefedov@virtuozzo.com>, Jeff Cody <jcody@redhat.com>, Kevin Wolf <kwolf@redhat.com>, Max Reitz <mreitz@redhat.com>

On 02/03/2017 06:08 PM, Denis V. Lunev wrote:
> On 02/03/2017 06:06 PM, Denis V. Lunev wrote:
>> From: Anton Nefedov <anton.nefedov@virtuozzo.com>
>>
>> If explicit zeroing out before mirroring is required for the target image,
>> it moves the block job offset counter to EOF, then offset and len counters
>> count the image size twice. There is no harm but stats are confusing,
>> specifically the progress of the operation is always reported as 99% by
>> management tools.
>>
>> The patch skips offset increase for the first "technical" pass over the
>> image. This should not cause any further harm.
>>
>> Signed-off-by: Anton Nefedov <anton.nefedov@virtuozzo.com>
>> Signed-off-by: Denis V. Lunev <den@openvz.org>
>> Reviewed-by: Eric Blake <eblake@redhat.com>
>> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
>> CC: Jeff Cody <jcody@redhat.com>
>> CC: Kevin Wolf <kwolf@redhat.com>
>> CC: Max Reitz <mreitz@redhat.com>
> actually this is V3 patch. Sorry for broken subject.
>
> Den
ping