From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BF46C4360F for ; Fri, 22 Feb 2019 22:52:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 195B620645 for ; Fri, 22 Feb 2019 22:52:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="tKAcXxB+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726766AbfBVWwv (ORCPT ); Fri, 22 Feb 2019 17:52:51 -0500 Received: from mail-wm1-f65.google.com ([209.85.128.65]:55513 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726278AbfBVWwv (ORCPT ); Fri, 22 Feb 2019 17:52:51 -0500 Received: by mail-wm1-f65.google.com with SMTP id q187so3329108wme.5 for ; Fri, 22 Feb 2019 14:52:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=EX4d3H8UXpzfUTPO5lBeBCFVcZ0SGckReuR9iVdKIfE=; b=tKAcXxB+dNU2RCGNdzEW2nLVfFQvMyvKI5Zkj3jwyLffARWFQSlVB8RtAklvN0YpS2 AsGj0nn1ianMrj1DmQrIhC4Wdt8jbv8/Ksec3HvlrHQWC00FZXtOhl93KE3OMsjXdxkG pgCG4+KYJY69YbrgyzjRKqirCtzsGT/UgKBLXvVZ0D3AsTHdxaoo4DLOmtNdnnl5OrCu T9Wy87jL6SRehVTfhno7JUMIl1LP91bsG1tdii2TxZD3XHO/blYReAezvEgzCwfF4tzm nuZTJjBEr8Mt5SK6o/toNZeBetaCnHyCIt59jx+qk5D4TvikvwWUDBrmmFFRd2c13oUI VMRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=EX4d3H8UXpzfUTPO5lBeBCFVcZ0SGckReuR9iVdKIfE=; b=F/wvH+1DXj49qE07DDaLXBAuCzu6XX+f+CjbZOVXQas05eRwBjfNV84nUB4U/aRfJh xtjiLZzpCRxxbrdUvPu4Ys3VwujkYJ+ZUj2J0Z5rJAHIDGCTNUfHoNo0KQ3n9+6dL4cg JJvH96yQCALgIxP+/CqPG1MG6E8tbqkNtaWeq1/y4kl+ECDNnN1tKGxH0d9NWwLi1Ges tTFapexLbdc4md1p0VjsIM/Xh9y20FoAM78GU5RmZTdYyHt/Lau0aj9+tQ7FlhiEb6j5 zASqYWWj0z+w6pe+m1GweRtwSUveSXrbvQyxNZQpZghzaVxfTVUJnqJlmK8wCbFryCY4 ODaw== X-Gm-Message-State: AHQUAuZtRcj383nVq+D7hbmStPkQiyR6InCJCKmaaXDE/+EWouiOayGR 8h+C0mRAKZtRulXO5AOLjxfSt9kl X-Google-Smtp-Source: AHgI3IYrs2SfTxLudjdT7omcYJyr2NrcWJDWkVGS+hR4SgamRkMN95p5SQbF7dCHBCb94NNjmyjNVA== X-Received: by 2002:a7b:c013:: with SMTP id c19mr3541162wmb.27.1550875968776; Fri, 22 Feb 2019 14:52:48 -0800 (PST) Received: from ?IPv6:2003:ea:8bf1:e200:881a:e62a:a902:5b57? (p200300EA8BF1E200881AE62AA9025B57.dip0.t-ipconnect.de. [2003:ea:8bf1:e200:881a:e62a:a902:5b57]) by smtp.googlemail.com with ESMTPSA id f10sm1644100wmb.35.2019.02.22.14.52.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 22 Feb 2019 14:52:48 -0800 (PST) Subject: [PATCH net-next 3/5] net: phy: don't change modes we don't care about in genphy_c45_read_lpa From: Heiner Kallweit To: Andrew Lunn , Florian Fainelli , David Miller Cc: "netdev@vger.kernel.org" References: <4ae20155-367d-4b11-63f9-28580b7cf1cb@gmail.com> Message-ID: <169fb578-af1e-de15-aa2c-9e750248fd5b@gmail.com> Date: Fri, 22 Feb 2019 23:50:49 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <4ae20155-367d-4b11-63f9-28580b7cf1cb@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Because 1000BaseT isn't covered by Clause 45, the 1000BaseT flags in phydev->lp_advertising may have been set based on vendor registers already. genphy_c45_read_lpa() would clear these flags as of today. Therefore switch to mii_lpa_mod_linkmode_lpa_t. Signed-off-by: Heiner Kallweit --- drivers/net/phy/phy-c45.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/phy/phy-c45.c b/drivers/net/phy/phy-c45.c index ce5fa5346..65ee33e34 100644 --- a/drivers/net/phy/phy-c45.c +++ b/drivers/net/phy/phy-c45.c @@ -268,7 +268,7 @@ int genphy_c45_read_lpa(struct phy_device *phydev) if (val < 0) return val; - mii_lpa_to_linkmode_lpa_t(phydev->lp_advertising, val); + mii_lpa_mod_linkmode_lpa_t(phydev->lp_advertising, val); phydev->pause = val & LPA_PAUSE_CAP ? 1 : 0; phydev->asym_pause = val & LPA_PAUSE_ASYM ? 1 : 0; -- 2.20.1